Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 17, 2016, 6:56 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48781: Marked some optional fields in acls.proto as required.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48781/#review138174 --- Sorry if I let an "optional" through and then it spread like wildf

Re: Review Request 48841: Add Agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/#review138173 --- include/mesos/mesos.proto (line 2034)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 17, 2016, 6:07 a.m., haosdent huang wrote: > > src/master/http.cpp, line 1447 > > > > > > How about change > > ``` > > message GetTasks { > > optional string limit = 1; > > option

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review138171 --- src/master/http.cpp (line 1445)

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 17, 2016, 6:37 a.m.) Review request for mesos, Anand Mazumdar, haos

Review Request 48841: Add Agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs:

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138170 --- src/Makefile.am (line 693)

Re: Review Request 48832: Changed build to always enable Nvidia GPU support for Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48832/ --- (Updated June 17, 2016, 6:29 a.m.) Review request for mesos and Benjamin Mahler

Review Request 48832: Changed build to always enable Nvidia GPU support for Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48832/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138169 --- src/master/http.cpp (line 2485)

Re: Review Request 48450: Add unit test for master /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review138168 --- src/tests/master_tests.cpp (line 2510)

Re: Review Request 48449: Add Task proto message to v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48449/#review138167 --- Ship it! Ship It! - haosdent huang On June 9, 2016, midnight

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review138166 --- src/master/http.cpp (line 1442)

Re: Review Request 48824: Updated the documentation regarding quota authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48824/ --- (Updated June 17, 2016, 6:10 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/ --- (Updated June 17, 2016, 6:10 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 48824: Updated the documentation regarding quota authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48824/ --- (Updated June 17, 2016, 6:07 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review138165 --- src/master/http.cpp (line 1445)

Re: Review Request 48781: Marked some optional fields in acls.proto as required.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48781/ --- (Updated June 17, 2016, 8:05 a.m.) Review request for mesos, Joerg Schad and Ti

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 17, 2016, 5:47 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48401: Change GetTask.limit type to int32 with default value 100.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48401/ --- (Updated June 17, 2016, 5:47 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48838: Added missing `stout/elf.hpp` file to `nobase_include_HEADERS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48838/#review138161 --- Ship it! - Kapil Arya On June 17, 2016, 1:44 a.m., Kevin Klue

Re: Review Request 48838: Added missing `stout/elf.hpp` file to `nobase_include_HEADERS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48838/ --- (Updated June 17, 2016, 5:44 a.m.) Review request for mesos and Kapil Arya. C

Review Request 48838: Added missing `stout/elf.hpp` file to `nobase_include_HEADERS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48838/ --- Review request for mesos and Kapil Arya. Bugs: 5400 https://issues.apache.o

Re: Review Request 48836: Fixed variable shadowing in `launchTaskPosix`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48836/#review138156 --- Patch looks great! Reviews applied: [48836] Passed command: expo

Re: Review Request 48835: Remove duplicate return in getHealth method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48835/#review138150 --- Patch looks great! Reviews applied: [48835] Passed command: expo

Re: Review Request 48836: Fixed variable shadowing in `launchTaskPosix`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48836/ --- (Updated June 17, 2016, 3:34 a.m.) Review request for mesos, Gilbert Song, Guan

Review Request 48836: Fixed variable shadowing in `launchTaskPosix`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48836/ --- Review request for mesos, Gilbert Song, Guangya Liu, Jie Yu, and Vinod Kone. Re

Re: Review Request 48835: Remove duplicate return in getHealth method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48835/#review138149 --- Ship it! Thank you for fix my bug. My bad that don't remove thi

Review Request 48835: Remove duplicate return in getHealth method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48835/ --- Review request for mesos, haosdent huang and Vinod Kone. Repository: mesos De

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48580/#review138148 --- Patch looks great! Reviews applied: [48115, 48116, 48257, 48084,

Re: Review Request 48824: Updated the documentation regarding quota authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48824/#review138143 --- Bad patch! Reviews applied: [48824, 48040, 48038, 48039, 48037, 4

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48580/ --- (Updated June 17, 2016, 1:28 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48285: Implemented START_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48285/ --- (Updated June 17, 2016, 1:28 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48286/ --- (Updated June 17, 2016, 1:28 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48084: Implemented GET_MAINTENANCE_STATUS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 17, 2016, 1:27 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48260/ --- (Updated June 17, 2016, 1:27 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/ --- (Updated June 17, 2016, 1:27 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48259/ --- (Updated June 17, 2016, 1:27 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/ --- (Updated June 17, 2016, 1:27 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48115: Added maintenance V1 header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48115/ --- (Updated June 17, 2016, 1:26 a.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 48815: Made all Entities required in acls.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48815/#review138142 --- Patch looks great! Reviews applied: [48781, 48815] Passed comman

Re: Review Request 48824: Updated the documentation regarding quota authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48824/#review138140 --- Ship it! Ship It! - Alexander Rukletsov On June 16, 2016, 11

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review138138 --- src/master/master.hpp (line 1317)

Re: Review Request 48450: Add unit test for master /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review138139 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 11:13 p.m.,

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48040/#review138137 --- Ship it! Ship It! - Alexander Rukletsov On June 16, 2016, 10

Re: Review Request 48401: Change GetTask.limit type to int32 with default value 100.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48401/#review138136 --- include/mesos/v1/master.proto (line 111)

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/#review138135 --- Ship it! Ship It! - Alexander Rukletsov On June 16, 2016, 11

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- (Updated June 17, 2016, 12:31 a.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

> On June 15, 2016, 6:08 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 987 > > > > > > Is there a guarantee that the plugin would be waiting for the isolator >

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review138128 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/#review138131 --- Ship it! Ship It! - Alexander Rukletsov On June 16, 2016, 10

Re: Review Request 48684: Revised documentation for task reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48684/#review138126 --- Ship it! Ship It! - Till Toenshoff On June 14, 2016, 12:03 p

Re: Review Request 48745: Removed JNI major version check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48745/#review138125 --- Patch looks great! Reviews applied: [48745] Passed command: expo

Re: Review Request 48825: Added documentation about replicated log metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48825/ --- (Updated June 16, 2016, 11:47 p.m.) Review request for mesos and Joseph Wu. C

Re: Review Request 48635: Fixed various typos and grammar nits in upgrade notes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48635/#review138123 --- Ship it! Ship It! - Till Toenshoff On June 13, 2016, 1:16 p.

Re: Review Request 48825: Added documentation about replicated log metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48825/#review138122 --- Fix it, then Ship it! docs/monitoring.md (line 273)

Re: Review Request 48367: Added test to verify that GPU auto-discovery works.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48367/#review138110 --- Ship it! Thanks for the tests! Here is the diff I applied befor

Re: Review Request 48366: Added auto-discovery of GPUs for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48366/#review138106 --- Fix it, then Ship it! src/slave/containerizer/containerizer.cp

Review Request 48825: Added documentation about replicated log metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48825/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 16, 2016, 11:23 p.m.) Review request for mesos, Gilbert Song and Ji

Re: Review Request 48764: Refactored sandbox authorization logic to use ObjectAuthorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48764/#review138119 --- Ship it! Ship It! - Till Toenshoff On June 16, 2016, 5:34 p.

Review Request 48824: Updated the documentation regarding quota authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48824/ --- Review request for mesos, Alexander Rukletsov, Vinod Kone, and Zhitao Li. Bugs:

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/ --- (Updated June 16, 2016, 11:03 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/ --- (Updated June 16, 2016, 10:48 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48037/ --- (Updated June 16, 2016, 10:47 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48040/ --- (Updated June 16, 2016, 10:47 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/ --- (Updated June 16, 2016, 10:47 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/ --- (Updated June 16, 2016, 10:47 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/ --- (Updated June 16, 2016, 10:47 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48806: Added Berlin usergroup to community page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48806/#review138108 --- Patch looks great! Reviews applied: [48806] Passed command: expo

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/ --- (Updated June 16, 2016, 10:39 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/ --- (Updated June 16, 2016, 10:34 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/ --- (Updated June 16, 2016, 10:34 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48040/ --- (Updated June 16, 2016, 10:34 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48037/ --- (Updated June 16, 2016, 10:22 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48040/ --- (Updated June 16, 2016, 10:20 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/ --- (Updated June 16, 2016, 10:20 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/ --- (Updated June 16, 2016, 10:20 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48040/ --- (Updated June 16, 2016, 10:10 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/ --- (Updated June 16, 2016, 10:09 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/ --- (Updated June 16, 2016, 10:10 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48037/ --- (Updated June 16, 2016, 10:10 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48037/ --- (Updated June 16, 2016, 10:05 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

> On May 30, 2016, 1:22 p.m., Till Toenshoff wrote: > > src/master/quota_handler.cpp, lines 575-580 > > > > > > Is there a JIRA around introducing LocalAuthorizer specific deprecation > > cycles - I would like to un

Re: Review Request 48803: Added a test for replicated log metrics.

> On June 16, 2016, 9:47 p.m., Joseph Wu wrote: > > src/tests/log_tests.cpp, lines 2088-2089 > > > > > > Add a "not-recovered" check here. > > > > ``` > > ASSERT_EQ(1u, snapshot.values.count("prefix/log

Re: Review Request 48781: Marked some optional fields in state.json as required.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48781/#review138102 --- What exactly is the connection with "state.json"? - Till Toenshof

Re: Review Request 48802: Added a metrics prefix for registrar replicated log.

> On June 16, 2016, 9:19 p.m., Joseph Wu wrote: > > src/master/main.cpp, line 416 > > > > > > With this, the metric name becomes `registrarlog/recovered`. Maybe use > > `registrar/` instead? Thanks! Good catch!

Re: Review Request 48801: Added a metric to replicated log.

> On June 16, 2016, 9:13 p.m., Joseph Wu wrote: > > src/log/log.hpp, line 111 > > > > > > It might make sense for this to be a `Counter`, since the `recovered` > > promise should only ever go from not-ready to ready

Re: Review Request 48806: Added Berlin usergroup to community page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48806/#review138099 --- Ship it! Ship It! - Till Toenshoff On June 16, 2016, 6 p.m.,

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

> On May 30, 2016, 9:39 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 40 > > > > > > Let's add a todo here that this dependency is temporary. I've removed the `dynamic_cast` to `LocalAuthori

Re: Review Request 48803: Added a test for replicated log metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48803/#review138075 --- Fix it, then Ship it! src/tests/log_tests.cpp (line 2086)

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48040/ --- (Updated June 16, 2016, 9:46 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/ --- (Updated June 16, 2016, 9:45 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/ --- (Updated June 16, 2016, 9:45 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 48376: Changed semantics for granting access to /dev/nvidiactl, etc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48376/#review138097 --- Ship it! - Benjamin Mahler On June 11, 2016, 3:05 a.m., Kevin

Re: Review Request 48781: Marked some optional fields in state.json as required.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48781/#review138092 --- include/mesos/authorizer/acls.proto (line 169)

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48040/#review138090 --- Bad patch! Reviews applied: [48040, 48039, 48038, 48037, 47977, 4

Re: Review Request 48802: Added a metrics prefix for registrar replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48802/#review138087 --- Fix it, then Ship it! Can you add a patch to update the monitor

Re: Review Request 48801: Added a metric to replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48801/#review138086 --- Ship it! src/log/log.hpp (line 111)

  1   2   3   >