[GitHub] [spark] AmplabJenkins commented on pull request #34461: SPARK-37023: Avoid fetching merge status when shuffleMergeEnabled is false for a shuffleDependency during retry

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34461: URL: https://github.com/apache/spark/pull/34461#issuecomment-956762384 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32648: [WIP][SPARK-35496][BUILD] Upgrade Scala to 2.13.7

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #32648: URL: https://github.com/apache/spark/pull/32648#issuecomment-957168866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] Kimahriman commented on pull request #34294: [SPARK-37019][SQL] Add codegen support to array transform

2021-11-02 Thread GitBox
Kimahriman commented on pull request #34294: URL: https://github.com/apache/spark/pull/34294#issuecomment-956889103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [spark] SparkQA commented on pull request #32648: [WIP][SPARK-35496][BUILD] Upgrade Scala to 2.13.7

2021-11-02 Thread GitBox
SparkQA commented on pull request #32648: URL: https://github.com/apache/spark/pull/32648#issuecomment-957119920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [spark] zero323 commented on a change in pull request #34466: [SPARK-37152][PYTHON] Inline type hints for python/pyspark/context.py

2021-11-02 Thread GitBox
zero323 commented on a change in pull request #34466: URL: https://github.com/apache/spark/pull/34466#discussion_r740926529 ## File path: python/pyspark/context.py ## @@ -150,8 +161,10 @@ def __init__(self, master=None, appName=None, sparkHome=None, pyFiles=None,

[GitHub] [spark] huaxingao commented on pull request #34445: [SPARK-36646][SQL] Push down group by partition column for aggregate

2021-11-02 Thread GitBox
huaxingao commented on pull request #34445: URL: https://github.com/apache/spark/pull/34445#issuecomment-957969098 @c21 Thanks a lot for review! I have addressed the comments. Please take one more look when you have time. Thanks! also cc @sunchao @viirya -- This is an automated messa

[GitHub] [spark] sadikovi commented on pull request #34462: [SPARK-37191] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
sadikovi commented on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-957049103 cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [spark] SparkQA removed a comment on pull request #34356: [SPARK-36554][SQL][PYTHON] Expose make_date expression in functions.scala

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34356: URL: https://github.com/apache/spark/pull/34356#issuecomment-956293508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957354917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957211122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] rmcyang commented on pull request #34461: SPARK-37023: Avoid fetching merge status when shuffleMergeEnabled is false for a shuffleDependency during retry

2021-11-02 Thread GitBox
rmcyang commented on pull request #34461: URL: https://github.com/apache/spark/pull/34461#issuecomment-956771807 cc @mridulm @Ngone51 @venkata91 @zhouyejoe Please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sarutak closed pull request #34356: [SPARK-36554][SQL][PYTHON] Expose make_date expression in functions.scala

2021-11-02 Thread GitBox
sarutak closed pull request #34356: URL: https://github.com/apache/spark/pull/34356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubs

[GitHub] [spark] sarutak closed pull request #34425: [SPARK-37159][SQL][TESTS] Change HiveExternalCatalogVersionsSuite to be able to test with Java 17

2021-11-02 Thread GitBox
sarutak closed pull request #34425: URL: https://github.com/apache/spark/pull/34425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubs

[GitHub] [spark] AmplabJenkins commented on pull request #34402: [SPARK-30220] Enable using Exists/In subqueries outside of the Filter node

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34402: URL: https://github.com/apache/spark/pull/34402#issuecomment-957164941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] cloud-fan commented on a change in pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #3: URL: https://github.com/apache/spark/pull/3#discussion_r740786516 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -332,6 +327,266 @@ case class ShuffledHashJ

[GitHub] [spark] sarutak commented on pull request #34356: [SPARK-36554][SQL][PYTHON] Expose make_date expression in functions.scala

2021-11-02 Thread GitBox
sarutak commented on pull request #34356: URL: https://github.com/apache/spark/pull/34356#issuecomment-957017172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [spark] AmplabJenkins commented on pull request #34462: [SPARK-37191] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-956883045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] SparkQA commented on pull request #34445: [SPARK-36646][SQL] Push down group by partition column for aggregate

2021-11-02 Thread GitBox
SparkQA commented on pull request #34445: URL: https://github.com/apache/spark/pull/34445#issuecomment-957975899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [spark] SparkQA commented on pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
SparkQA commented on pull request #34459: URL: https://github.com/apache/spark/pull/34459#issuecomment-957975955 **[Test build #144854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144854/testReport)** for PR 34459 at commit [`7a25119`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #34463: [SPARK-37190][SQL] Improve error messages for Cast under ANSI mode

2021-11-02 Thread GitBox
SparkQA commented on pull request #34463: URL: https://github.com/apache/spark/pull/34463#issuecomment-957975840 **[Test build #144853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144853/testReport)** for PR 34463 at commit [`85c3695`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
SparkQA commented on pull request #34459: URL: https://github.com/apache/spark/pull/34459#issuecomment-957975212 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49322/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: Support drop index

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-957974155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957974192 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144847/ -

[GitHub] [spark] AmplabJenkins commented on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957974192 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144847/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34469: Support drop index

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-957974156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] SparkQA removed a comment on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957461364 **[Test build #144847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144847/testReport)** for PR 34468 at commit [`6ab6dc0`](https://gi

[GitHub] [spark] singhpk234 commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

2021-11-02 Thread GitBox
singhpk234 commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r740830504 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/DynamicJoinSelection.scala ## @@ -50,10 +51,16 @@ object DynamicJoinSele

[GitHub] [spark] SparkQA commented on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
SparkQA commented on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957972469 **[Test build #144847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144847/testReport)** for PR 34468 at commit [`6ab6dc0`](https://github.co

[GitHub] [spark] huaxingao commented on pull request #34445: [SPARK-36646][SQL] Push down group by partition column for aggregate

2021-11-02 Thread GitBox
huaxingao commented on pull request #34445: URL: https://github.com/apache/spark/pull/34445#issuecomment-957969098 @c21 Thanks a lot for review! I have addressed the comments. Please take one more look when you have time. Thanks! also cc @sunchao @viirya -- This is an automated messa

[GitHub] [spark] huaxingao commented on a change in pull request #34445: [SPARK-36646][SQL] Push down group by partition column for aggregate

2021-11-02 Thread GitBox
huaxingao commented on a change in pull request #34445: URL: https://github.com/apache/spark/pull/34445#discussion_r741315128 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceAggregatePushDownSuite.scala ## @@ -261,6 +261,63 @@ trait F

[GitHub] [spark] xinrong-databricks commented on pull request #34374: [SPARK-37104][PYTHON] Make RDD and DStream covariant

2021-11-02 Thread GitBox
xinrong-databricks commented on pull request #34374: URL: https://github.com/apache/spark/pull/34374#issuecomment-957965048 Would you please give a short example of how the PR **improves the usability of the current annotations and simplifies further development of type hints**? -- This

[GitHub] [spark] xinrong-databricks edited a comment on pull request #34374: [SPARK-37104][PYTHON] Make RDD and DStream covariant

2021-11-02 Thread GitBox
xinrong-databricks edited a comment on pull request #34374: URL: https://github.com/apache/spark/pull/34374#issuecomment-957965048 Would you please give a short example of how the PR **improves the usability of the current annotations and simplifies further development of type hints**? Tha

[GitHub] [spark] SparkQA commented on pull request #34467: [SPARK-36895][SQL][FOLLOWUP] CREATE INDEX command should rely on the analyzer framework to resolve columns

2021-11-02 Thread GitBox
SparkQA commented on pull request #34467: URL: https://github.com/apache/spark/pull/34467#issuecomment-957961563 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49321/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #34469: Support drop index

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-957748528 **[Test build #144850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144850/testReport)** for PR 34469 at commit [`dc97485`](https://gi

[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index

2021-11-02 Thread GitBox
SparkQA commented on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-957954933 **[Test build #144850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144850/testReport)** for PR 34469 at commit [`dc97485`](https://github.co

[GitHub] [spark] gengliangwang commented on a change in pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
gengliangwang commented on a change in pull request #34459: URL: https://github.com/apache/spark/pull/34459#discussion_r741300024 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -2052,6 +2068,7 @@ object AnsiCast { * Spa

[GitHub] [spark] gengliangwang commented on a change in pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
gengliangwang commented on a change in pull request #34459: URL: https://github.com/apache/spark/pull/34459#discussion_r741298185 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala ## @@ -971,6 +971,10 @@ object QueryExecutionError

[GitHub] [spark] cloud-fan commented on a change in pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34459: URL: https://github.com/apache/spark/pull/34459#discussion_r741296154 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala ## @@ -971,6 +971,10 @@ object QueryExecutionErrors {

[GitHub] [spark] cloud-fan commented on a change in pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34459: URL: https://github.com/apache/spark/pull/34459#discussion_r741295726 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -2069,6 +2086,8 @@ object AnsiCast { case (St

[GitHub] [spark] cloud-fan commented on a change in pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34459: URL: https://github.com/apache/spark/pull/34459#discussion_r741295477 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -2052,6 +2068,7 @@ object AnsiCast { * Spark's

[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index

2021-11-02 Thread GitBox
SparkQA commented on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-957942782 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49320/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34302: [SPARK-37028][UI] Add a 'kill' executor link in the Web UI.

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34302: URL: https://github.com/apache/spark/pull/34302#issuecomment-945630961 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [spark] sunchao commented on a change in pull request #34199: [SPARK-36935][SQL] Extend ParquetSchemaConverter to compute Parquet repetition & definition level

2021-11-02 Thread GitBox
sunchao commented on a change in pull request #34199: URL: https://github.com/apache/spark/pull/34199#discussion_r741284780 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala ## @@ -43,57 +41,128 @@ import org.

[GitHub] [spark] SparkQA commented on pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
SparkQA commented on pull request #34459: URL: https://github.com/apache/spark/pull/34459#issuecomment-957936847 **[Test build #144852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144852/testReport)** for PR 34459 at commit [`35dd195`](https://github.com

[GitHub] [spark] sunchao commented on a change in pull request #34199: [SPARK-36935][SQL] Extend ParquetSchemaConverter to compute Parquet repetition & definition level

2021-11-02 Thread GitBox
sunchao commented on a change in pull request #34199: URL: https://github.com/apache/spark/pull/34199#discussion_r741280205 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java ## @@ -152,6 +152,7 @@ prote

[GitHub] [spark] sunchao commented on a change in pull request #34199: [SPARK-36935][SQL] Extend ParquetSchemaConverter to compute Parquet repetition & definition level

2021-11-02 Thread GitBox
sunchao commented on a change in pull request #34199: URL: https://github.com/apache/spark/pull/34199#discussion_r741277620 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala ## @@ -43,57 +41,128 @@ import org.

[GitHub] [spark] SparkQA commented on pull request #34467: [SPARK-36895][SQL][FOLLOWUP] CREATE INDEX command should rely on the analyzer framework to resolve columns

2021-11-02 Thread GitBox
SparkQA commented on pull request #34467: URL: https://github.com/apache/spark/pull/34467#issuecomment-957923837 **[Test build #144851 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144851/testReport)** for PR 34467 at commit [`67040eb`](https://github.com

[GitHub] [spark] sunchao commented on a change in pull request #34199: [SPARK-36935][SQL] Extend ParquetSchemaConverter to compute Parquet repetition & definition level

2021-11-02 Thread GitBox
sunchao commented on a change in pull request #34199: URL: https://github.com/apache/spark/pull/34199#discussion_r741271037 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetColumn.scala ## @@ -0,0 +1,68 @@ +/* + * Licensed to the

[GitHub] [spark] allisonwang-db commented on a change in pull request #34459: [SPARK-37179][SQL] ANSI mode: Allow casting between Timestamp and Numeric

2021-11-02 Thread GitBox
allisonwang-db commented on a change in pull request #34459: URL: https://github.com/apache/spark/pull/34459#discussion_r741263371 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala ## @@ -971,6 +971,10 @@ object QueryExecutionErro

[GitHub] [spark] allisonwang-db commented on a change in pull request #34459: [SPARK-37179][SQL] ANSI mode: Allow casting between Timestamp and Numeric

2021-11-02 Thread GitBox
allisonwang-db commented on a change in pull request #34459: URL: https://github.com/apache/spark/pull/34459#discussion_r741262498 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala ## @@ -971,6 +971,10 @@ object QueryExecutionErro

[GitHub] [spark] GaruGaru commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-11-02 Thread GitBox
GaruGaru commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-957914768 Any update on this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index

2021-11-02 Thread GitBox
SparkQA commented on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-957902710 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49320/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957832459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957832459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] srowen commented on pull request #34337: [SPARK-37066][SQL] Improve error message to show file path when failed to read next file

2021-11-02 Thread GitBox
srowen commented on pull request #34337: URL: https://github.com/apache/spark/pull/34337#issuecomment-957827084 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [spark] srowen closed pull request #34337: [SPARK-37066][SQL] Improve error message to show file path when failed to read next file

2021-11-02 Thread GitBox
srowen closed pull request #34337: URL: https://github.com/apache/spark/pull/34337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubsc

[GitHub] [spark] SparkQA commented on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
SparkQA commented on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957772182 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49319/ -- This is an automated message from the A

[GitHub] [spark] SparkQA removed a comment on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957590368 **[Test build #144849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144849/testReport)** for PR 33522 at commit [`0e0c085`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
SparkQA commented on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957764870 **[Test build #144849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144849/testReport)** for PR 33522 at commit [`0e0c085`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #34469: Support drop index

2021-11-02 Thread GitBox
SparkQA commented on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-957748528 **[Test build #144850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144850/testReport)** for PR 34469 at commit [`dc97485`](https://github.com

[GitHub] [spark] huaxingao opened a new pull request #34469: Support drop index

2021-11-02 Thread GitBox
huaxingao opened a new pull request #34469: URL: https://github.com/apache/spark/pull/34469 ### What changes were proposed in this pull request? add drop index syntax ``` DROP INDEX [IF EXISTS] index_name ON [TABLE] table_name ``` ### Why are the changes needed?

[GitHub] [spark] ulysses-you commented on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
ulysses-you commented on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957744307 cc @yaooqinn @cloud-fan @viirya if you have time to take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [spark] huaxingao commented on a change in pull request #34467: [SPARK-36895][SQL][FOLLOWUP] CREATE INDEX command should rely on the analyzer framework to resolve columns

2021-11-02 Thread GitBox
huaxingao commented on a change in pull request #34467: URL: https://github.com/apache/spark/pull/34467#discussion_r741142738 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -4439,7 +4439,7 @@ class AstBuilder extends SqlBa

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34467: [SPARK-36895][SQL][FOLLOWUP] CREATE INDEX command should rely on the analyzer framework to resolve columns

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34467: URL: https://github.com/apache/spark/pull/34467#issuecomment-957719536 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144845/ -

[GitHub] [spark] AmplabJenkins commented on pull request #34467: [SPARK-36895][SQL][FOLLOWUP] CREATE INDEX command should rely on the analyzer framework to resolve columns

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34467: URL: https://github.com/apache/spark/pull/34467#issuecomment-957719536 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144845/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #34467: [SPARK-36895][SQL][FOLLOWUP] CREATE INDEX command should rely on the analyzer framework to resolve columns

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34467: URL: https://github.com/apache/spark/pull/34467#issuecomment-957265199 **[Test build #144845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144845/testReport)** for PR 34467 at commit [`fe2115e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #34467: [SPARK-36895][SQL][FOLLOWUP] CREATE INDEX command should rely on the analyzer framework to resolve columns

2021-11-02 Thread GitBox
SparkQA commented on pull request #34467: URL: https://github.com/apache/spark/pull/34467#issuecomment-957714987 **[Test build #144845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144845/testReport)** for PR 34467 at commit [`fe2115e`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34460: [SPARK-36566][K8S] Add Spark appname as a label to pods

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34460: URL: https://github.com/apache/spark/pull/34460#issuecomment-957705111 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49318/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957705116 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49317/

[GitHub] [spark] AmplabJenkins commented on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957705116 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49317/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #34460: [SPARK-36566][K8S] Add Spark appname as a label to pods

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34460: URL: https://github.com/apache/spark/pull/34460#issuecomment-957705111 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49318/ -- T

[GitHub] [spark] SparkQA commented on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
SparkQA commented on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957680142 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49319/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34460: [SPARK-36566][K8S] Add Spark appname as a label to pods

2021-11-02 Thread GitBox
SparkQA commented on pull request #34460: URL: https://github.com/apache/spark/pull/34460#issuecomment-957676008 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49318/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
SparkQA commented on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957638345 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49317/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
SparkQA commented on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957590368 **[Test build #144849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144849/testReport)** for PR 33522 at commit [`0e0c085`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #34460: [SPARK-36566][K8S] Add Spark appname as a label to pods

2021-11-02 Thread GitBox
SparkQA commented on pull request #34460: URL: https://github.com/apache/spark/pull/34460#issuecomment-957555487 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49318/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
SparkQA commented on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957554177 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49317/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34455: URL: https://github.com/apache/spark/pull/34455#issuecomment-957495211 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144841/ -

[GitHub] [spark] AmplabJenkins commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34455: URL: https://github.com/apache/spark/pull/34455#issuecomment-957495211 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144841/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34460: [SPARK-36566][K8S] Add Spark appname as a label to pods

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34460: URL: https://github.com/apache/spark/pull/34460#issuecomment-957492287 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144848/ -

[GitHub] [spark] SparkQA removed a comment on pull request #34460: [SPARK-36566][K8S] Add Spark appname as a label to pods

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34460: URL: https://github.com/apache/spark/pull/34460#issuecomment-957461389 **[Test build #144848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144848/testReport)** for PR 34460 at commit [`61c462c`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #34460: [SPARK-36566][K8S] Add Spark appname as a label to pods

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34460: URL: https://github.com/apache/spark/pull/34460#issuecomment-957492287 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144848/ -- This

[GitHub] [spark] SparkQA commented on pull request #34460: [SPARK-36566][K8S] Add Spark appname as a label to pods

2021-11-02 Thread GitBox
SparkQA commented on pull request #34460: URL: https://github.com/apache/spark/pull/34460#issuecomment-957491491 **[Test build #144848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144848/testReport)** for PR 34460 at commit [`61c462c`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34455: URL: https://github.com/apache/spark/pull/34455#issuecomment-957166042 **[Test build #144841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144841/testReport)** for PR 34455 at commit [`8dae181`](https://gi

[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method

2021-11-02 Thread GitBox
SparkQA commented on pull request #34455: URL: https://github.com/apache/spark/pull/34455#issuecomment-957488906 **[Test build #144841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144841/testReport)** for PR 34455 at commit [`8dae181`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957485778 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144846/ -

[GitHub] [spark] AmplabJenkins commented on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957485778 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144846/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957268010 **[Test build #144846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144846/testReport)** for PR 34468 at commit [`29adcfe`](https://gi

[GitHub] [spark] SparkQA commented on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
SparkQA commented on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957483633 **[Test build #144846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144846/testReport)** for PR 34468 at commit [`29adcfe`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
SparkQA commented on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957461364 **[Test build #144847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144847/testReport)** for PR 34468 at commit [`6ab6dc0`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #34460: [SPARK-36566][K8S] Add Spark appname as a label to pods

2021-11-02 Thread GitBox
SparkQA commented on pull request #34460: URL: https://github.com/apache/spark/pull/34460#issuecomment-957461389 **[Test build #144848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144848/testReport)** for PR 34460 at commit [`61c462c`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-957456723 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144830/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-957456723 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144830/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-957070742 **[Test build #144830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144830/testReport)** for PR 33628 at commit [`7ae2b8d`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-11-02 Thread GitBox
SparkQA commented on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-957375305 **[Test build #144830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144830/testReport)** for PR 33628 at commit [`7ae2b8d`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957362939 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144839/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957362939 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144839/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957140343 **[Test build #144839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144839/testReport)** for PR 33522 at commit [`07eda27`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
SparkQA commented on pull request #33522: URL: https://github.com/apache/spark/pull/33522#issuecomment-957361620 **[Test build #144839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144839/testReport)** for PR 33522 at commit [`07eda27`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34468: [SPARK-37194][SQL] Avoid unnecessary sort in FileFormatWriter if it's not dynamic partition

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34468: URL: https://github.com/apache/spark/pull/34468#issuecomment-957354917 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49315/

<    2   3   4   5   6   7   8   9   >