[GitHub] [spark] c21 commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-03 Thread GitBox
c21 commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-958647134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [spark] c21 commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-03 Thread GitBox
c21 commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-958647134 Thank you @cloud-fan for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] c21 commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-02 Thread GitBox
c21 commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-958647134 Thank you @cloud-fan for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] c21 commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-02 Thread GitBox
c21 commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-956587980 > Just out of curiosity, how much performance gain this code generation brings? @Tagar - I ran the small micro benchmark (similar to Spark's `JoinBenchmark.scala`), it can gi

[GitHub] [spark] c21 commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-02 Thread GitBox
c21 commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-956587980 > Just out of curiosity, how much performance gain this code generation brings? @Tagar - I ran the small micro benchmark (similar to Spark's `JoinBenchmark.scala`), it can gi

[GitHub] [spark] c21 commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-01 Thread GitBox
c21 commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-956587980 > Just out of curiosity, how much performance gain this code generation brings? @Tagar - I ran the small micro benchmark (similar to Spark's `JoinBenchmark.scala`), it can gi

[GitHub] [spark] c21 commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-10-31 Thread GitBox
c21 commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-955825020 @cloud-fan could you help take a look when you have time? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [spark] c21 commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-10-29 Thread GitBox
c21 commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-955144426 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme