[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r775586299 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/DynamicJoinSelection.scala ## @@ -69,16 +77,16 @@ object DynamicJoinSelect

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r775074373 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/DynamicJoinSelection.scala ## @@ -69,16 +77,16 @@ object DynamicJoinSelect

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r750365314 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/DynamicJoinSelection.scala ## @@ -50,10 +51,17 @@ object DynamicJoinSelect

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r750365314 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/DynamicJoinSelection.scala ## @@ -50,10 +51,17 @@ object DynamicJoinSelect

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r750365314 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/DynamicJoinSelection.scala ## @@ -50,10 +51,17 @@ object DynamicJoinSelect

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r741555797 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/DynamicJoinSelection.scala ## @@ -50,10 +51,16 @@ object DynamicJoinSelect

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r741534074 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -651,6 +651,23 @@ class AdaptiveQueryEx

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r741555797 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/DynamicJoinSelection.scala ## @@ -50,10 +51,16 @@ object DynamicJoinSelect

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r741534074 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -651,6 +651,23 @@ class AdaptiveQueryEx

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r741534074 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -651,6 +651,23 @@ class AdaptiveQueryEx