Re: [PR] [SPARK-56338][INFRA][FOLLOWUP] Support MAVEN_MIRROR_URL in SBT launcher bootstrap [spark]
cloud-fan closed pull request #55238: [SPARK-56338][INFRA][FOLLOWUP] Support MAVEN_MIRROR_URL in SBT launcher bootstrap URL: https://github.com/apache/spark/pull/55238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SPARK-56338][INFRA][FOLLOWUP] Support MAVEN_MIRROR_URL in SBT launcher bootstrap [spark]
cloud-fan commented on PR #55238: URL: https://github.com/apache/spark/pull/55238#issuecomment-4210765687 the docker test failure is unrelated, thanks for review, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SPARK-56338][INFRA][FOLLOWUP] Support MAVEN_MIRROR_URL in SBT launcher bootstrap [spark]
cloud-fan commented on code in PR #55238:
URL: https://github.com/apache/spark/pull/55238#discussion_r3049250544
##
build/sbt-launch-lib.bash:
##
@@ -182,6 +183,18 @@ run() {
set -- "${residual_args[@]}"
argumentCount=$#
+ # If MAVEN_MIRROR_URL is set, generate a repositories config so the SBT
launcher
+ # resolves SBT and Scala through the mirror during the boot phase.
+ if [[ -n "$MAVEN_MIRROR_URL" ]]; then
+local sbt_repo_config="$(mktemp /tmp/sbt-repositories.XX)"
Review Comment:
The SBT bootstrap phase only downloads SBT itself and Scala — a single
mirror should be sufficient for that. This is just to make `MAVEN_MIRROR_URL`
work end-to-end consistently with the existing support in `pom.xml` and
`SparkBuild.scala`.
For more complex multi-repo setups, users can still configure
`~/.sbt/repositories` or `-Dsbt.repository.config` directly.
##
build/sbt-launch-lib.bash:
##
@@ -182,6 +183,18 @@ run() {
set -- "${residual_args[@]}"
argumentCount=$#
+ # If MAVEN_MIRROR_URL is set, generate a repositories config so the SBT
launcher
+ # resolves SBT and Scala through the mirror during the boot phase.
+ if [[ -n "$MAVEN_MIRROR_URL" ]]; then
+local sbt_repo_config="$(mktemp /tmp/sbt-repositories.XX)"
+cat > "$sbt_repo_config" <
Re: [PR] [SPARK-56338][INFRA][FOLLOWUP] Support MAVEN_MIRROR_URL in SBT launcher bootstrap [spark]
pan3793 commented on code in PR #55238:
URL: https://github.com/apache/spark/pull/55238#discussion_r3049028848
##
build/sbt-launch-lib.bash:
##
@@ -182,6 +183,18 @@ run() {
set -- "${residual_args[@]}"
argumentCount=$#
+ # If MAVEN_MIRROR_URL is set, generate a repositories config so the SBT
launcher
+ # resolves SBT and Scala through the mirror during the boot phase.
+ if [[ -n "$MAVEN_MIRROR_URL" ]]; then
+local sbt_repo_config="$(mktemp /tmp/sbt-repositories.XX)"
Review Comment:
it's a little bit hacky, users may want to configure more than one repo
sometimes
in Apache Celeborn, we allow users to have a
`build/sbt-config/repositories-local` (ignored by Git), and provide several
common templates
https://github.com/apache/celeborn/blob/main/build/sbt-config/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [SPARK-56338][INFRA][FOLLOWUP] Support MAVEN_MIRROR_URL in SBT launcher bootstrap [spark]
gaogaotiantian commented on code in PR #55238:
URL: https://github.com/apache/spark/pull/55238#discussion_r3046966899
##
build/sbt-launch-lib.bash:
##
@@ -182,6 +183,18 @@ run() {
set -- "${residual_args[@]}"
argumentCount=$#
+ # If MAVEN_MIRROR_URL is set, generate a repositories config so the SBT
launcher
+ # resolves SBT and Scala through the mirror during the boot phase.
+ if [[ -n "$MAVEN_MIRROR_URL" ]]; then
+local sbt_repo_config="$(mktemp /tmp/sbt-repositories.XX)"
+cat > "$sbt_repo_config" <
Re: [PR] [SPARK-56338][INFRA][FOLLOWUP] Support MAVEN_MIRROR_URL in SBT launcher bootstrap [spark]
cloud-fan commented on PR #55238: URL: https://github.com/apache/spark/pull/55238#issuecomment-4200528242 cc @gaogaotiantian @zhengruifeng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
