RE: Proposed extension of ScmProvider
I completely agree. The best way would be as Torbjorn wrote: "Being able to add a spesific command without expanding the ScmProvider would have been great." The core of scm-maven should remain compact and easy to maintain, but unfortunately right now, I think the only way is to add the commands I need. Anyway: I think "listFiles" is an important SCM feature, which should be really in the core library. Zsolt >-Original Message- >From: Torbjorn Smorgrav [mailto:[EMAIL PROTECTED] >Sent: Saturday, April 08, 2006 11:15 AM >To: [email protected] >Subject: Re: Proposed extension of ScmProvider > >If our aim is to support a superset of all SCM commands, then this >Task system should definitivly be supported. But we should perhapes >think about distinguis core SCM commands (commands that virtually all >SCM supports) and provider spesific commands. >Being able to add a spesific command without expanding the ScmProvider >would have been great. > >An other thing... should we try to follow subversion naming? If we are >going to add a list/inventory/listFiles command, I think we should use >list (as in subversion list). > >And again, when adding a new concept, it is very, very important to >include good javadoc. >What is a Task? What makes it different from a TODO listing? Whats a >typical return value from these fields. How should it be used? What >providers are likly to support it? > >Cheers >Torbjørn > >On 4/8/06, Trygve Laugstøl <[EMAIL PROTECTED]> wrote: >> On Fri, 2006-04-07 at 19:34 +0200, Zsolt Koppany wrote: >> > Hi, >> > >> > this mailing list doesn't allow attachments, thus I have just pasted >the >> > source code. >> > >> > It doesn't contain any implementation but the methods are really >necessary >> > for me. >> > >> > I extended ScmProvider but actually I think, the new methods should be >added >> > to it. >> > >> > Please make you proposals. >> >> I don't really understand what this code is supposed to do? It seems to >> be something like a parser for TODO stuff which really isn't something >> that belongs in a SCM library. >> >> If what you want to do is to read out all the TODOs etc you can do that >> with a checkout/export and run a Maven report. >> >> -- >> Trygve >> >>
RE: Proposed extension of ScmProvider
Trygve, I'm not sure whether you also red discussions last week. You are right: list-files can be solved with checkout. But lets take a huge project (for example 10.000) files. You want to see the list of the files in the top directory only. I estimate you don't want to checkout the entire repository because that might take a very-very long time. Zsolt >-Original Message- >From: Trygve Laugstøl [mailto:[EMAIL PROTECTED] >Sent: Saturday, April 08, 2006 10:41 AM >To: [email protected] >Subject: Re: Proposed extension of ScmProvider > >On Fri, 2006-04-07 at 19:34 +0200, Zsolt Koppany wrote: >> Hi, >> >> this mailing list doesn't allow attachments, thus I have just pasted the >> source code. >> >> It doesn't contain any implementation but the methods are really >necessary >> for me. >> >> I extended ScmProvider but actually I think, the new methods should be >added >> to it. >> >> Please make you proposals. > >I don't really understand what this code is supposed to do? It seems to >be something like a parser for TODO stuff which really isn't something >that belongs in a SCM library. > >If what you want to do is to read out all the TODOs etc you can do that >with a checkout/export and run a Maven report. > >-- >Trygve
Re: Proposed extension of ScmProvider
If our aim is to support a superset of all SCM commands, then this Task system should definitivly be supported. But we should perhapes think about distinguis core SCM commands (commands that virtually all SCM supports) and provider spesific commands. Being able to add a spesific command without expanding the ScmProvider would have been great. An other thing... should we try to follow subversion naming? If we are going to add a list/inventory/listFiles command, I think we should use list (as in subversion list). And again, when adding a new concept, it is very, very important to include good javadoc. What is a Task? What makes it different from a TODO listing? Whats a typical return value from these fields. How should it be used? What providers are likly to support it? Cheers Torbjørn On 4/8/06, Trygve Laugstøl <[EMAIL PROTECTED]> wrote: > On Fri, 2006-04-07 at 19:34 +0200, Zsolt Koppany wrote: > > Hi, > > > > this mailing list doesn't allow attachments, thus I have just pasted the > > source code. > > > > It doesn't contain any implementation but the methods are really necessary > > for me. > > > > I extended ScmProvider but actually I think, the new methods should be added > > to it. > > > > Please make you proposals. > > I don't really understand what this code is supposed to do? It seems to > be something like a parser for TODO stuff which really isn't something > that belongs in a SCM library. > > If what you want to do is to read out all the TODOs etc you can do that > with a checkout/export and run a Maven report. > > -- > Trygve > >
Re: Proposed extension of ScmProvider
On Fri, 2006-04-07 at 19:34 +0200, Zsolt Koppany wrote: > Hi, > > this mailing list doesn't allow attachments, thus I have just pasted the > source code. > > It doesn't contain any implementation but the methods are really necessary > for me. > > I extended ScmProvider but actually I think, the new methods should be added > to it. > > Please make you proposals. I don't really understand what this code is supposed to do? It seems to be something like a parser for TODO stuff which really isn't something that belongs in a SCM library. If what you want to do is to read out all the TODOs etc you can do that with a checkout/export and run a Maven report. -- Trygve
