From: David Miller <[EMAIL PROTECTED]>
Date: Tue, 15 May 2007 18:03:16 -0700 (PDT)
> From: Christoph Lameter <[EMAIL PROTECTED]>
> Date: Tue, 15 May 2007 18:00:23 -0700 (PDT)
>
> > Slab allocators: Define common size limitations
>
> Thanks for doing this work Christoph, I'll test this patch out
From: Christoph Lameter <[EMAIL PROTECTED]>
Date: Tue, 15 May 2007 18:00:23 -0700 (PDT)
> Slab allocators: Define common size limitations
Thanks for doing this work Christoph, I'll test this patch out on all
my sparc64 boxes, with both SLAB and SLUB, later this evening.
-
To unsubscribe from thi
Here is the patch. It probably does not apply cleanly against Andrew's
tree. I am waiting for the new tree in order to submit it.
Slab allocators: Define common size limitations
Currently we have a maze of configuration variables that determine
the maximum slab size. Worst of all it seems to va
On Tue, 15 May 2007, Andrew Morton wrote:
> > Try to define a compile-time array size with it smarty
> > pants :-)
>
> confusedy pants, more like.
>
> > That's what we did initially and it doesn't work.
>
> This:
>
> struct kmem_cache kmalloc_caches[KMALLOC_SHIFT_HIGH + 1] __cacheline_aligned;
On Tue, 15 May 2007, Andrew Morton wrote:
> Either that newly-added test isn't needed, or those ifdefs aren't needed?
The #ifdefs dont do the proper job thus the hack for Dave. The following
RFC will clean things up.
http://marc.info/?l=linux-kernel&m=117919444827939&w=2
-
To unsubscribe from
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Tue, 15 May 2007 17:29:57 -0700
> This:
>
> struct kmem_cache kmalloc_caches[KMALLOC_SHIFT_HIGH + 1] __cacheline_aligned;
>
> is still there.
My bad, we tried using min_t() and that's what caused the problems,
that's why we open-coded the macro like
On Tue, 15 May 2007 17:14:47 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Andrew Morton <[EMAIL PROTECTED]>
> Date: Tue, 15 May 2007 16:56:36 -0700
>
> > On Tue, 15 May 2007 16:45:22 -0700 (PDT)
> > Christoph Lameter <[EMAIL PROTECTED]> wrote:
> >
> > > KMALLOC_SHIFT_HIGH is not a
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Tue, 15 May 2007 16:56:36 -0700
> On Tue, 15 May 2007 16:45:22 -0700 (PDT)
> Christoph Lameter <[EMAIL PROTECTED]> wrote:
>
> > KMALLOC_SHIFT_HIGH is not a constant but may be less than 25.
>
> It darn well better be a compile-time constant.
Try to
On Tue, 15 May 2007 16:45:22 -0700 (PDT)
Christoph Lameter <[EMAIL PROTECTED]> wrote:
> On Tue, 15 May 2007, Andrew Morton wrote:
>
> > On Mon, 14 May 2007 16:46:17 -0700 (PDT)
> > Christoph Lameter <[EMAIL PROTECTED]> wrote:
> >
> > > @@ -86,6 +87,9 @@ static inline int kmalloc_index(int size
>
On Tue, 15 May 2007, Andrew Morton wrote:
> On Mon, 14 May 2007 16:46:17 -0700 (PDT)
> Christoph Lameter <[EMAIL PROTECTED]> wrote:
>
> > @@ -86,6 +87,9 @@ static inline int kmalloc_index(int size
> > */
> > WARN_ON_ONCE(size == 0);
> >
> > + if (size >= (1UL << KMALLOC_SHIFT_HIGH))
On Mon, 14 May 2007 16:46:17 -0700 (PDT)
Christoph Lameter <[EMAIL PROTECTED]> wrote:
> @@ -86,6 +87,9 @@ static inline int kmalloc_index(int size
>*/
> WARN_ON_ONCE(size == 0);
>
> + if (size >= (1UL << KMALLOC_SHIFT_HIGH))
> + return -1;
> +
I don't quite underst
On Mon, 14 May 2007 16:46:17 -0700 (PDT)
Christoph Lameter <[EMAIL PROTECTED]> wrote:
> -#define KMALLOC_SHIFT_HIGH 25
> +#define KMALLOC_SHIFT_HIGH ((MAX_ORDER + PAGE_SHIFT) =< 25 ? \
> + MAX_ORDER + PAGE_SHIFT - 1 : 25)
Would prefer to see a lot more parentheses in t
On Mon, 14 May 2007, David Miller wrote:
> From: Meelis Roos <[EMAIL PROTECTED]>
> Date: Mon, 14 May 2007 21:36:42 +0300 (EEST)
>
> > Sorry, I could not test the parport patch yet - I did git upgrade as of
> > yesterday and the kernel hangs on boot. boot -p reveals the following
> > slab panic:
From: Meelis Roos <[EMAIL PROTECTED]>
Date: Mon, 14 May 2007 21:36:42 +0300 (EEST)
> Sorry, I could not test the parport patch yet - I did git upgrade as of
> yesterday and the kernel hangs on boot. boot -p reveals the following
> slab panic:
Please enable SLUB to work around this for now, SLAB
Sorry, I could not test the parport patch yet - I did git upgrade as of
yesterday and the kernel hangs on boot. boot -p reveals the following
slab panic:
PROMLIB: Sun IEEE Boot Prom 'OBP 3.31.0 2001/07/25 20:36'
PROMLIB: Root node compatible:
Linux version 2.6.21-gf1d1a842 ([EMAIL PROTECTED]) (
15 matches
Mail list logo
