> statement is only doing pointer arithmetic
Apparently it is so. But it is not obvious. This code would be cleaner and
faster:
...
if( pPage ){
pcache1PinPage(pPage);
goto fetch_out;
}
if( createFlag==0 ){
return NULL;
...
Have a good day.
With best regards,
J
On 06/14/2013 10:55 PM, Jan Slodicka wrote:
(Applies to SQLITE 3.7.15.2 (but v3.7.17.0 uses the same code))
Pager bug(?):
Following code excerpt from sqlite3.c should crash if pPage==NULL &&
createFlag==0:
static sqlite3_pcache_page *pcache1Fetch(
sqlite3_pcache *p,
unsigned int iKey,
(Applies to SQLITE 3.7.15.2 (but v3.7.17.0 uses the same code))
Pager bug(?):
Following code excerpt from sqlite3.c should crash if pPage==NULL &&
createFlag==0:
static sqlite3_pcache_page *pcache1Fetch(
sqlite3_pcache *p,
unsigned int iKey,
int createFlag
){
{
...
if( pPage || createF
3 matches
Mail list logo
