Re: IdleConnList problems

2011-07-11 Thread Amos Jeffries
On 12/07/11 02:15, Tsantilas Christos wrote: On 07/08/2011 03:08 PM, Henrik Nordström wrote: tis 2011-07-05 klockan 19:04 +0300 skrev Tsantilas Christos: Yep. I disabled the read_pending flag tests and now I am getting the following assertion: assertion failed: comm.cc:170: "fd_table[conn->fd]

Re: IdleConnList problems

2011-07-11 Thread Tsantilas Christos
On 07/08/2011 03:08 PM, Henrik Nordström wrote: tis 2011-07-05 klockan 19:04 +0300 skrev Tsantilas Christos: Yep. I disabled the read_pending flag tests and now I am getting the following assertion: assertion failed: comm.cc:170: "fd_table[conn->fd].halfClosedReader != NULL" Odd.. half clo

Re: IdleConnList problems

2011-07-08 Thread Tsantilas Christos
On 07/08/2011 09:01 PM, Henrik Nordström wrote: fre 2011-07-08 klockan 17:30 +0300 skrev Tsantilas Christos: I think the fd_table[].halfClosedReader is used to check for half closed connections, does not mean that the connections is half closed (But I did not check it...) A connection can not

Re: IdleConnList problems

2011-07-08 Thread Henrik Nordström
fre 2011-07-08 klockan 17:30 +0300 skrev Tsantilas Christos: > I think the fd_table[].halfClosedReader is used to check for half closed > connections, does not mean that the connections is half closed (But I > did not check it...) A connection can not be idle if it's half-closed, and a idle con

Re: IdleConnList problems

2011-07-08 Thread Tsantilas Christos
On 07/08/2011 03:08 PM, Henrik Nordström wrote: tis 2011-07-05 klockan 19:04 +0300 skrev Tsantilas Christos: Yep. I disabled the read_pending flag tests and now I am getting the following assertion: assertion failed: comm.cc:170: "fd_table[conn->fd].halfClosedReader != NULL" Odd.. half clo

Re: IdleConnList problems

2011-07-08 Thread Henrik Nordström
tor 2011-07-07 klockan 14:12 +1200 skrev Amos Jeffries: > Up to you whether you want to commit an explicit reversal patch, or > combine the undo into the new fixes and note it in the commit message. > Doesn't bother me either way. A useful rule of thumb is that if it's code that is meant for

Re: IdleConnList problems

2011-07-08 Thread Henrik Nordström
tis 2011-07-05 klockan 19:04 +0300 skrev Tsantilas Christos: > Yep. > I disabled the read_pending flag tests and now I am getting the > following assertion: > assertion failed: comm.cc:170: "fd_table[conn->fd].halfClosedReader != > NULL" Odd.. half closed connections should not enter the idle

Re: IdleConnList problems

2011-07-06 Thread Amos Jeffries
On Wed, 06 Jul 2011 20:23:44 +0300, Tsantilas Christos wrote: OK, I have a fix for pconn.cc and idleConnList. Looks OK now. I am still getting assertion here or there but looks that there are unrelated to connections pool, I hope will be able to fix them. Yay! :) My commit to trunk with rev

Re: IdleConnList problems

2011-07-06 Thread Tsantilas Christos
OK, I have a fix for pconn.cc and idleConnList. Looks OK now. I am still getting assertion here or there but looks that there are unrelated to connections pool, I hope will be able to fix them. My commit to trunk with revno:11534 was wrong. What is the best way, should I undo (Is it possible?

Re: IdleConnList problems

2011-07-06 Thread Amos Jeffries
On 06/07/11 04:04, Tsantilas Christos wrote: On 07/05/2011 12:23 PM, Amos Jeffries wrote: OK, for now I will try to just remove these tests ... You mentioned other asserts. Still happening and what are they? Yep. I disabled the read_pending flag tests and now I am getting the following as

Re: IdleConnList problems

2011-07-05 Thread Tsantilas Christos
On 07/05/2011 12:23 PM, Amos Jeffries wrote: OK, for now I will try to just remove these tests ... You mentioned other asserts. Still happening and what are they? Yep. I disabled the read_pending flag tests and now I am getting the following assertion: assertion failed: comm.cc:170: "fd_

Re: IdleConnList problems

2011-07-05 Thread Amos Jeffries
On 05/07/11 19:56, Tsantilas Christos wrote: On 07/05/2011 09:18 AM, Amos Jeffries wrote: On 05/07/11 06:35, Tsantilas Christos wrote: Hi all, I am still having many problems with IdleConnList :-( Looks that the IdleConnList::pop() and the IdleConnList::findUseable() methods return always NULL

Re: IdleConnList problems

2011-07-05 Thread Tsantilas Christos
On 07/05/2011 09:18 AM, Amos Jeffries wrote: On 05/07/11 06:35, Tsantilas Christos wrote: Hi all, I am still having many problems with IdleConnList :-( Looks that the IdleConnList::pop() and the IdleConnList::findUseable() methods return always NULL. The reason is the fd_table[]::flags.read_pen

Re: IdleConnList problems

2011-07-04 Thread Amos Jeffries
On 05/07/11 06:35, Tsantilas Christos wrote: Hi all, I am still having many problems with IdleConnList :-( Looks that the IdleConnList::pop() and the IdleConnList::findUseable() methods return always NULL. The reason is the fd_table[]::flags.read_pending flag which is always 0. I can find only o

IdleConnList problems

2011-07-04 Thread Tsantilas Christos
Hi all, I am still having many problems with IdleConnList :-( Looks that the IdleConnList::pop() and the IdleConnList::findUseable() methods return always NULL. The reason is the fd_table[]::flags.read_pending flag which is always 0. I can find only one place in the code where this flag set to