Re: [sr-dev] [kamailio/kamailio] tm: check branch uri against current uri when deciding if append a ne… (#702)

2016-07-08 Thread Federico Cabiddu
You're right. Maybe adding also the check on the received address? I didn't want to have a too heavy logic there, but it could make sense. On Fri, Jul 8, 2016 at 10:15 AM, Daniel-Constantin Mierla < notificati...@github.com> wrote: > You can merge it. > > I think it covers the most of the cases,

Re: [sr-dev] [kamailio/kamailio] tm: check branch uri against current uri when deciding if append a ne… (#702)

2016-07-08 Thread Daniel-Constantin Mierla
You can merge it. I think it covers the most of the cases, but some corner ones may not be covered. Like one behind a nat router that is changing the public ip -- so the contact is the same, but the received address (computed from source ip) will be different. I guess this can happen only if th

[sr-dev] [kamailio/kamailio] tm: check branch uri against current uri when deciding if append a ne… (#702)

2016-07-08 Thread Federico Cabiddu
…w branch This patch allows t_append_branches to cope with sip.instance usage, at least for the case when the contact uri has changed with regards to a previous registration. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/702 -- Com