[Suspend-devel] [RFC/RFT][PATCH 5/7] s2disk: save_image() cleanup

2007-08-16 Thread Rafael J. Wysocki
Reduce the number of indentation levels in save_image(). --- suspend.c | 54 -- 1 file changed, 28 insertions(+), 26 deletions(-) Index: suspend/suspend.c === --- suspend.orig/su

[Suspend-devel] [RFC/RFT][PATCH 7/7] s2disk: Rename compress to do_compress

2007-08-16 Thread Rafael J. Wysocki
Rename the variable 'compress' to 'do_compress', in analogy with 'do_encrypt'. --- suspend.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Index: suspend/suspend.c === --- suspend.orig/suspend.c

[Suspend-devel] [RFC/RFT][PATCH 6/7] s2disk: init_swap_writer() cleanup

2007-08-16 Thread Rafael J. Wysocki
Rearrange the code in init_swap_writer(). --- suspend.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) Index: suspend/suspend.c === --- suspend.orig/suspend.c 2007-08-16 15:39:58.0 +02

[Suspend-devel] [RFC/RFT][PATCH 4/7] s2disk: write_image() cleanup

2007-08-16 Thread Rafael J. Wysocki
Rearrange the code in write_image(). --- suspend.c | 154 -- 1 file changed, 81 insertions(+), 73 deletions(-) Index: suspend/suspend.c === --- suspend.orig/suspend.c

[Suspend-devel] [RFC/RFT][PATCH 0/7] s2disk: Various code cleanups

2007-08-16 Thread Rafael J. Wysocki
Hi, I have seven patches indented to make the code in suspend.c a bit more readable (less levels of indentation, simpler loops etc.). I haven't tested them yet, so if anyone has the time and motivation, please do so. ;-) Comments welcome. Greetings, Rafael -- "Premature optimization is the r

[Suspend-devel] [RFC/RFT][PATCH 3/7] s2disk: suspend_system() cleanup

2007-08-16 Thread Rafael J. Wysocki
Reduce the number of indentation levels in suspend_system(). --- suspend.c | 70 ++ 1 file changed, 34 insertions(+), 36 deletions(-) Index: suspend/suspend.c === --- sus

[Suspend-devel] [RFC/RFT][PATCH 2/7] s2disk: generate_key() cleanup

2007-08-16 Thread Rafael J. Wysocki
Reduce the number of indentation levels in generate_key(). --- suspend.c | 75 +- 1 file changed, 40 insertions(+), 35 deletions(-) Index: suspend/suspend.c === --- suspe

[Suspend-devel] [RFC/RFT][PATCH 1/7] s2disk: main() cleanup

2007-08-16 Thread Rafael J. Wysocki
Don't allocate to much memory if do_encrypt is not set. --- suspend.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Index: suspend/suspend.c === --- suspend.orig/suspend.c 2007-08-16 14:14:44.00

[Suspend-devel] [PATCH] Replace LZF with LZO

2007-08-16 Thread Rafael J. Wysocki
Hi, The appended patch makes s2disk and resume use LZO instead of LZF for compression. The new code seems to be a bit faster than the old one, but this may be my impression only. If anyone can please test it on i386, I'd be grateful. Greetings, Rafael --- Makefile |2 +- resume.c | 25

Re: [Suspend-devel] [RFC] Modify switching into lzo compression

2007-08-16 Thread Rafael J. Wysocki
On Thursday, 16 August 2007 05:53, Alon Bar-Lev wrote: > On 8/15/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > You can malloc as much as you wish at initialization directly into > > > the pointers... I just don't understand what may go wrong if you d

Re: [Suspend-devel] [PATCH] Cleanup terminal if abort was selected

2007-08-16 Thread Rafael J. Wysocki
On Thursday, 16 August 2007 05:38, Alon Bar-Lev wrote: > On 8/15/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > On Saturday, 11 August 2007 21:08, Alon Bar-Lev wrote: > > > > > > Hello, > > > > > > Current implementation does not cleanup c

Re: [Suspend-devel] [RFC] Modify switching into lzo compression

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 14:35, Alon Bar-Lev wrote: > On Saturday 04 August 2007, Alon Bar-Lev wrote: > > > > Hello Rafael, > > > > This is *UNTESTED* suggestion for switching into lzo without the memcpy. > > Please see if I missed something as I the code combination of global > > variables, >

Re: [Suspend-devel] [PATCH] Enable splash setting via command-line

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 23:17, Alon Bar-Lev wrote: > > Hello, > > This patch adds --splash argument to s2both, s2disk, resume. > It is required especially for resume when you want to disable splash in > initramfs > as result of kernel parameter, even if it usually turned on on suspend.conf >

Re: [Suspend-devel] [PATCH] Speedup image writing

2007-08-15 Thread Rafael J. Wysocki
On Wednesday, 15 August 2007 18:43, Luca wrote: > On 8/15/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > On Wednesday, 15 August 2007 17:20, Couriousous wrote: > > > Hello > > > > > > Le mercredi 15 août 2007, Rafael J. Wysocki a écrit: > > >

Re: [Suspend-devel] [PATCH] Do not manually calculate config elements

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 14:51, Alon Bar-Lev wrote: > > This allows you to specify an array of config_par, ending it with NULL > name, so that you don't have to calculate the number of entries manually. I have applied the patch. Greetings, Rafael --

Re: [Suspend-devel] [rft] Kill junk from s2ram resume paths

2007-08-15 Thread Rafael J. Wysocki
On Tuesday, 31 July 2007 16:01, Pavel Machek wrote: > Hi! > > > > > > # Running in *copy* of this code, somewhere in low 1MB. > > > > > > > > > > - movb$0xa1, %al ; outb %al, $0x80 > > > > > > > > Well, what was this for? > > > > > > Debugging leds on port 80. I still have that

Re: [Suspend-devel] [PATCH 6/6] - autoconf/automake glue - s2ram

2007-08-15 Thread Rafael J. Wysocki
On Sunday, 5 August 2007 19:48, Pavel Machek wrote: > Hi! > > > > 1. Move main() out of s2ram.c into s2ram-main.c, this will enable s2ram.o > > > to be included > > > in both s2ram and s2both without recompilation. > > > > > > 2. Split whitelist.c into whitelist.h/whitelist.c as including .c is

Re: [Suspend-devel] [PATCH 5/6] - autoconf/automake glue - config.* rename

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 00:13, Rafael J. Wysocki wrote: > On Friday, 3 August 2007 18:36, Alon Bar-Lev wrote: > > On Friday 03 August 2007, Rafael J. Wysocki wrote: > > > On Friday, 3 August 2007 01:16, Alon Bar-Lev wrote: > > > > > > > > config.* con

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 00:14, Rafael J. Wysocki wrote: > On Friday, 3 August 2007 23:14, Alon Bar-Lev wrote: > > On Friday 03 August 2007, Rafael J. Wysocki wrote: > > > On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: > > > > > > > > enc

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-15 Thread Rafael J. Wysocki
On Monday, 6 August 2007 13:42, Alon Bar-Lev wrote: > On Monday 06 August 2007, Alon Bar-Lev wrote: > > On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > Second, what I didn't like is not the whole idea, but the context in > > > which you >

Re: [Suspend-devel] [PATCH 2/6] - autoconf/automake glue - scripts

2007-08-15 Thread Rafael J. Wysocki
On Monday, 6 August 2007 11:23, Alon Bar-Lev wrote: > On Monday 06 August 2007, Pavel Machek wrote: > > > @@ -1,4 +1,4 @@ > > > -#!/bin/bash > > > +#!/bin/sh -x > > > > > > > What is "sh -x"? > > > > Good catch! > I had some issues with this script... -x allows debugging... > Here is an update

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-15 Thread Rafael J. Wysocki
On Monday, 6 August 2007 13:35, Rafael J. Wysocki wrote: > On Monday, 6 August 2007 13:00, Alon Bar-Lev wrote: > > On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > Yes, in this context you're right, but this was not clear from the > > > original

Re: [Suspend-devel] [PATCH] Speedup image writing

2007-08-15 Thread Rafael J. Wysocki
On Wednesday, 15 August 2007 17:20, Couriousous wrote: > Hello > > Le mercredi 15 août 2007, Rafael J. Wysocki a écrit : > > Hi, > > > > On Saturday, 11 August 2007 00:32, Couriousous wrote: > > > Hello > > > > > > Here is an easy way to speed

Re: [Suspend-devel] vt switch during image write

2007-08-15 Thread Rafael J. Wysocki
On Wednesday, 8 August 2007 21:30, Tim Dijkstra wrote: > On Tue, 7 Aug 2007 01:50:12 +0300 > "Alon Bar-Lev" <[EMAIL PROTECTED]> wrote: > > > > The question is: Why cannot I switch from one vt to another during image > > write? > > I guess some lock out somewhere at freeze something... > > I will

Re: [Suspend-devel] [PATCH] Speedup image writing

2007-08-15 Thread Rafael J. Wysocki
Hi, On Saturday, 11 August 2007 00:32, Couriousous wrote: > Hello > > Here is an easy way to speed up the image writing. It simply tell the kernel > to > immediatly start writing the data to disk asynchronously and not to do the > traditional > buffering. > > Mesurement: > System: pentium D8

Re: [Suspend-devel] [PATCH] Cleanup terminal if abort was selected

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 11 August 2007 21:08, Alon Bar-Lev wrote: > > Hello, > > Current implementation does not cleanup console settings if abort was > selected by user. > This should fix it. I prefer the appended patch. Greetings, Rafael --- suspend.c |1 + 1 file changed, 1 insertion(+) Index:

Re: [Suspend-devel] s2ram on: Sony Vaio sz340p

2007-08-14 Thread Rafael J. Wysocki
On Tuesday, 14 August 2007 17:43, Ilian wrote: > This machine can be identified by: > sys_vendor = "Sony Corporation" > sys_product = "VGN-SZ340P" > sys_version = "R5283566" > bios_version = "R0096N0" > > This machiene is not in the whitelist. Suspend to RAM works - kind of. >

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-09 Thread Rafael J. Wysocki
On Thursday, 9 August 2007 00:28, Felix Homann wrote: > Hi again, > > now we're getting closer: > > With "echo test > /sys/power/disk" it's just the same, but with "echo > shutdown > ..." the kernel will panic. The very last lines read like this: > > EIP: [ lapic_nmi_suspend+0x1d/0x30 ss:ESP 006

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-08 Thread Rafael J. Wysocki
On Wednesday, 8 August 2007 22:40, Felix Homann wrote: > Rafael J. Wysocki wrote: > > > >> Does this tell you something? > > > > Well, only that CONFIG_DISABLE_CONSOLE_SUSPEND is probably unset ... > > > As stated before, I could not set it in 'make x

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-08 Thread Rafael J. Wysocki
On Wednesday, 8 August 2007 22:27, Felix Homann wrote: > Rafael J. Wysocki wrote: > > On Wednesday, 8 August 2007 21:17, Felix wrote: > >> > >> I don't think this is of any help, though... > > > > Yes, it is. > > > > At least we know

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-08 Thread Rafael J. Wysocki
On Wednesday, 8 August 2007 21:17, Felix wrote: > Rafael J. Wysocki wrote: > > > > Can you please do the following: > > > > * compile the kernel with CONFIG_DISABLE_CONSOLE_SUSPEND=y > > and the appended patch applied > > * boot the kernel with init=/

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-07 Thread Rafael J. Wysocki
On Tuesday, 7 August 2007 22:42, Felix wrote: > Rafael J. Wysocki wrote: > > On Tuesday, 7 August 2007 22:24, Felix wrote: > > > > > > Hmm, boxes with similar hardware configurations usually suspend with no > > problems. > > > > May I see your .confi

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-07 Thread Rafael J. Wysocki
On Tuesday, 7 August 2007 22:24, Felix wrote: > Rafael J. Wysocki wrote: > > Can you please post the output of 'lspci -v'? > > It's in the attachement. Hmm, boxes with similar hardware configurations usually suspend with no problems. May I see yo

Re: [Suspend-devel] s2disk/s2ram not working with rece nt kernels on Acer Extensa 4100 WLMI

2007-08-07 Thread Rafael J. Wysocki
On Tuesday, 7 August 2007 21:59, Felix Homann wrote: > On Monday 06 August 2007, Rafael J. Wysocki wrote: > > On Monday, 6 August 2007 20:22, Felix Homann Hi wrote: > > > > Please try 2.6.23-rc2, when it's out, in the minimal configuration (ie. > &

Re: [Suspend-devel] suspend to ram does not work with toshiba U305laptop

2007-08-07 Thread Rafael J. Wysocki
On Tuesday, 7 August 2007 16:03, Romano Giannetti wrote: > On Fri, 2007-08-03 at 21:40 +0200, Romano Giannetti wrote: > > [basically, s2ram no working for me and ususpend ubuntu package busted] > > Well, I found a little error on ususpend 0.5 which stopped me to compile > s2ram: in Makefile, you

Re: [Suspend-devel] Linux 2.6.23-rc2

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 18:40, H. Peter Anvin wrote: > Rafael J. Wysocki wrote: > > On Monday, 6 August 2007 02:36, Jeff Chua wrote: > >> On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > >> > >>> What does 's2ram -i' say abo

Re: [Suspend-devel] s2disk/s2ram not working with rece nt kernels on Acer Extensa 4100 WLMI

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 20:22, Felix Homann Hi wrote: > Hi again, > > On Friday, 27 Jul 2007 01:33:02 -0700, Rafael J. Wysocki wrote > > > On Friday, 27 July 2007 10:15, Felix Homann wrote: > >> Hi, > >> > >> with recent kernels I'm having s

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 13:10, Alon Bar-Lev wrote: > On 8/6/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > > If you got radeontool from us, it is GPLed. You can get zlib-licensed > > version from Frederick. > > So please update the header of the file into dual license. > > Now (if you wish) we ca

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 13:00, Alon Bar-Lev wrote: > On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > Yes, in this context you're right, but this was not clear from the original > > post. > > > > Moreover, the printf() is buggy, not th

Re: [Suspend-devel] Linux 2.6.23-rc2

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 02:36, Jeff Chua wrote: > On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > What does 's2ram -i' say about your machine? > > This machine can be identified by: > sys_vendor = "LENOVO" > sys_produc

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 10:18, Alon Bar-Lev wrote: > On 8/6/07, Frank Seidel <[EMAIL PROTECTED]> wrote: > > On Monday 06 August 2007 00:46:01 Alon Bar-Lev wrote: > > > On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > > On Monda

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-05 Thread Rafael J. Wysocki
On Monday, 6 August 2007 00:05, Alon Bar-Lev wrote: > > Well... It never worked :) Why exactly do you think so? > This what happens on shortcuts... > Why calling this inside printf context instead of making this own statement? > > --- > > --- suspend.org/resume.c 2007-05-13 20:53:13.0

Re: [Suspend-devel] Linux 2.6.23-rc2

2007-08-05 Thread Rafael J. Wysocki
On Sunday, 5 August 2007 15:26, Jeff Chua wrote: > On 8/5/07, Antonino A. Daplas <[EMAIL PROTECTED]> wrote: > > > Can you try with the boot option acpi_sleep=s3_bios,s3_mode > > OR > > if using s2ram, use s2ram -f a3 > > Tried both, text-console still not restored. > > In fact, with "s2ram -f a3

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-04 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 09:34, Alon Bar-Lev wrote: > On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > We can always complete this in future. > > > Also if you apply the suggested fix, you can add more info later, > > > there is nothin

Re: [Suspend-devel] [PATCH 5/6] - autoconf/automake glue - config.* rename

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 18:36, Alon Bar-Lev wrote: > On Friday 03 August 2007, Rafael J. Wysocki wrote: > > On Friday, 3 August 2007 01:16, Alon Bar-Lev wrote: > > > > > > config.* conflicts with autoconf files. > > > Rename the to configparser.*. > &g

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 00:46, Alon Bar-Lev wrote: > On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > Hmm... You can help you know... > > > > Perhaps I'm doing something else, which I consider as more important, in > > parallel? > > W

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 00:03, Alon Bar-Lev wrote: > On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > OK. > > > Do you wish to sync up compress->do_compress as well? > > > > No. I'd like to have a patch without this "compr

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 23:59, Alon Bar-Lev wrote: > On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > I am for removing it and fix it right when someone have an issue with it. > > > > What exactly is wrong with it? > > Turning on GNU extensions

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 23:58, Alon Bar-Lev wrote: > On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > Usually, only the package full license is shown here. > > > For dependencies only short copyright signature is displayed. > > > Do you wish to put

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 23:14, Alon Bar-Lev wrote: > On Friday 03 August 2007, Rafael J. Wysocki wrote: > > On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: > > > > > > encrypt variable conflict with glibc::encrypt() > > > Rename it to encrypt_on >

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 18:23, Alon Bar-Lev wrote: > On 8/3/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: > > > > > > encrypt variable conflict with glibc::encrypt() > > > Rename it to encrypt

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 18:22, Alon Bar-Lev wrote: > On 8/3/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > Please dig in the list archives. I don't remember at the moment, but it's > > needed for something important. > > > > Alternati

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 18:27, Alon Bar-Lev wrote: > On 8/3/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > +vbetool License > > > + > > > + Copyright Matthew Garrett <[EMAIL PROTECTED]>, heavily based on > > > + vbetest.c fr

Re: [Suspend-devel] [PATCH 6/6] - autoconf/automake glue - s2ram

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:18, Alon Bar-Lev wrote: > > 1. Move main() out of s2ram.c into s2ram-main.c, this will enable s2ram.o to > be included > in both s2ram and s2both without recompilation. > > 2. Split whitelist.c into whitelist.h/whitelist.c as including .c is none > standard/unsupport

Re: [Suspend-devel] [PATCH 5/6] - autoconf/automake glue - config.* rename

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:16, Alon Bar-Lev wrote: > > config.* conflicts with autoconf files. > Rename the to configparser.*. > > After applying this patch, you should rename: > config.h->configparser.h > config.c->configparser.c OK > I did not want to include the removal/addition in patch.

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: > > encrypt variable conflict with glibc::encrypt() > Rename it to encrypt_on I'd prefer do_encrypt. > --- > > diff -urNp suspend.org/suspend.c suspend-0.6_beta1/suspend.c > --- suspend.org/suspend.c 2007-07-29 21:30:27.0 +0300 > +

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 10:14, Alon Bar-Lev wrote: > On 8/3/07, Frank Seidel <[EMAIL PROTECTED]> wrote: > > Hi, > > > > On Friday 03 August 2007 01:13:56 Alon Bar-Lev wrote: > > > Can anyone please explain this usage? > > > These flags should seldom be used. > > Why do you think so? _GNU_SOURCE ac

Re: [Suspend-devel] [PATCH 2/6] - autoconf/automake glue - scripts

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:12, Alon Bar-Lev wrote: > > Use sh and not bash. > Support BOOT_DIR for install-resume.sh Looks OK, I'm going to apply it. > --- > > diff -urNp suspend.org/scripts/create-resume-initrd.sh > suspend-0.6_beta1/scripts/create-resume-initrd.sh > --- suspend.org/scripts/

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Rafael J. Wysocki
3 00:36:13.0 +0300 > @@ -0,0 +1,68 @@ > + > +suspend License > + > + Copyright (C) 2005-2007 Rafael J. Wysocki <[EMAIL PROTECTED]> > + Copyright (C) 2006-2007 Pavel Machek <[EMAIL PROTECTED]> > + Copyright (C) 2006-2007 Stefan Seyfrie

Re: [Suspend-devel] Autoconf/automake support

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:24, Alon Bar-Lev wrote: > On 8/3/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > Please look at the code in prepare(), for example. In there, > > lzf_compress() is > > used to take page_size bytes of data from buf, compress them and pla

Re: [Suspend-devel] s2ram triggered by xbindkeys continually suspends

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 10:55, Warren Crossing wrote: > I mapped the sleep key to s2ram with xbindkeys. > It suspends, then the power button flashes, then it comes out of sleep, > clicks the hdisk and sometimes blinks the last picture on the screen, > and then "goes back to sleep" it does this u

Re: [Suspend-devel] Autoconf/automake support

2007-08-02 Thread Rafael J. Wysocki
On Friday, 3 August 2007 00:54, Alon Bar-Lev wrote: > On 8/3/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > First, please just replace LZF with LZO. If LZF is unsupported, there's no > > reason to drag it all the way. > > OK. > > > Second, you hav

Re: [Suspend-devel] Autoconf/automake support

2007-08-02 Thread Rafael J. Wysocki
On Friday, 3 August 2007 00:31, Alon Bar-Lev wrote: > On Tuesday 31 July 2007, Rafael J. Wysocki wrote: > > > IIRC noone was strongly against, so replacing lzf with lzo is the way > > > to go...? > > > > Ultimately, I think it is. > > Rafael, > Can you p

Re: [Suspend-devel] Autoconf/automake support

2007-07-31 Thread Rafael J. Wysocki
On Tuesday, 31 July 2007 20:30, Pavel Machek wrote: > Hi! > > > > Right... so do you have sourceforge login? I guess we could use you as > > > a webmaster for suspend.sf.net project ;-). > > > > My sf login is alonbl. > > But I am far from being a web master... Or have the time to do this. > > Bu

Re: [Suspend-devel] [rft] Kill junk from s2ram resume paths

2007-07-31 Thread Rafael J. Wysocki
On Tuesday, 31 July 2007 16:43, Stefan Seyfried wrote: > On Tue, Jul 31, 2007 at 04:01:40PM +0200, Pavel Machek wrote: > > Hi! > > > > > > > > # Running in *copy* of this code, somewhere in low 1MB. > > > > > > > > > > > > - movb$0xa1, %al ; outb %al, $0x80 > > > > > > > > > > Well

Re: [Suspend-devel] [rft] Kill junk from s2ram resume paths

2007-07-31 Thread Rafael J. Wysocki
Hi, On Tuesday, 31 July 2007 15:18, Pavel Machek wrote: > Hi! > > > > This removes some stale debugging infrastructure from s2ram > > > paths. Also, there's no need to verify_cpu on x86-64 -- cpu can't > > > change during s2ram, and removed #if 0-ed code. Some testing would be > > > useful, perpa

Re: [Suspend-devel] [rft] Kill junk from s2ram resume paths

2007-07-31 Thread Rafael J. Wysocki
Hi, On Tuesday, 31 July 2007 14:12, Pavel Machek wrote: > Hi! > > This removes some stale debugging infrastructure from s2ram > paths. Also, there's no need to verify_cpu on x86-64 -- cpu can't > change during s2ram, and removed #if 0-ed code. Some testing would be > useful, perpahs it will even

Re: [Suspend-devel] suspend framebuffers during s2ram

2007-07-30 Thread Rafael J. Wysocki
On Monday, 30 July 2007 08:56, Stefan Seyfried wrote: > On Fri, Jul 27, 2007 at 08:45:41PM +0200, Rafael J. Wysocki wrote: > > On Friday, 27 July 2007 18:33, Stefan Seyfried wrote: > > > On Fri, Jul 27, 2007 at 05:18:45PM +0200, Rafael J. Wysocki wrote: > > > > >

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Rafael J. Wysocki
On Sunday, 29 July 2007 21:41, Alon Bar-Lev wrote: > On 7/29/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > On Sunday, 29 July 2007 21:17, Alon Bar-Lev wrote: > > > On 7/29/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > &g

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Rafael J. Wysocki
On Sunday, 29 July 2007 21:17, Alon Bar-Lev wrote: > On 7/29/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > Which version of pciutils do you have? > > > > pciutils-2.2.4-13 > > OK. > pkg-config stuff was introduced in pciutils-2.2.6 > > I w

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Rafael J. Wysocki
On Sunday, 29 July 2007 20:01, Alon Bar-Lev wrote: > On 7/29/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > It doesn't work on my system (openSUSE 10.2). > > What do you get? s2ram-x86.o: In function `s2ram_resume': s2ram-x86.c:(.text+0x31e): undefined refer

Re: [Suspend-devel] resume executable location

2007-07-29 Thread Rafael J. Wysocki
On Sunday, 29 July 2007 02:44, Stefan Seyfried wrote: > On Fri, Jul 27, 2007 at 09:23:07PM +0200, Rafael J. Wysocki wrote: > > On Thursday, 19 July 2007 05:20, Alon Bar-Lev wrote: > > > > > > Please consider the following patch. > > > So you can add new files

Re: [Suspend-devel] [PATCH] Enable interactive reboot selection

2007-07-29 Thread Rafael J. Wysocki
On Saturday, 28 July 2007 20:14, Rafael J. Wysocki wrote: > On Saturday, 28 July 2007 11:51, Alon Bar-Lev wrote: > > On Friday 27 July 2007, Alon Bar-Lev wrote: > > > On Friday 27 July 2007, Rafael J. Wysocki wrote: > > > > Apart from this you should also clear th

Re: [Suspend-devel] [PATCH] Don't consume 100% CPU

2007-07-29 Thread Rafael J. Wysocki
On Saturday, 28 July 2007 20:02, Rafael J. Wysocki wrote: > Hi, > > On Saturday, 28 July 2007 11:52, Alon Bar-Lev wrote: > > > > Hello, > > > > Just a minor issue, I know you should never reach there... > > But never consume 100% CPU. >

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Rafael J. Wysocki
On Thursday, 19 July 2007 05:13, Alon Bar-Lev wrote: > On Wednesday 18 July 2007, Rafael J. Wysocki wrote: > > AFAICS, recent versions of pciutils depend on it. > > Oh... > You don't have to compile it with zlib... > > """The configure script will a

Re: [Suspend-devel] Autoconf/automake support

2007-07-28 Thread Rafael J. Wysocki
On Saturday, 28 July 2007 20:06, Alon Bar-Lev wrote: > On 7/28/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > Well, I think that the majority of core developers of the suspend package do > > not know autoconf/automake very well, including me. That may be a problem >

Re: [Suspend-devel] [PATCH] Enable interactive reboot selection

2007-07-28 Thread Rafael J. Wysocki
On Saturday, 28 July 2007 11:51, Alon Bar-Lev wrote: > On Friday 27 July 2007, Alon Bar-Lev wrote: > > On Friday 27 July 2007, Rafael J. Wysocki wrote: > > > Apart from this you should also clear the PLATFORM_SUSPEND flag in the > > > image > > > header. O

Re: [Suspend-devel] Autoconf/automake support

2007-07-28 Thread Rafael J. Wysocki
On Friday, 27 July 2007 22:28, Alon Bar-Lev wrote: > On Friday 27 July 2007, Rafael J. Wysocki wrote: > > Well, in fact we're missing someone to take care of the project's web page, > > too. > > Hmmm... I cannot help you with web stuff... :( > But I can help you

Re: [Suspend-devel] [PATCH] Don't consume 100% CPU

2007-07-28 Thread Rafael J. Wysocki
Hi, On Saturday, 28 July 2007 11:52, Alon Bar-Lev wrote: > > Hello, > > Just a minor issue, I know you should never reach there... > But never consume 100% CPU. Thanks, I'm going to apply it. Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth

Re: [Suspend-devel] suspend - libz dependency

2007-07-27 Thread Rafael J. Wysocki
On Monday, 23 July 2007 11:16, Pavel Machek wrote: > Hi! > > > > AFAICS, recent versions of pciutils depend on it. > > > > Oh... > > You don't have to compile it with zlib... > > > > """The configure script will automatically enable support for a compressed > > pci.ids if you have zlib installed

Re: [Suspend-devel] resume executable location

2007-07-27 Thread Rafael J. Wysocki
On Thursday, 19 July 2007 05:20, Alon Bar-Lev wrote: > On Wednesday 18 July 2007, Rafael J. Wysocki wrote: > > On Wednesday, 18 July 2007 20:01, Alon Bar-Lev wrote: > > > Hello, > > > > > > I wounder why resume default location is at /usr/local/lib/susp

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-27 Thread Rafael J. Wysocki
Hi, On Friday, 20 July 2007 19:56, Alon Bar-Lev wrote: > > Hello Rafael, > > Yet another patch in the suspend2 feature-set series. > It sets cpufreq to maximum during the cycle. > It is important to finish the process as quickly as possible (human engineer > issue :) ) > When running on batteri

Re: [Suspend-devel] [PATCH] Enable interactive reboot selection

2007-07-27 Thread Rafael J. Wysocki
Hi, On Friday, 20 July 2007 17:54, Alon Bar-Lev wrote: > > Hello, > > This patch enables the user to press "r" during snapshot writing, > in order to reboot and not shutdown. > > One more step toward suspend2 functionality... :) > > Best Regards, > Alon Bar-Lev. > > diff -urNp suspend.org/spl

Re: [Suspend-devel] Autoconf/automake support

2007-07-27 Thread Rafael J. Wysocki
On Friday, 27 July 2007 19:34, Pavel Machek wrote: > Hi! > > > > But i am not the one to decide this, as i am only maintaining a small > > > piece > > > of the code (mainly the whitelist). > > > > Why do you forward people to suse URLs on whitelist? > > Because it was easier that way :-). > >

Re: [Suspend-devel] suspend framebuffers during s2ram

2007-07-27 Thread Rafael J. Wysocki
On Friday, 27 July 2007 18:33, Stefan Seyfried wrote: > On Fri, Jul 27, 2007 at 05:18:45PM +0200, Rafael J. Wysocki wrote: > > > > (yes, i think i know what it does; writing 1 into the state of the > > > framebuffer device just disables any drawing - and thus any acce

Re: [Suspend-devel] suspend framebuffers during s2ram

2007-07-27 Thread Rafael J. Wysocki
Hi, On Friday, 27 July 2007 15:27, Stefan Seyfried wrote: > Hi, > > while working on https://bugzilla.novell.com/show_bug.cgi?id=293662 and > https://bugzilla.novell.com/show_bug.cgi?id=281798 it occured to me that > including Ubuntu's hack in s2ram might be a good idea. > It should do no harm -

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-07-27 Thread Rafael J. Wysocki
On Friday, 27 July 2007 10:15, Felix Homann wrote: > Hi, > > with recent kernels I'm having several problems suspending with > s2disk/s2ram. The last kernel it has been working flawlessly was 2.6.18.1: > > First, here's what the working kernel says: > > 2.6.18.1: > > s2disk: >

Re: [Suspend-devel] Autoconf/automake support

2007-07-25 Thread Rafael J. Wysocki
Hi, On Tuesday, 24 July 2007 19:51, Alon Bar-Lev wrote: > Hello, > > I was afraid to ask this question... > > But given the options, dependencies and system configuration, it would > be simpler (to users) an autoconf/automake build environment. > > If you don't have any religion thing against t

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Rafael J. Wysocki
On Monday, 23 July 2007 22:34, Alon Bar-Lev wrote: > On 7/23/07, Arkadiusz Miskiewicz <[EMAIL PROTECTED]> wrote: > > ... and there are two versions of lzo 8-) Which to support? We (at PLD) > > "like" > > 2.x for example. > > My patch is for lzo1x_1 it is available in llzo-1 and lzo-2. > I checked

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Rafael J. Wysocki
On Monday, 23 July 2007 22:04, Pavel Machek wrote: > On Mon 2007-07-23 20:12:21, Alon Bar-Lev wrote: > > On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > > >I guess it is easiest way for gentoo, but... I'd prefer not to switch > > >compression algorithms too often, unless there's good reason t

Re: [Suspend-devel] IBM ACPI suspend led is turned off during suspend

2007-07-23 Thread Rafael J. Wysocki
On Monday, 23 July 2007 19:10, Alon Bar-Lev wrote: > On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > > We do ACPI calls ("platform mode"), and they manipulate LED status for > > us. We probably tell plaform to unsuspend at the end of snapshot. That's correct. > Will you fix this? Well, I'd

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-20 Thread Rafael J. Wysocki
Hi, On Friday, 20 July 2007 19:56, Alon Bar-Lev wrote: > > Hello Rafael, Thanks for all of the patches so far. :-) > Yet another patch in the suspend2 feature-set series. > It sets cpufreq to maximum during the cycle. > It is important to finish the process as quickly as possible (human engine

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-18 Thread Rafael J. Wysocki
Hi, On Wednesday, 18 July 2007 19:25, Alon Bar-Lev wrote: > Hello, Rafael > > I am the maintainer of gentoo hibernate-script, tuxonice (suspend2). > I wish to add uswsup/suspend into portage. > > We do not currently maintain liblzf, as it seems upstream is not cooperative. > I've created a patch

Re: [Suspend-devel] suspend - libz dependency

2007-07-18 Thread Rafael J. Wysocki
On Wednesday, 18 July 2007 19:28, Alon Bar-Lev wrote: > Hello, > > I wounder why the libz dependency is required, I did not > see any reference to this library in the source. > > Do I miss something? > > It compiles find if I remove it: > -S2RAM_LD_FLAGS += -lx86 -lpci -lz > +S2RAM_LD_FLAGS += -

Re: [Suspend-devel] resume executable location

2007-07-18 Thread Rafael J. Wysocki
On Wednesday, 18 July 2007 20:01, Alon Bar-Lev wrote: > Hello, > > I wounder why resume default location is at /usr/local/lib/suspend > and not at /usr/local/sbin... > > The resume is a program which is executed directly, right? No, it's rather designed to be executed from an initrd/initramfs im

Re: [Suspend-devel] Slightly change S3_BIOS|S3_MODE handling wrt. beeping patch

2007-07-17 Thread Rafael J. Wysocki
On Tuesday, 17 July 2007 22:39, Stefan Seyfried wrote: > Hi, > I am proposing two changes to s2ram-x86.c: > - first, if no "-a" is given, reset acpi_video_flags to 0, which will > override also the boot options. The reason i want to do this is that > people (me included) are sometimes confused

Re: [Suspend-devel] s2ram vs. bcm43xx

2007-07-13 Thread Rafael J. Wysocki
Hi, On Friday, 13 July 2007 18:13, Benedikt Nimmervoll wrote: > Hi! > I am using the uswsusp 0.3 on my Kubuntu Feisty driven nx6325 laptop (fglrx > driver) with the command "s2ram -f -p -s". I have changed from ndiswrapper to > the most recent bcm43xx driver recently and have to un/reload the bc

Re: [Suspend-devel] [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-04 Thread Rafael J. Wysocki
On Wednesday, 4 July 2007 21:33, Pavel Machek wrote: > Hi! > > > > What about this? (Only compile tested, but looks pretty obvious to > > > me). Something like this should get us rid of ugly option, and still > > > solve debugging problems... Hmmm? > > >

Re: [Suspend-devel] Suspend doesn't work on my thinkpad X60

2007-06-30 Thread Rafael J. Wysocki
Hi, On Saturday, 30 June 2007 09:45, David wrote: > Hi, > > The suspend still doesn't work on my thinkpad X60. I'm currently using > Ubuntu 7.04 fiesty. Can you please advice? Where exactly does it fail? Rafael -- "Premature optimization is the root of all evil." - Donald Knuth ---

Re: [Suspend-devel] [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Rafael J. Wysocki
On Thursday, 28 June 2007 19:25, Stefan Seyfried wrote: > (CC'ing Linus, since disabling consoles during suspend was his idea IIRC) > > On Thu, Jun 28, 2007 at 05:34:54PM +0200, Rafael J. Wysocki wrote: > > Hi, > > > > On Thursday, 28 June 2007 15:

  1   2   3   4   5   6   >