Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Alexey Starikovskiy
On 5/9/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Wednesday, 9 May 2007 19:30, Alexey Starikovskiy wrote: > > Yes, something like that should do... > > I'd prefer not to call ACPI functions from outside of drivers/acpi, > > but this could be cleaned later. > > Actually, I was thinking of

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 19:30, Alexey Starikovskiy wrote: > Yes, something like that should do... > I'd prefer not to call ACPI functions from outside of drivers/acpi, > but this could be cleaned later. Actually, I was thinking of adding two operations to hibernation_ops() (now, that we have it :

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Alexey Starikovskiy
Yes, something like that should do... I'd prefer not to call ACPI functions from outside of drivers/acpi, but this could be cleaned later. On 5/9/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Wednesday, 9 May 2007 15:34, Alexey Starikovskiy wrote: > > we needed to call pm_prepare() on boot

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 15:34, Alexey Starikovskiy wrote: > we needed to call pm_prepare() on boot kernel only to disable GPEs to > resolve 7887. It will also blink the LEDs during the resume image > load, but it's possible to live without it. > If you drop call to pm_prepare(), we still need to d

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Alexey Starikovskiy
we needed to call pm_prepare() on boot kernel only to disable GPEs to resolve 7887. It will also blink the LEDs during the resume image load, but it's possible to live without it. If you drop call to pm_prepare(), we still need to disable GPEs, so they will not fire during image switch. So if we di

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 13:59, Alexey Starikovskiy wrote: > This patch will disable EC GPE, which seems to be major problem. Could you please explain to me why you think so? Greetings, Rafael - This SF.net email is sponsore

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 08:58, Alexey Starikovskiy wrote: > I expect http://bugzilla.kernel.org/show_bug.cgi?id=7887 this bug to > pop again with this patch. Well, this change only reflects what's done in kernel/power/disk.c . Greetings, Rafael --

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Alexey Starikovskiy
This patch will disable EC GPE, which seems to be major problem. Regards, Alex On 5/9/07, Alexey Starikovskiy <[EMAIL PROTECTED]> wrote: I expect http://bugzilla.kernel.org/show_bug.cgi?id=7887 this bug to pop again with this patch. Regards, Alex. On 5/9/07, Rafael J. Wysocki <[EMAIL PROTECTE

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-08 Thread Alexey Starikovskiy
I expect http://bugzilla.kernel.org/show_bug.cgi?id=7887 this bug to pop again with this patch. Regards, Alex. On 5/9/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > The restore part of the hibernation code should not call any 'platform' > functi