[systemd-devel] [PATCH] match: kdbus_match_entry_free fixed

2014-02-13 Thread Radoslaw Pajak
Signed-off-by: Radoslaw Pajak --- match.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/match.c b/match.c index d619bef..4c51327 100644 --- a/match.c +++ b/match.c @@ -121,6 +121,9 @@ static void kdbus_match_entry_free(struct kdbus_match_entry *entry) list_for_each_entry_sa

Re: [systemd-devel] Impossible to autologin on tty1 on Fedora 20

2014-02-13 Thread Jason St. John
On Thu, Feb 13, 2014 at 9:17 AM, Federico Carotenuto wrote: > Kind Systemd mailing list, > > I'm currently facing lots of problems in setting up autologin on a minimal > install (no xserver) of Fedora 20: up until now I followed the guide at this > link > https://fedoraproject.org/wiki/Systemd#How

Re: [systemd-devel] [PATCH] core/service: check if mainpid matches only if it set

2014-02-13 Thread Lennart Poettering
On Fri, 14.02.14 02:51, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > So, what I am afraid of here is that some process has some unpriviliged > > children (CGI scripts or so), and for some reason they stay around after > > the daemon itself is already terminated, and then can confuse

Re: [systemd-devel] [PATCH] core/service: check if mainpid matches only if it set

2014-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 14, 2014 at 02:38:48AM +0100, Lennart Poettering wrote: > On Fri, 14.02.14 02:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > > On Fri, Feb 14, 2014 at 02:07:36AM +0100, Lennart Poettering wrote: > > > On Mon, 30.12.13 17:26, Zbigniew Jędrzejewski-Szmek (zbys...@in.

Re: [systemd-devel] [PATCH] core/service: check if mainpid matches only if it set

2014-02-13 Thread Lennart Poettering
On Fri, 14.02.14 02:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > On Fri, Feb 14, 2014 at 02:07:36AM +0100, Lennart Poettering wrote: > > On Mon, 30.12.13 17:26, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > > > > > -if (s->notify_access == NOTIFY

[systemd-devel] [PATCH 2/2] man: use spaces instead of tabs

2014-02-13 Thread Jason St. John
Several sections of the man pages included intermixed tabs and spaces; this commit replaces all tabs with spaces. --- man/crypttab.xml | 2 +- man/sd_bus_creds_get_pid.xml | 4 +-- man/systemd-delta.xml| 73 +--- man/systemd.service.xml

Re: [systemd-devel] [PATCH] core/service: check if mainpid matches only if it set

2014-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 14, 2014 at 02:07:36AM +0100, Lennart Poettering wrote: > On Mon, 30.12.13 17:26, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > > -if (s->notify_access == NOTIFY_MAIN && pid != s->main_pid) { > > +if (s->notify_access == NOTIFY_MAIN && s->main_pid !=

Re: [systemd-devel] [PATCH] Set loaded_policy in smack_setup()

2014-02-13 Thread Lennart Poettering
On Thu, 19.12.13 16:58, Łukasz Stelmach (l.stelm...@samsung.com) wrote: > With loaded_policy set to true mount_setup() relabels /dev properly. Hmm, is this still relevant? I am not grokking this patch though, as the only result of this is that label_fix() is called for all device nodes... Howev

Re: [systemd-devel] [PATCH] localectl: log error if bus_map_all_properties() fails

2014-02-13 Thread Lennart Poettering
On Thu, 19.12.13 11:14, Djalal Harouni (tix...@opendz.org) wrote: Applied! Thanks! > --- > src/locale/localectl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/locale/localectl.c b/src/locale/localectl.c > index b0abe7b..5929169 100644 > --- a/src/locale/locale

Re: [systemd-devel] [PATCH] core/service: check if mainpid matches only if it set

2014-02-13 Thread Lennart Poettering
On Mon, 30.12.13 17:26, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > -if (s->notify_access == NOTIFY_MAIN && pid != s->main_pid) { > +if (s->notify_access == NOTIFY_MAIN && s->main_pid != 0 && pid != > s->main_pid) { > log_warning_unit(u->id, >

Re: [systemd-devel] recipe for target 'dbus1-generator-install-hook' failed

2014-02-13 Thread Lennart Poettering
On Thu, 13.02.14 22:26, Simon Peeters (peeters.si...@gmail.com) wrote: Thanks! Applied! Please always send these things are proper git patches (and not linebroken, please!), so that I can immediately apply them! Thanks! Lennart -- Lennart Poettering, Red Hat _

Re: [systemd-devel] [PATCH] systemd.service(5): clarify behavior of SuccessExitStatus

2014-02-13 Thread Lennart Poettering
On Fri, 27.12.13 10:46, Dave Reisner (dreis...@archlinux.org) wrote: > The behavior of this is a little cryptic in that $MAINPID must exit as > a direct result of receiving a signal in order for a listed signal to > be considered a success condition. Applied! Thanks! > --- > man/systemd.service

Re: [systemd-devel] [PATCH 2/2] Add AppArmor profile switching

2014-02-13 Thread Lennart Poettering
On Fri, 03.01.14 17:22, m...@zarb.org (m...@zarb.org) wrote: Heya! This patch appears to be unmerged still. Unfortunately it doesn't apply anymore, but looks good otherwiese! Could you please rebase? I'll merge it then! One minor fix though: > --- a/src/core/execute.c > +++ b/src/core/execute.c

Re: [systemd-devel] [PATCH/RFC] gudev: add device::get_sysfs_attr_keys() and device::has_sysfs_attr()

2014-02-13 Thread Lennart Poettering
On Mon, 13.01.14 21:19, Andreas Fuchs (andu...@gmail.com) wrote: > For gudev -> gudevdevice: > - Add support for get_sysfs_attr_keys() > - Add support for has_sysfs_attr() > > Note: Only tested against systemd-204 on Ubuntu 13.10's patch-set... > RFC1: For some reason libudev cosiders every link

Re: [systemd-devel] Is masking an error?

2014-02-13 Thread Lennart Poettering
On Tue, 21.01.14 09:33, Holger Schurig (holgerschu...@gmail.com) wrote: > Hi, > > on my systemd v208 + many patches from the Fedora 21 source RPM i get > TWO error messages in my journal when I login as root: > > 09:27:58 systemd-logind[118]: Failed to start unit user@0.service: > Unit user@0.se

Re: [systemd-devel] [PATCH] shared: include root when canonicalizing conf paths

2014-02-13 Thread Lennart Poettering
On Fri, 31.01.14 15:35, Michael Marineau (michael.marin...@coreos.com) wrote: Applied! Thanks! > The conf_files_list family accepts an alternate root path to prefix all > directories in the list but path_strv_canonicalize_uniq doesn't use it. > This results in the suspicious behavior of resolving

Re: [systemd-devel] StartTransientService problems

2014-02-13 Thread Lennart Poettering
On Wed, 05.02.14 18:27, Barry Scott (barry.sc...@onelan.co.uk) wrote: > > But I am hitting 2 issues: > 1) We cannot call sched_setscheduler() in spite of the cpu cgroup being setup > correctly (e.g. works with systemd-208): > # grep . /sys/fs/cgroup/cpu/onelan.slice/onelan-screen.slice/cpu.rt* >

Re: [systemd-devel] [PATCH 2/7] logind: close races on user and session states during login

2014-02-13 Thread Djalal Harouni
On Fri, Feb 07, 2014 at 04:48:39PM +0100, Lennart Poettering wrote: > On Thu, 06.02.14 21:37, Djalal Harouni (tix...@opendz.org) wrote: > > I think this one I fixed by adding a new "stopping" variable. Could you check? Yes, the stopping variable caught most of the races, I've sent another patch th

[systemd-devel] [PATCH] logind: close race on session state during logins

2014-02-13 Thread Djalal Harouni
At login there is a small race window where session_get_state() will return SESSION_ACTIVE instead of SESSION_OPENING. This must be fixed since during that time there are calls to session_save() to save session states and we want to write the correct state. When we queue the start scope and servic

Re: [systemd-devel] [PATCH] Use normal English elide in place of ellipsize

2014-02-13 Thread Zbigniew Jędrzejewski-Szmek
Hi Barry, I like language purity, but in this case I reluctantly have to agree that "ellipsize" is better. "Elide" is from latin "elidare" (to crush out), so the etymology fits perfectly. But "ellipsize" is just more understandable at first sight... even if it is a made up word. I'm sorry that I

Re: [systemd-devel] recipe for target 'dbus1-generator-install-hook' failed

2014-02-13 Thread Simon Peeters
On 02/13/14 21:29, Peeters Simon wrote: hello all, I usually run systemd from git using the arch aur package systemd-git and yaourt to compile and install this, but this currently fails with LN dbus1-generator-install-hook what="" && wants=runlevel3.target && dir=/usr/lib/systemd/sys

[systemd-devel] recipe for target 'dbus1-generator-install-hook' failed

2014-02-13 Thread Peeters Simon
hello all, I usually run systemd from git using the arch aur package systemd-git and yaourt to compile and install this, but this currently fails with LN dbus1-generator-install-hook what="" && wants=runlevel3.target && dir=/usr/lib/systemd/system && [ -z "$what" ] || ( dir=/tmp/yaourt-t

Re: [systemd-devel] threads and cgroups

2014-02-13 Thread Lennart Poettering
On Thu, 13.02.14 13:34, Florian Weimer (fwei...@redhat.com) wrote: > > On 02/12/2014 11:46 AM, Lennart Poettering wrote: > > >The plan by the kernel guys is to not allow cgroup management on threads > >anymore, only entire processes. The APIs in systemd reflect this > >decision by the kernel guy

Re: [systemd-devel] [PATCH v3] logind: make sure to terminate systemd user on logouts

2014-02-13 Thread Lennart Poettering
On Thu, 13.02.14 18:31, Djalal Harouni (tix...@opendz.org) wrote: Looks good! Thanks! Applied! > Currently if the user logs out, the GC may never call user_stop(), > this will not terminate the systemd user and (sd-pam) of that user. > > To fix this, remove the USER_CLOSING state check that is b

Re: [systemd-devel] How to prevent sleep during running oneshot units

2014-02-13 Thread Kai Krakow
Mirco Tischler schrieb: >> > It's late here so excuse me if I'm missing something. But wouldn't a >> > simple Before=sleep.target suffice to implement b)? >> >> I'm not sure... The unit is not enabled, only triggered by the timer - so > it >> may work. I think I may try that as an alternative to

Re: [systemd-devel] [PATCH 1/2] test: add basic seccomp tests

2014-02-13 Thread Ronny Chevalier
2014-02-13 16:25 GMT+01:00 Dave Reisner : > On Thu, Feb 13, 2014 at 09:58:53AM +0100, Ronny Chevalier wrote: >> 2014-02-13 3:34 GMT+01:00 Dave Reisner : >> > On Thu, Jan 23, 2014 at 01:34:57AM +0100, Ronny Chevalier wrote: >> >> --- >> >> test/TEST-04-SECCOMP/Makefile | 1 + >> >> t

[systemd-devel] [PATCH v3] logind: make sure to terminate systemd user on logouts

2014-02-13 Thread Djalal Harouni
Currently if the user logs out, the GC may never call user_stop(), this will not terminate the systemd user and (sd-pam) of that user. To fix this, remove the USER_CLOSING state check that is blocking the GC from calling user_stop(). Since if user_check_gc() returns false this means that all the s

Re: [systemd-devel] [PATCH 1/2] test: add basic seccomp tests

2014-02-13 Thread Dave Reisner
On Thu, Feb 13, 2014 at 09:58:53AM +0100, Ronny Chevalier wrote: > 2014-02-13 3:34 GMT+01:00 Dave Reisner : > > On Thu, Jan 23, 2014 at 01:34:57AM +0100, Ronny Chevalier wrote: > >> --- > >> test/TEST-04-SECCOMP/Makefile | 1 + > >> test/TEST-04-SECCOMP/test-seccomp.sh| 11 +

[systemd-devel] Impossible to autologin on tty1 on Fedora 20

2014-02-13 Thread Federico Carotenuto
Kind Systemd mailing list, I'm currently facing lots of problems in setting up autologin on a minimal install (no xserver) of Fedora 20: up until now I followed the guide at this link https://fedoraproject.org/wiki/Systemd#How_do_I_set_automatic_login_on_a_virtual_console_terminal.3F with only

Re: [systemd-devel] threads and cgroups

2014-02-13 Thread Florian Weimer
On 02/12/2014 11:46 AM, Lennart Poettering wrote: The plan by the kernel guys is to not allow cgroup management on threads anymore, only entire processes. The APIs in systemd reflect this decision by the kernel guys: you cannot arrange individual threads for organization by cgroups. Interestin

Re: [systemd-devel] [PATCH 1/2] test: add basic seccomp tests

2014-02-13 Thread Ronny Chevalier
2014-02-13 3:34 GMT+01:00 Dave Reisner : > On Thu, Jan 23, 2014 at 01:34:57AM +0100, Ronny Chevalier wrote: >> --- >> test/TEST-04-SECCOMP/Makefile | 1 + >> test/TEST-04-SECCOMP/test-seccomp.sh| 11 >> test/TEST-04-SECCOMP/test.sh| 79 >> ++