[Bug 1800499] Re: walinuxagent unit tests failing on build
Hello Łukasz, or anyone else affected, Accepted walinuxagent into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/walinuxagent/2.11.1.4-0ubuntu1~22.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-jammy. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: walinuxagent (Ubuntu Jammy) Status: In Progress => Fix Committed ** Changed in: walinuxagent (Ubuntu Focal) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
** Changed in: walinuxagent (Ubuntu Jammy) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
** Also affects: walinuxagent (Ubuntu Noble) Importance: Undecided Status: New ** Also affects: walinuxagent (Ubuntu Oracular) Importance: Undecided Status: New ** Also affects: walinuxagent (Ubuntu Plucky) Importance: High Status: Confirmed ** Changed in: walinuxagent (Ubuntu Plucky) Status: Confirmed => Fix Released ** Changed in: walinuxagent (Ubuntu Oracular) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
This diff in jammy: --- a/debian/rules +++ b/debian/rules @@ -27,7 +27,4 @@ override_dh_python3: dh_python3 -O--buildsystem=pybuild --shebang "/usr/bin/env python3" override_dh_auto_test: - # No test were run on any of the previous versions, temporarily - # ignoring the failures as they're not regressions (LP: #1800499) - # XXX: Those need to be fixed ASAP. - -timeout 120 dh_auto_test -O--buildsystem=pybuild + -timeout 120 pytest-3 --ignore-glob '*/test_cgroupconfigurator_sudo.py' --verbose tests Now we are calling pytest-3 directly, but still with the "-timeout 120" wrapper. Won't that again just make us ignore test failures? ** Changed in: walinuxagent (Ubuntu Jammy) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
The focal change seems right, as it's dropping the "-" prefix: --- a/debian/rules +++ b/debian/rules @@ -27,7 +27,4 @@ override_dh_python3: dh_python3 -O--buildsystem=pybuild --shebang "/usr/bin/env python3" override_dh_auto_test: - # No test were run on any of the previous versions, temporarily - # ignoring the failures as they're not regressions (LP: #1800499) - # XXX: Those need to be fixed ASAP. - -timeout 120 dh_auto_test -O--buildsystem=pybuild + nosetests3 -a '!requires_sudo' tests --with-timer -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
I *believe* this is fixed in noble and later, because there the test command is not prefixed with either timeout or "-", but could someone please clarify via bug tasks, or here in a comment? At least the main bug task (devel / plucky) should reflect the status in plucky. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
** No longer affects: walinuxagent (Ubuntu Noble) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
Ah, I see there is an upload for noble in unapproved. ... but it doesn't mention this bug. Sorry, I'm confused. The upload in jammy unapproved also doesn't mention this bug. Was this uploaded? NEVER MIND, I see it now in jammy unapproved :) ** Also affects: walinuxagent (Ubuntu Noble) Importance: Undecided Status: New ** Changed in: walinuxagent (Ubuntu Noble) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
We also don't do SRUs for trusty, xenial, and bionic anymore, as they are covered by ESM for security issues. Is your intention to also update those EOL releases, since they are tasks in this bug? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
I see the main devel task is still open, what's the status of this in plucky and oracular? And noble? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
** Description changed: + [ Impact ] + + Nowadays, we do not run tests at building time (nor autopkgtest), relying only on upstream's effectiveness. + Actually, upstream has fixed some issues we had when running their test in Ubuntu, even adapting it to pytest from nose depending on the python version (nose for <= 3.9, pytest for >= 3.10), so our future buildings could be more robust using them. + + [ Test Plan ] + + You cannot see any test suite launched at building time in the recent logs. Instead of that, we got (e.g., Focal [2], line 1147): + + # No test were run on any of the previous versions, temporarily + # ignoring the failures as they're not regressions (LP: #1800499) + # XXX: Those need to be fixed ASAP. + #-timeout 120 dh_auto_test -O--buildsystem=pybuild + + After applying this fix, you can see the test running (e.g. Focal [3], + line 1317) + + [ Where problems could occur ] + + The main issue could be that the build could not end due to an error arising when running the tests. This situation can occur when running any test suite, and we check that this doesn't happen before the package's submission. + Some tests could fail in the future due to other factors (like new uses/behaviours in Python versions), but this is not the case on a LTS: If new tests are incorporated due to a new MRE process, they will be adapted to the python version present in every series. + + [ Other Info ] + + For every series, the changes that make this fix possible are (as + listed in the changelog): + + - Jammy: + * Using now pytest for running the test suite (LP: #1800499) (LP: #2063046) as recommended by upstream: + - Focal: + * Upstream uses nose as testsuite under Python 3.9 (#3081)(LP: #1800499): + - Bionic, Xenial, Trusty: In progress + + [2] https://launchpadlibrarian.net/601725982/buildlog_ubuntu-focal-amd64.walinuxagent_2.2.46-0ubuntu1.2_BUILDING.txt.gz + [3] https://launchpadlibrarian.net/753297945/buildlog_ubuntu-focal-amd64.walinuxagent_2.11.1.4-0ubuntu1~20.04.1+ppa2_BUILDING.txt.gz + + [Original Description] + + The new upstream version of walinuxagent (2.2.32, unreleased in Ubuntu yet) and the previous 2.2.20 have failing unit-tests when run on Ubuntu. None of the previous walinuxagent package versions in Ubuntu were running the tests due to a bug in setup.py, resolved in a recent upstream commit [1]. Now, with the fix applied, many tests can be seen failing. All those unit-tests that are able to run during build should be passing, otherwise having unit-tests makes no sense. Example package build with listed unit-test failures: https://launchpadlibrarian.net/395192988/buildlog_ubuntu-cosmic- amd64.walinuxagent_2.2.32-0ubuntu1~test2_BUILDING.txt.gz [1] https://github.com/Azure/WALinuxAgent/pull/1244 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
** Merge proposal linked: https://code.launchpad.net/~mirespace/ubuntu/+source/walinuxagent/+git/walinuxagent/+merge/470169 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
** Changed in: walinuxagent (Ubuntu Focal) Assignee: (unassigned) => Miriam España Acebal (mirespace) ** Changed in: walinuxagent (Ubuntu Focal) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
** Merge proposal linked: https://code.launchpad.net/~mirespace/ubuntu/+source/walinuxagent/+git/walinuxagent/+merge/469956 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
** Also affects: walinuxagent (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: walinuxagent (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: walinuxagent (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: walinuxagent (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: walinuxagent (Ubuntu Jammy) Importance: Undecided Status: New ** Changed in: walinuxagent (Ubuntu Trusty) Status: New => Confirmed ** Changed in: walinuxagent (Ubuntu Xenial) Status: New => Confirmed ** Changed in: walinuxagent (Ubuntu Bionic) Status: New => Confirmed ** Changed in: walinuxagent (Ubuntu Focal) Status: New => Confirmed ** Changed in: walinuxagent (Ubuntu Jammy) Status: New => Confirmed ** Changed in: walinuxagent (Ubuntu Jammy) Assignee: (unassigned) => Miriam España Acebal (mirespace) ** Changed in: walinuxagent (Ubuntu Jammy) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800499] Re: walinuxagent unit tests failing on build
** Changed in: walinuxagent (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800499 Title: walinuxagent unit tests failing on build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
