[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
This bug was fixed in the package flash-kernel - 3.104ubuntu22 --- flash-kernel (3.104ubuntu22) jammy; urgency=medium * Add FK_FORCE_EFI environment variable to skip EFI check (LP: #2011536) - cherry pick from commit b58a33cc and 373a0a46 -- Aristo Chen Tue, 01 Oct 2024 06:27:04 + ** Changed in: flash-kernel (Ubuntu Jammy) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
@raof Good catch -- thankfully I can test that quite quickly on a Pi here! $ sudo apt install -t jammy-proposed flash-kernel .. usual apt output ... Unpacking flash-kernel (3.104ubuntu22) over (3.104ubuntu21) ... Setting up flash-kernel (3.104ubuntu22) ... Using DTB: bcm2710-rpi-3-b-plus.dtb flash-kernel: deferring update (trigger activated) Processing triggers for man-db (2.10.2-1) ... Processing triggers for initramfs-tools (0.140ubuntu13.4) ... update-initramfs: Generating /boot/initrd.img-5.15.0-1065-raspi Using DTB: bcm2710-rpi-3-b-plus.dtb Installing /lib/firmware/5.15.0-1065-raspi/device-tree/bcm2710-rpi-3-b-plus.dtb into /boot/dtbs/5.15.0-1065-raspi/./bcm2710-rpi-3-b-plus.dtb Taking backup of bcm2710-rpi-3-b-plus.dtb. Installing new bcm2710-rpi-3-b-plus.dtb. flash-kernel: installing version 5.15.0-1065-raspi Taking backup of vmlinuz. Installing new vmlinuz. Taking backup of initrd.img. Installing new initrd.img. Taking backup of uboot_rpi_2.bin. Installing new uboot_rpi_2.bin. Taking backup of uboot_rpi_4_32b.bin. ... all the usual flash-kernel output on a Pi ... ** Tags removed: verification-needed-jammy ** Tags added: verification-done-jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
Sorry, but I think the test plan here had *3* components: 1. Test that this doesn't affect behaviour on a normal target machine (ie: on a device) 2. We should also test that the current behaviour of exiting when the /sys/firmware/efi directory is detected is retained when FK_FORCE_EFI is not set to "yes". 3. Finally, the new ability to skip the EFI detection check when FK_FORCE_EFI is set to "yes" must be tested. As far as I can see we've verified 2 & 3 here (that flash-kernel skips as normal on an EFI system, and that it does not skip with FORCE_EFI set to yes). I don't see a verification that flash-kernel works as normal on a device that is *not* an EFI device. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
** Tags removed: verification-done-jammy ** Tags added: verification-needed-jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
** Tags removed: verification-needed-jammy ** Tags added: verification-done-jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
@aristochen -- no, the retry of the riscv64 build succeeded. Provided the SRU test plan has been carried out successfully, in full (which appears to be the case from a quick skim?), all that's now required is to set the jammy verification tag again. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
Hi Andreas, I have followed your instructions in comment#16, and the behavior looks good, here are the outputs # Scenaro 1(while FK_FORCE_EFI is NOT set to "yes") ``` ubuntu@ubuntu:~$ sudo flash-kernel Using DTB: freescale/imx8mp-evk.dtb Installing /lib/firmware/5.15.0-1036-ein/device-tree/freescale/imx8mp-evk.dtb into /boot/dtbs/5.15.0-1036-ein/freescale/imx8mp-evk.dtb Taking backup of imx8mp-evk.dtb. Installing new imx8mp-evk.dtb. System running in EFI mode, skipping. ``` # Scenario 2(While FK_FORCE_EFI is set to "yes") ``` ubuntu@ubuntu:~$ sudo flash-kernel Using DTB: freescale/imx8mp-evk.dtb Installing /lib/firmware/5.15.0-1036-ein/device-tree/freescale/imx8mp-evk.dtb into /boot/dtbs/5.15.0-1036-ein/freescale/imx8mp-evk.dtb Taking backup of imx8mp-evk.dtb. Installing new imx8mp-evk.dtb. flash-kernel: installing version 5.15.0-1036-ein Taking backup of imx8mp-evk.dtb. Installing new imx8mp-evk.dtb. ``` Regarding to the comment#17, is there anything I need to do to fix it? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
Also, there seems to be an FTBFS on riscv64[1] which wasn't there in the previous update, so this is a regression. Since there are no logs for that failure, I have just retried the build, as that is commonly an indication of an infrastructure problem not related to the package itself. 1. https://launchpad.net/ubuntu/+source/flash-kernel/3.104ubuntu22/+build/29162596 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
Hello Aristo, thanks for your verification. The test plan, however, has more steps: > As this change should not impact the current usage of the tool, a test should > be carried out that the > normal default usage (i.e. on target platforms) is not affected and retains > the current behaviour. > > We should also test that the current behaviour of exiting when the > /sys/firmware/efi directory is > detected is retained when FK_FORCE_EFI is not set to "yes". > > Finally, the new ability to skip the EFI detection check when FK_FORCE_EFI is > set to "yes" must be > tested. As this is what was agreed on when the SRU was accepted, we need those tests to be carried out. I'm therefore setting the verification tag back to "needed". ** Tags removed: verification-done-jammy ** Tags added: verification-needed-jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
Hi, I have verified the version 3.104ubuntu22 on my i.MX8MP platform, and it fixes the issue here are the steps that I performed for testing 1. create the file /etc/flash-kernel/ignore-efi with content "yes" 2. install new version of flash-kernel 3. check if files are installed correctly under /boot/efi/ ** Tags removed: verification-needed-jammy ** Tags added: verification-done-jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
Hello Isaac, or anyone else affected, Accepted flash-kernel into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/flash- kernel/3.104ubuntu22 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-jammy. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: flash-kernel (Ubuntu Jammy) Status: Confirmed => Fix Committed ** Tags added: verification-needed verification-needed-jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
Setting devel to fix released as 3.107 was merged; made one minor change for sponsorship to add the bug number to d/changelog -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
This looks reasonable (patch matches the change that was made for 3.107), and the SRU template is well filled out. I'll sponsor this shortly. ** Changed in: flash-kernel (Ubuntu) Status: New => Fix Released ** Changed in: flash-kernel (Ubuntu Jammy) Status: Incomplete => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2011536] Re: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check
Hi Since Mantic is EOL now, I guess we could backport to Jammy directly. I noticed that there is a new version of flash-kernel in proposed pocket, but not in the updates pocket yet, so I made a debdiff based on the proposed version, please let me know if you have any concern, thanks! ** Patch added: "flash-kernel_3.104ubuntu22.debdiff" https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/2011536/+attachment/5823680/+files/flash-kernel_3.104ubuntu22.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2011536 Title: [SRU] Add FK_FORCE_EFI environment variable to skip EFI check To manage notifications about this bug go to: https://bugs.launchpad.net/flash-kernel/+bug/2011536/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
