[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
** Merge proposal linked: https://code.launchpad.net/~r41k0u/ubuntu/+source/needrestart/+git/needrestart/+merge/478237 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
** Merge proposal unlinked: https://code.launchpad.net/~r41k0u/ubuntu/+source/needrestart/+git/needrestart/+merge/478237 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
** Merge proposal linked: https://code.launchpad.net/~r41k0u/ubuntu/+source/needrestart/+git/needrestart/+merge/478237 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
RE: [Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
** Attachment added: "BakkersteamServicesHandtekening_5753069d-88c4-4c40-beac-69286b4c6a54.png" https://bugs.launchpad.net/bugs/2085070/+attachment/5844110/+files/BakkersteamServicesHandtekening_5753069d-88c4-4c40-beac-69286b4c6a54.png ** Attachment added: "iso27001_935810b9-e91d-44b6-a223-508112bcd1ea.png" https://bugs.launchpad.net/bugs/2085070/+attachment/5844111/+files/iso27001_935810b9-e91d-44b6-a223-508112bcd1ea.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
This bug was fixed in the package needrestart - 3.6-8ubuntu7 --- needrestart (3.6-8ubuntu7) plucky; urgency=medium * Don't restart glusterd automatically (LP: #2085070) - d/p/lp2085070/0020-ubuntu-avoid-restart-glusterd.patch: Add regex to ignore glusterd and for automatic restart * Don't restart keepalived automatically (LP: #2089155) - d/p/lp2089155/0021-ubuntu-avoid-restart-keepalived.patch: Add regex to ignore keepalived and for automatic restart -- Pragyansh Chaturvedi Tue, 10 Dec 2024 13:22:02 +0530 ** Changed in: needrestart (Ubuntu Plucky) Status: Incomplete => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
I have uploaded a patch for the devel series (plucky) for now. But before we try to push an SRU through, I would like to dig more into the restart-ability of glusterd. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
** Also affects: glusterfs (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
The After= makes complete sense. It's the Requires= I am not sure of. Have you tried without that? Or maybe use Wants= instead? If glusterd.service is safe to restart (i.e. won't disrupt the mount), then it should be allowed to do so. Removing Requires= would prevent dependent services from being restarted, too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
its a chain the glusterd takes a bit of time to initialize, for that reason the mount has the Requires=glusterd.service After=glusterd.service It was the only way I would always have the FS mounted after a reboot, without it, it would be a hit/mis. An application requiring the mount has a After=network.target glusterfs.mount Requires= glusterfs.mount Again the only way after many reboots I got this chain working. The restart of glusterd by needrestart led to the application restarting unwanted which means the mount restarted. if you don't feel its needed I just manually add it, I feel restarting a FS (which I think happend) is not something that should be done automaticly. But maybe I am wrong. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
Is it really necessary for the mount unit to Requires=glusterd.service? Does restarting glusterd.service actually make the shared mount unusable? If you remove the Requires=glusterd.service (or the Requires=shared.mount on the other unit), and restart glusterd.service, does everything carry on OK? > Other services can depend on it and because of that also get an unwanted / unplanned restart. Keep in mind that *any* unit can set Requires=.service, so I am not sure this is a strong enough justification for changing the *default* needrestart.conf. Maybe others have already considered this, but it's not clear to me that this has been considered. ** Changed in: needrestart (Ubuntu Noble) Status: New => Incomplete ** Changed in: needrestart (Ubuntu Oracular) Status: New => Incomplete ** Changed in: needrestart (Ubuntu Plucky) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
** Also affects: needrestart (Ubuntu Noble) Importance: Undecided Status: New ** Also affects: needrestart (Ubuntu Oracular) Importance: Undecided Status: New ** Also affects: needrestart (Ubuntu Plucky) Importance: Undecided Assignee: Pragyansh Chaturvedi (r41k0u) Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2085070] Re: [SRU] glusterd should not be automatically restarted
** Summary changed: - [SRU] glusterd and keepalived should not be automatically restarted + [SRU] glusterd should not be automatically restarted ** Description changed: [ Impact ] * glusterd.service should not be automatically restarted after an update as other services which depend on it will also get an unplanned restart. * This change adds a regex pattern for glusterd.service in the default needrestart.conf to prevent it's automatic restart. - * Similarly, as reported in #2089155, keepalived must not be automatically -restarted as other services depending on it's presence and status quo may -be disrupted - [ Test Plan ] - * Install glusterfs-server and keepalived + * Install glusterfs-server - * Enable and start glusterd using systemctl - - * Create /etc/keepalived/keepalived.conf and add some sample text in it - after ! (essentially a comment) - - * Enable and start keepalived using systemctl (it might get stuck while - starting, just interrupt it using Ctrl-C) + * Enable and start glusterd using systemctl * Then run `sudo apt reinstall libc6` - * glusterd.service, keepalived.service will appear under `Restarting services...`, while it + * glusterd.service will appear under `Restarting services...`, while it should actually appear under `Service restarts being deferred:` [ Where problems could occur ] * The original bug reporter thinks that only glusterd.service must be excluded from restarting. There might be other glusterfs related services that might be restarting, but they haven't shown up during testing. (I tested with glustereventsd.service, gluster-ta-volume.service, glusterfssharedstorage.service and glusterd.service. Other services are not restarting) [ Other Info ] - * For keepalived: - https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2089155 - - * For glusterd: original bug report: + * Original bug report: ``` As requested in https://discourse.ubuntu.com/t/needrestart-changes-in-ubuntu-24-04-service-restarts/44671 Glusterd should not automaticly restart after an update. Other services can depend on it and because of that also get an unwanted / unplanned restart. besides I don't think its smart to restart a FS which is basicly what you are doing. ``` -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2085070 Title: [SRU] glusterd should not be automatically restarted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2085070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs