[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
This bug was fixed in the package livecd-rootfs - 2.765.54 --- livecd-rootfs (2.765.54) jammy; urgency=medium * Add support for arm64+tegra-jetson flavor. (LP: #2091392) livecd-rootfs (2.765.53) jammy; urgency=medium * live-build/ubuntu-cpc/hooks.d/base/disk-image-uefi.binary: ensure install_gub always creates a manifest before returning. (LP: #2086455) -- Remy Martin Fri, 06 Dec 2024 17:53:30 + ** Changed in: livecd-rootfs (Ubuntu Jammy) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
Hi. I indeed followed the test plan, using livecd-rootfs version 2.765.54. ** Tags removed: verification-needed verification-needed-jammy ** Tags added: verification-done-jammy ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
Hi Cody, thanks for your verification in the previous comment. Could you please confirm exactly the version of livecd-rootfs you used in your test, and that you followed the test plan from the bug description? If yes, then you can also change the verification tags to done, according to instructions from comment #4, which will then make this update ready for release. Thanks! ** Changed in: livecd-rootfs (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
Hi, I've verified the changes by building a riscv64 image from -proposed and verified that the image builds successfully. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
Hello Cody, or anyone else affected, Accepted livecd-rootfs into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd- rootfs/2.765.54 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-jammy. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: livecd-rootfs (Ubuntu Jammy) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
Oh, nevermind, the changes are still in -proposed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
@lool I think the changes have actually landed in -updates. Please correct me if I'm wrong but I believe this bug can be closed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
Heads-up that we're preparing another SRU in bug #2091392; I've reuploaded livecd-rootfs with both changes to the SRU review queue -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
** Also affects: livecd-rootfs (Ubuntu Jammy) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
** Merge proposal linked: https://code.launchpad.net/~codyshepherd/livecd-rootfs/+git/livecd-rootfs/+merge/475962 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2086455] Re: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present
** Description changed: [ Impact ] - * Lack of manifest causes downstream builds to break during the + * Lack of manifest causes downstream builds to break during the manifest copy commands in the qcow binary hook. This is causing jammy riscv64 builds to fail. - * proposed fix [1] is to check that $SUBARCH is nonzero in the if + * proposed fix [1] is to check that $SUBARCH is nonzero in the if branch that returns early. [ Test Plan ] - * reproducer is a livefs build of the ubuntu-cpc project for jammy + * reproducer is a livefs build of the ubuntu-cpc project for jammy riscv64 using the cloudware livefs build. The build will fail in the following way: ``` + cp livecd.ubuntu-cpc.disk-uefi.manifest /build/livecd.ubuntu-cpc.qcow.manifest cp: cannot stat 'livecd.ubuntu-cpc.disk-uefi.manifest': No such file or directory - + Echo_error config/hooks/021-qcow2-image.binary failed (exit non-zero). You should check for errors. + + Echo_error config/hooks/021-qcow2-image.binary failed (exit non-zero). You should check for errors. ``` [ Where problems could occur ] - * the risk is that there is some subarch outside of those specified in + * the risk is that there is some subarch outside of those specified in the if-branch for which the early return is necessary. I don't have any indication that there is, but my information could very well be incomplete. [ Other Info ] - * This appears to be isolated to jammy only, and given the difference - in how this hook in other suites handles riscv64, this change should not - need to be in other livecd-rootfs branches. + * This appears to be isolated to jammy only, as we don't build qcow + images for riscv in focal, and the hook was changed significantly in + noble. Therefore this change should not need to be in other livecd- + rootfs branches. 1. https://code.launchpad.net/~codyshepherd/livecd-rootfs/+git/livecd- rootfs/+merge/475962 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2086455 Title: manifest not generated for ubuntu-cpc uefi hook in riscv64 when no subarch present To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2086455/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
