[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
Ubuntu 24.10 (Oracular Oriole) has reached end of life, so this bug will not be fixed for that specific release. ** Changed in: systemd-hwe (Ubuntu Oracular) Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
Given Chris's opinion above, and since the patch proposed in bug 2103967 has been accepted into -proposed, we should go ahead and reject these systemd-hwe uploads. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
Between this and 2103967 the hwdb approach the approach with the most limited range of problems, targeting only specific hardware, at the cost of possibly needing further updates when *new* hardware exists. Hm. But by my understanding of the input stack, *this* will result in both Wayland and Xorg sessions seeing the extra key as F20, which is a change of behaviour for Wayland sessions which would currently see KEY_MICMUTE and which users could have configured bindings for? So perhaps 2103967 is the conservative approach - it only applies to Xorg, where no-one can be using KEY_MICMUTE as it has a keycode greater than (255 - 8), and I *think* anyone who has remapped it with a hwdb entry will be unaffected by the x-x-i-libinput patch (as it will already have been remapped before hitting the codepath in the patch). Does that sound right to everyone else? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
>> Hm. But by my understanding of the input stack, *this* will result in both Wayland and Xorg sessions seeing the extra key as F20, which is a change of behaviour for Wayland sessions which would currently see KEY_MICMUTE and which users could have configured bindings for? > That is the convention used in the version of systemd hwdb under noble and oracular. The hwdb used in plucky does not convert micmute key to f20 there. And the x-x-i-libinput patch won't result in a change of behaviour for systems that already have a hwdb entry (as it's already remapped to F20), and will mean we won't need to make any more updates to the hwdb for this issue. I therefore think 2103967 is the safer option, and what we should pursue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
> Hm. But by my understanding of the input stack, *this* will result in both Wayland and Xorg sessions seeing the extra key as F20, which is a change of behaviour for Wayland sessions which would currently see KEY_MICMUTE and which users could have configured bindings for? That is the convention used in the version of systemd hwdb under noble and oracular. The hwdb used in plucky does not convert micmute key to f20 there. > So perhaps 2103967 is the conservative approach - it only applies to Xorg, where no-one can be using KEY_MICMUTE as it has a keycode greater than (255 - 8), and I *think* anyone who has remapped it with a hwdb entry will be unaffected by the x-x-i-libinput patch (as it will already have been remapped before hitting the codepath in the patch). This is correct. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
Okay, it appears this is ready for sponsorship. I think Nick's query above is answered so I'm setting to confirmed, sponsoring for oracular and noble, and unsubscribing ubuntu-sponsors. ** Changed in: systemd-hwe (Ubuntu Noble) Status: Incomplete => Confirmed ** Changed in: systemd-hwe (Ubuntu Oracular) Status: Incomplete => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
Yes, however Bug 2103967 is less likely to get a pass from SRU maintainers, as the change is probably unsuitable for SRU, and this only affects only one series of Dell systems. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
Okay, so is this proposed as an *alternative* to the fix proposed in bug 2103967? At least for noble and oracular? ** Changed in: systemd-hwe (Ubuntu) Status: Incomplete => Invalid ** Changed in: systemd-hwe (Ubuntu Noble) Status: New => Incomplete ** Changed in: systemd-hwe (Ubuntu Oracular) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
It is not needed for plucky as we have tested that the changes in xserver-xorg-input-libinput which is included in plucky fixed this issue. The main reason for mapping micmute key to f20 is thst Xorg does not take key code > 255 (in wayland, usually it takes the key code as-is from libinput) but mic mute key is at 256 after offsetting by 8 from kernel key code. In noble and oracular we use hwdb to workaround the issue. From plucky, the patches initiated from systemd developers decided not to include such hacks, and the responsibility is pushed to Xorg input modules. I've posted the story in Bug #2103967 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
Is this fixed in upstream systemd? I don't see it there from a quick look. It's okay if it isn't yet, but it should be forwarded. This is also relevant to determining if we need to fix this in plucky, too. ** Changed in: systemd-hwe (Ubuntu) Status: New => Incomplete ** Also affects: systemd-hwe (Ubuntu Oracular) Importance: Undecided Status: New ** Also affects: systemd-hwe (Ubuntu Noble) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
** Patch added: "oracular debdiff" https://bugs.launchpad.net/ubuntu/+source/systemd-hwe/+bug/2105957/+attachment/5868787/+files/systemd-hwe_256.4.2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd-hwe/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
** Tags added: jira-cpl-119 oem-priority -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2105957] Re: [SRU] Add micmute key for Dell Pro Max series
** Patch added: "noble debdiff" https://bugs.launchpad.net/ubuntu/+source/systemd-hwe/+bug/2105957/+attachment/5868786/+files/systemd-hwe_255.1.5.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2105957 Title: [SRU] Add micmute key for Dell Pro Max series To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd-hwe/+bug/2105957/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
