Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-26 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:145 http://91.189.93.70:8080/job/help-app-ci/36/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/36 SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/38 Click here to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-26 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:144 http://91.189.93.70:8080/job/help-app-ci/35/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/35/console FAILURE: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/37/co

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-26 Thread Nicholas Skaggs
Nicholas Skaggs has proposed merging lp:~nskaggs/help-app/functional-test-template into lp:help-app. Commit message: Add basic skeleton structure for adding functional tests Requested reviews: Ubuntu Help app developers (help-app-dev) Related bugs: Bug #1456924 in Ubuntu Help App: "Add initi

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app

2015-05-26 Thread Roman Shchekin
Good idea came to me late - change icon for reboot only, so users will understand that app is new... -- https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-icon/+merge/260149 Your team Ubuntu RSS Feed Reader Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list:

[Ubuntu-touch-coreapps-reviewers] [Bug 1457424] Re: Please update icon (May 2015)

2015-05-26 Thread Ubuntu Phone Apps Jenkins Bot
Fix committed into lp:ubuntu-rssreader-app at revision 388, scheduled for release in ubuntu-rssreader-app, milestone alpha-1 ** Changed in: ubuntu-rssreader-app Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu RSS Feed Reader De

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app

2015-05-26 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-icon/+merge/260149 Your team Ubuntu RSS Feed Reader Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app

2015-05-26 Thread noreply
The proposal to merge lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-icon/+merge/260149 -- Your team Ubuntu RSS Feed Reader Developers i

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app

2015-05-26 Thread Roman Shchekin
The proposal to merge lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-icon/+merge/260149 -- Your team Ubuntu RSS Feed Reader Develo

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~brendan-donegan/ubuntu-clock-app/disable_location_prompt into lp:ubuntu-clock-app

2015-05-26 Thread Brendan Donegan
We've been waiting too long for this - lets land it and in the event proper helpers are written for trust-prompt we can use those instead. -- https://code.launchpad.net/~brendan-donegan/ubuntu-clock-app/disable_location_prompt/+merge/242682 Your team Ubuntu Clock Developers is subscribed to branc

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~brendan-donegan/ubuntu-clock-app/disable_location_prompt into lp:ubuntu-clock-app

2015-05-26 Thread Brendan Donegan
Brendan Donegan has proposed merging lp:~brendan-donegan/ubuntu-clock-app/disable_location_prompt into lp:ubuntu-clock-app. Commit message: Disable the location service prompt for testing purposes Requested reviews: Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot): continuous-in

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into lp:ubuntu-clock-app

2015-05-26 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:268 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/649/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2816 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into lp:ubuntu-clock-app

2015-05-26 Thread Nekhelesh Ramananthan
Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into lp:ubuntu-clock-app. Commit message: Fixed empty state component warning. Requested reviews: Ubuntu Clock Developers (ubuntu-clock-dev) For more details, see: https://code.launchpad.net/~nik90/

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into lp:ubuntu-clock-app

2015-05-26 Thread Nekhelesh Ramananthan
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into lp:ubuntu-clock-app has been updated. Description changed to: Fixed empty state component warning "file:///opt/click.ubuntu.com/com.ubuntu.clock/3.3./share/qml/components/EmptyState.qml:36: TypeError: Cannot read pr

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app

2015-05-26 Thread noreply
The proposal to merge lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text/+merge/260121 -- Your team Ubuntu Cloc

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app

2015-05-26 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text/+merge/260121 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post t

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app

2015-05-26 Thread Nekhelesh Ramananthan
The proposal to merge lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text/+merge/260121 -- Your team Ubunt

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app

2015-05-26 Thread Nekhelesh Ramananthan
Review: Approve Thanks for the MP. Works nicely! I tested it in Chinese Locale and French with no visible regressions on N4 Vivid. Approving! -- https://code.launchpad.net/~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text/+merge/260121 Your team Ubuntu Clock Developers is subscribed to branc

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app

2015-05-26 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:388 http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/340/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2814 deb: http://91.189.93.70:8080/job/generic-mediumtests-utop

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app

2015-05-26 Thread Joey Chan
Joey Chan has proposed merging lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app. Commit message: update to new icon Requested reviews: Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot): continuous-integration Roman Shchekin (mrqtros) Related bugs: Bug #1

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app

2015-05-26 Thread Joey Chan
The proposal to merge lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app has been updated. Commit Message changed to: update to new icon For more details, see: https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-icon/+merge/260149 -- Your team Ubuntu RSS Feed Rea

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app

2015-05-26 Thread Joey Chan
The proposal to merge lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app has been updated. Commit Message changed to: update to new icon For more details, see: https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-icon/+merge/260086 -- Your team Ubuntu RSS Feed Rea

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app

2015-05-26 Thread Penk Chen
The proposal to merge lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app has been updated. Commit Message changed to: Use replace() to trim amText/pmText in DigitalMode For more details, see: https://code.launchpad.net/~penk/ubuntu-clock-app/use_replace_to_trim_am

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app

2015-05-26 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:267 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself): https://code.launchpad.net/~penk/ubun

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app

2015-05-26 Thread Penk Chen
Penk Chen has proposed merging lp:~penk/ubuntu-clock-app/use_replace_to_trim_am_pm_text into lp:ubuntu-clock-app. Requested reviews: Ubuntu Clock Developers (ubuntu-clock-dev) Related bugs: Bug #1458808 in Ubuntu Clock App: "DigitalMode time is empty in Chinese locale" https://bugs.launch

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/new-icon into lp:ubuntu-rssreader-app

2015-05-26 Thread Roman Shchekin
Specify commit message, please) -- https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/new-icon/+merge/260086 Your team Ubuntu RSS Feed Reader Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :