Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fazerlicourice/ubuntu-weather-app/autopilot-test-switch-locations into lp:ubuntu-weather-app

2016-01-31 Thread Vamshi Balanaga
Is this branch ready to be merged yet? Ie, has Jenkins been fixed? -- https://code.launchpad.net/~fazerlicourice/ubuntu-weather-app/autopilot-test-switch-locations/+merge/282988 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~fazerlicourice/ubuntu-weather-app/

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fazerlicourice/music-app/test-empty-library into lp:music-app

2016-01-04 Thread Vamshi Balanaga
Made the changes and pushed. -- https://code.launchpad.net/~fazerlicourice/music-app/test-empty-library/+merge/280794 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fazerlicourice/music-app/test-empty-library into lp:music-app

2016-01-04 Thread Vamshi Balanaga
Thank you very much. -- https://code.launchpad.net/~fazerlicourice/music-app/test-empty-library/+merge/280794 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewer

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fazerlicourice/music-app/test-empty-library into lp:music-app

2016-01-01 Thread Vamshi Balanaga
By verification, do you mean you have to see if it works? Or do know that it doesn't work and you need to see what's wrong? -- https://code.launchpad.net/~fazerlicourice/music-app/test-empty-library/+merge/280794 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing li

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-22 Thread Vamshi Balanaga
I fixed the method name, and resolved the conflict. Vamshi Balanaga On Tue, Dec 22, 2015 at 8:09 PM, Victor Thompson wrote: > Review: Needs Fixing > > Lastly, when I run this on the device I get the "No music found" page > consistently. I imagine there might be somethin

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-22 Thread Vamshi Balanaga
I apologize for that, I thought that I changed that. It's done now, just pushed. -- https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreap

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-21 Thread Vamshi Balanaga
s they are. Vamshi Balanaga On Mon, Dec 21, 2015 at 7:21 AM, Andrew Hayzen wrote: > The error is "Could not initialise media store: Tried to open a db with > schema version 9, while supported version is 10." > > bzr thinks that the mediastore.db has been modified, so what

[Ubuntu-touch-coreapps-reviewers] [Bug 1202472] Re: Backend support for opening a folder in the terminal

2015-12-20 Thread Vamshi Balanaga
** Changed in: ubuntu-terminal-app Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-19 Thread Vamshi Balanaga
Andrew, I made those changes and pushed. -- https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-c

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-18 Thread Vamshi Balanaga
I changed the schemaVersion to 10 and I changed the file removal parameter. The tests no longer work for me because its schemaVersion 10 but Nicholas informed me that its right. -- https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794 Your team Music App Developers

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-18 Thread Vamshi Balanaga
Like I said earlier, when I try to edit the sql files, the tests fail regardless of whether or not I had sqlite3 read them and convert to .db. Initially I'll get an error that says incomplete sql, this is because there is no semi-colon at the end of the line. After I add the semi-colon, it says

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-17 Thread Vamshi Balanaga
If I attempt to edit any of the .sql files, when I try to read them and convert them to .db, it doesn't work. The current .db files are from nskaggs' patch. I was unable to get the sql stuff to work. I get the error- 'no such table: schemaVersion' just like I was getting earlier. If I revert bac

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-17 Thread Vamshi Balanaga
It now passes pep8 and snowflake tests and I have added an entry for me in debian/changelog. -- https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-16 Thread Vamshi Balanaga
Vamshi Balanaga has proposed merging lp:~vamrocks602/music-app/test-empty-library into lp:music-app. Requested reviews: Nicholas Skaggs (nskaggs) For more details, see: https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794 Created a test to check if the