Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-30 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:851 http://91.189.93.70:8080/job/music-app-refactor-ci/55/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2462 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Victor Thompson
Currently there are issues with app rotation in vivid. These are fixed with the full implementation of shell rotation (which has not yet landed). This MP is more or less blocked from using autorotation until that lands in vivid and vivid becomes the stable channel. -- https://code.launchpad.net

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:849 http://91.189.93.70:8080/job/music-app-refactor-ci/50/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2399 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:848 http://91.189.93.70:8080/job/music-app-refactor-ci/49/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2398 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Andrew Hayzen
OK reverse cherry picked async-loader-pages out, but this [0] patch still remains not sure it is needed in this specific branch, but it does fix columnflow issues. 0 - http://bazaar.launchpad.net/~music-app-dev/music-app/refactor-now-playing-as-sidebar/revision/842 -- https://code.launchpad.ne

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Andrew Hayzen
Note this pulls in lp:~ahayzen/music-app/async-loader-pages as well. -- https://code.launchpad.net/~ahayzen/music-app/refactor-pull-now-playing-sidebar/+merge/253839 Your team Music App Developers is requested to review the proposed merge of lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Andrew Hayzen
Andrew Hayzen has proposed merging lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor. Commit message: * Make NowPlaying into a conditional sidebar Requested reviews: Music App Developers (music-app-dev) For more details, see: https://code.launchpad.net/~ahayz