Nik, thanks for your information. I forgot to set notifications for this merge
request so I didn't see it till now. Much appreciated.
--
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838
Your team Ubuntu Clock Developers is subscribed to branch lp:ubunt
We're using Jenkins which is hosted by the Canonical team which essentially
runs the necessary autopilot and qml unit tests to check for any regressions.
This infrastructure was set up by the canonical team and as such I do not have
much knowledge about its documentation. I would recommend comin
Sorry to interject in this code review, but the Widelands team is currently
investigating using test bots on Launchpad that check pull requests. Your team
seem to have managed to do that, could you share some insights/configuration
hints/documentation about the process? Are you using a self-host
thanks a lot!
--
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapp
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms
into lp:ubuntu-clock-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838
--
Your team Ubuntu Clock
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms
into lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838
--
Your team Ubuntu
Review: Approve
Looks good to me, just added two notes.
Diff comments:
> === modified file 'app/alarm/AlarmSettingsPage.qml'
> --- app/alarm/AlarmSettingsPage.qml 2014-10-16 19:03:51 +
> +++ app/alarm/AlarmSettingsPage.qml 2015-03-12 23:25:02 +
> @@ -50,10 +50,10 @@
> Compon
Review: Approve continuous-integration
PASSED: Continuous integration, rev:219
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/626/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2338
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms
into lp:ubuntu-clock-app has been updated.
Description changed to:
- Added plural translation forms to strings in the AlarmSettings.qml file.
- Updated pot file to also include the corrected city name "Simferopol" that
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms
into lp:ubuntu-clock-app has been updated.
Commit Message changed to:
- Added plural translation forms to strings in the AlarmSettings.qml file.
- Updated pot file to also include the corrected city name "Simferopol" t
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into
lp:ubuntu-clock-app.
Commit message:
Added plural translation forms to strings in the AlarmSettings.qml file.
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
B
11 matches
Mail list logo
