Re: Valves being converted to Filters?

2009-10-22 Thread Elli Albek
that case it may be safer to just use that class in the method signatures. E - Original Message - From: Christopher Schultz To: Tomcat Users List Sent: Wed, 21 Oct 2009 08:11:17 -0700 (PDT) Subject: Re: Valves being converted to Filters? Will there be a way to grab information from

Re: Valves being converted to Filters?

2009-10-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark, On 10/20/2009 9:47 PM, Mark Thomas wrote: >> Is there a specific reason for this? > > Portability, reduce internal code duplication (filters & valves have a lot in > common) Also, Tomcat has never provided standard request and response wrappe

Re: Valves being converted to Filters?

2009-10-21 Thread Mark Thomas
Eric B. wrote: > "Mark Thomas" wrote in message > news:200910202047470...@265006334... > >>> Although I love filters, I find that valves have a very specific need >>> within >>> the container as well; it allows you to configure the container >>> independently of the application. If everything

RE: Valves being converted to Filters?

2009-10-20 Thread Elli Albek
converted to Filters?    Hello Henri,    I was referring to public information such as : - Google Summer Of Code 2009, project "Convert current Tomcat valves to Servlet Filters" : http://wiki.apache.org/tomcat/SummerOfCode2009 and the various associated emails on Tomcat dev mailing li

Re: Valves being converted to Filters?

2009-10-20 Thread Eric B.
"Mark Thomas" wrote in message news:200910202047470...@265006334... >> Although I love filters, I find that valves have a very specific need >> within >> the container as well; it allows you to configure the container >> independently of the application. If everything is moving to filters, >>

Re: Valves being converted to Filters?

2009-10-20 Thread Mark Thomas
> From: "Eric B." > To: users@tomcat.apache.org > Sent: 20/10/09, 15:38:59 > Subject: Valves being converted to Filters? > Is this true? Is Tomcat moving away from valves and towards filters in the > next version(s)? Sort off. Ideally everywhere but I suspect som

Re: Valves being converted to Filters?

2009-10-20 Thread Cyrille Le Clerc
   Hello Henri,    I was referring to public information such as : - Google Summer Of Code 2009, project "Convert current Tomcat valves to Servlet Filters" : http://wiki.apache.org/tomcat/SummerOfCode2009 and the various associated emails on Tomcat dev mailing list. - Mark Thomas post on Tomcat us

Valves being converted to Filters?

2009-10-20 Thread Eric B.
Hi, I was looking at Bug 47330 (https://issues.apache.org/bugzilla/show_bug.cgi?id=47330) which is a filter / valve implementation of a Httpd's mod_remoteip module. What concerned me is a comment by the submitter at the very bottom of the report: "... As Tomcat valves are currently being con