Change in vdsm[master]: [wip] vdsm-tool command that retrieves host uuid

2013-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: [wip] vdsm-tool command that retrieves host uuid .. Patch Set 2: (2 inline comments) Commit Message Line 3:

Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

2013-05-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Patch Set 1: I would prefer that you didn't submit this (3 inline comments) Tha

Change in vdsm[master]: [wip] vdsm-tool command that retrieves host uuid

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] vdsm-tool command that retrieves host uuid .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2344/ : SUCCESS http

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 2: (1 inline comment) File vdsm/clientIF.py Line 343:

Change in vdsm[master]: [wip] vdsm-tool command that retrieves host uuid

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] vdsm-tool command that retrieves host uuid .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2344/ (2/3) -- To view, v

Change in vdsm[master]: [wip] vdsm-tool command that retrieves host uuid

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] vdsm-tool command that retrieves host uuid .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2411/ (3/3) -- To v

Change in vdsm[master]: [wip] vdsm-tool command that retrieves host uuid

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] vdsm-tool command that retrieves host uuid .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1509/ (1/3) -- T

Change in vdsm[master]: gluster: Added verbs for read, update, add and remove hooks

2013-05-19 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: Added verbs for read, update, add and remove hooks .. Patch Set 2: I would prefer that you didn't submit this (2 inline comments) ...

Change in vdsm[master]: Simplify setNewMtu()

2013-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Simplify setNewMtu() .. Patch Set 1: Saggi to the rescue! And until he comes, Mark, please ma k the failing test with @broken test. -- To view, visit http://g

Change in vdsm[master]: Simplify setNewMtu()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Simplify setNewMtu() .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2343/ : SUCCESS http://jenkins.ovirt.org/job/v

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2342/ : SUCCESS http:

Change in vdsm[master]: NetReload: netmodels for delNetwork

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2341/ : SUCCESS http://jenkins.

Change in vdsm[master]: Simplify setNewMtu()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Simplify setNewMtu() .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1508/ (3/3) -- To view, visit http://gerrit.

Change in vdsm[master]: NetReload: netmodels for delNetwork

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1506/ (3/3) -- To view, visit

Change in vdsm[master]: Improve the checking of mulitple direct users on an interfac...

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve the checking of mulitple direct users on an interface. .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2340/

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1507/ (3/3) -- To v

Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit

Change in vdsm[master]: Extract helper functions to update nic and bonding's mtu

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract helper functions to update nic and bonding's mtu .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2339/ : SUC

Change in vdsm[master]: Simplify setNewMtu()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Simplify setNewMtu() .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2410/ (2/3) -- To view, visit http://gerrit.ovi

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2409/ (2/3) -- To view

Change in vdsm[master]: NetReload: netmodels for delNetwork

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2408/ (2/3) -- To view, visit ht

Change in vdsm[master]: Improve the checking of mulitple direct users on an interfac...

2013-05-19 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Improve the checking of mulitple direct users on an interface. .. Improve the checking of mulitple direct users on an interface. Change-Id: I1e8bc4d8ee8709f72a5746edc

Change in vdsm[master]: Simplify setNewMtu()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Simplify setNewMtu() .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2343/ (1/3) -- To view, visit http://gerrit.ovirt.org

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2342/ (1/3) -- To view, visi

Change in vdsm[master]: NetReload: netmodels for delNetwork

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2341/ (1/3) -- To view, visit http://g

Change in vdsm[master]: Improve the checking of mulitple direct users on an interfac...

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve the checking of mulitple direct users on an interface. .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2340/ (3/3)

Change in vdsm[master]: Extract helper functions to update nic and bonding's mtu

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract helper functions to update nic and bonding's mtu .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2339/ (3/3) -- To

Change in vdsm[master]: Extract helper functions to update nic and bonding's mtu

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract helper functions to update nic and bonding's mtu .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1504/ (2/

Change in vdsm[master]: Improve the checking of mulitple direct users on an interfac...

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve the checking of mulitple direct users on an interface. .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/150

Change in vdsm[master]: Extract helper functions to update nic and bonding's mtu

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract helper functions to update nic and bonding's mtu .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2406/ (1/3)

Change in vdsm[master]: Improve the checking of mulitple direct users on an interfac...

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve the checking of mulitple direct users on an interface. .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2407/

Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/

Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_

Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2338/

Change in vdsm[master]: NetReload: netmodels for delNetwork

2013-05-19 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: NetReload: netmodels for delNetwork .. NetReload: netmodels for delNetwork This patch re-implements the delNetwork logic using the network entities defined in netmode

Change in vdsm[master]: Extract helper functions to update nic and bonding's mtu

2013-05-19 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Extract helper functions to update nic and bonding's mtu .. Extract helper functions to update nic and bonding's mtu Change-Id: Ic82b1d9a27492619548f1c7ba3fced79ee68a

Change in vdsm[master]: Simplify setNewMtu()

2013-05-19 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Simplify setNewMtu() .. Simplify setNewMtu() It will update the interface's MTU only if its user being removed has the maximum MTU. Change-Id: I32e8e0d45b7887af8fd1b

Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

2013-05-19 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Add a backward reference their master device for Vlan, Bond and Nic The netmodels keeps refren

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Move removing libvirt network to configurator .. Move removing libvirt network to configurator This patch adds a wrapper for the configWriter.removeLibvirtNetwork() i

Change in vdsm[master]: Fix bashisms in vdsmd.init.in and ovirt_functions.sh

2013-05-19 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Fix bashisms in vdsmd.init.in and ovirt_functions.sh .. Patch Set 2: Thanks Dan. checkbashisms depends on some Debian specific tools that adhere to the Debia

Change in vdsm[master]: NetReload: Moved delNetwork logic to the configurator

2013-05-19 Thread wudxw
Mark Wu has abandoned this change. Change subject: NetReload: Moved delNetwork logic to the configurator .. Patch Set 3: Abandoned It will be replaced by another patch. -- To view, visit http://gerrit.ovirt.org/14015 To unsubs

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 2: (1 inline comment) File vdsm/clientIF.py Line 343:

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) ...

Change in vdsm[master]: vdsm-tool command that retrives host uuid

2013-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool command that retrives host uuid .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) ..

Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

2013-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 7: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/1

Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

2013-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 7: (1 inline comment) File vdsm/alig

Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

2013-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 6: (2 inline comments) File vdsm/ali

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2337/ : SUCCESS http://jenkins.ovirt.

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14869 To unsubsc

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2337/ (2/3) -- To view, visit http://gerrit.

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1502/ (3/3) -- To view, visit http:

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2404/ (1/3) -- To view, visit http://g

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2336/ : SUCCESS http://jenkins.ovirt.or

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2403/ (3/3) -- To view, visit http://g

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2336/ (2/3) -- To view, visit http://gerrit.

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Deactivate libvirtVM.Drives() .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1501/ (1/3) -- To view, visit http:

Change in vdsm[master]: Deactivate libvirtVM.Drives()

2013-05-19 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: Deactivate libvirtVM.Drives() .. Deactivate libvirtVM.Drives() Change-Id: I8ba965f0987037fa5dafc6b3ea6eeb6f01a82436 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?

Change in vdsm[master]: vdsm-tool command that retrives host uuid

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool command that retrives host uuid .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2335/ : SUCCESS http://jenk

Change in vdsm[master]: vdsm-tool command that retrives host uuid

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool command that retrives host uuid .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1500/ (3/3) -- To view,

Change in vdsm[master]: vdsm-tool command that retrives host uuid

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool command that retrives host uuid .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2335/ (2/3) -- To view, visit ht

Change in vdsm[master]: vdsm-tool command that retrives host uuid

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool command that retrives host uuid .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2402/ (1/3) -- To view, vi

Change in vdsm[master]: vdsm-tool command that retrives host uuid

2013-05-19 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: vdsm-tool command that retrives host uuid .. vdsm-tool command that retrives host uuid vdsm-tool vdsm-id returns host uuid without requiring running instance o

Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2334/ : SUCC

Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 7: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1499/ (3

Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 7: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2334/ (2/3) -- T

Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 7: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2401/ (1/3)

Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

2013-05-19 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 6: (2 inline comments) File vdsm/align

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

2013-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: gluster: new vdsm verb glusterHostUUIDGet .. Patch Set 4: Looks good to me, but someone else must approve But I'm waiting for someone else (Adam, Saggi) to appr

Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation

2013-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 10: I would prefer that you didn't submit this (2 inline comments) Has this API been discussed with Eng