Change in vdsm[master]: netinfo: get an interface using one of IP addresses assgined...

Zhou Zheng Sheng has posted comments on this change. Change subject: netinfo: get an interface using one of IP addresses assgined to it .. Patch Set 4: I would prefer that you didn't submit this (3 inline comments) Basically

Change in vdsm[master]: gluster: verbs for managing services

Timothy Asir has posted comments on this change. Change subject: gluster: verbs for managing services .. Patch Set 19: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11094 To unsubscri

Change in vdsm[master]: Reduce the redundant parameters for addVlan()

Mark Wu has posted comments on this change. Change subject: Reduce the redundant parameters for addVlan() .. Patch Set 5: Verified Both of being port of bridge or iface of bridgeless network are configured properly. -- To vie

Change in vdsm[master]: Separate adding libvirt network from configuring host networ...

Mark Wu has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 6: Verified Test bridged network and bridgeless network on top of vlan, bond and nic. All

Change in vdsm[master]: mom: add mom balloon functional tests for running vms

Mark Wu has posted comments on this change. Change subject: mom: add mom balloon functional tests for running vms .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13156 T

Change in vdsm[master]: mom: add mom balloon functional tests for running vms

oVirt Jenkins CI Server has posted comments on this change. Change subject: mom: add mom balloon functional tests for running vms .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2569/ : SUCCESS

Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...

Zhou Zheng Sheng has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script .. Patch Set 2: I would prefer that you didn't submit this (5 inline comments) .

Change in vdsm[master]: Separate adding libvirt network from configuring host networ...

Mark Wu has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 6: (1 inline comment) File vdsm/netmod

Change in vdsm[master]: mom: add mom balloon functional tests for running vms

Mark Wu has posted comments on this change. Change subject: mom: add mom balloon functional tests for running vms .. Patch Set 5: I would prefer that you didn't submit this (2 inline comments) Just minor issues ..

Change in vdsm[master]: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addre...

Zhou Zheng Sheng has posted comments on this change. Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses .. Patch Set 5: No score; I would prefer that you didn't submit this You are correct. Let's r

Change in vdsm[master]: Extract helper functions for updating nic and bonding's mtu

oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract helper functions for updating nic and bonding's mtu .. Patch Set 5: No score Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2

Change in vdsm[master]: Simplify setNewMtu()

oVirt Jenkins CI Server has posted comments on this change. Change subject: Simplify setNewMtu() .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2641/ : SUCCESS -- To view, visit http://g

Change in vdsm[master]: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmd...

oVirt Jenkins CI Server has posted comments on this change. Change subject: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmdLine .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2566

Change in vdsm[master]: NetReload: netmodels for delNetwork

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2565/ : SUCCESS http://jenkins.ov

Change in vdsm[master]: Simplify setNewMtu()

oVirt Jenkins CI Server has posted comments on this change. Change subject: Simplify setNewMtu() .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2568/ : SUCCESS -- To view, visit http://gerrit.

Change in vdsm[master]: Simplify setNewMtu()

oVirt Jenkins CI Server has posted comments on this change. Change subject: Simplify setNewMtu() .. Patch Set 1: No score Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2567/ : SUCCESS http://jenkins.ovirt.or

Change in vdsm[master]: Improve the checking of mulitple direct users on an interfac...

oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve the checking of mulitple direct users on an interface. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2564/ :

Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal

oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2563/ : SUCCESS http://

Change in vdsm[master]: getAllTasksList\Status with spUUID retrieves info only if ho...

Yaniv Bronhaim has abandoned this change. Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM .. Patch Set 25: Abandoned due to http://gerrit.ovirt.org/#/c/15345/ - this change does not re

Change in vdsm[master]: Making getAllTasks[List and Statuses] an SPM command

Ayal Baron has posted comments on this change. Change subject: Making getAllTasks[List and Statuses] an SPM command .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15345 To unsubscribe, visi

Change in vdsm[master]: Making getAllTasks[List and Statuses] an SPM command

Ayal Baron has submitted this change and it was merged. Change subject: Making getAllTasks[List and Statuses] an SPM command .. Making getAllTasks[List and Statuses] an SPM command Currently VDSM does not manage HSM tasks. This

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2562/ : SUCCESS htt

Change in vdsm[master]: Separate adding libvirt network from configuring host networ...

oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2561/ :

Change in vdsm[master]: Reduce the redundant parameters for addVlan()

oVirt Jenkins CI Server has posted comments on this change. Change subject: Reduce the redundant parameters for addVlan() .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2560/ : SUCCESS http://

Change in vdsm[master]: Extract helper functions for updating nic and bonding's mtu

oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract helper functions for updating nic and bonding's mtu .. Patch Set 5: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2559/ :

Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2

Change in vdsm[master]: Add basic test cases for configuring network interfaces

oVirt Jenkins CI Server has posted comments on this change. Change subject: Add basic test cases for configuring network interfaces .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2557/ : SUCCES

Change in vdsm[master]: Separate adding libvirt network from configuring host networ...

Antoni Segura Puimedon has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 6: Verified Verified one of the following patch in the series, so I'll consi

Change in vdsm[master]: Reduce the redundant parameters for addVlan()

Antoni Segura Puimedon has posted comments on this change. Change subject: Reduce the redundant parameters for addVlan() .. Patch Set 5: Verified Verified one of the following patch in the series, so I'll consider this one ver

Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

Antoni Segura Puimedon has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Patch Set 5: Verified Verified the following patch in the series, so I'll consid

Change in vdsm[master]: Extract helper functions for updating nic and bonding's mtu

Antoni Segura Puimedon has posted comments on this change. Change subject: Extract helper functions for updating nic and bonding's mtu .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/14871 To unsubscribe, vis

Change in vdsm[master]: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmd...

Dan Kenigsberg has posted comments on this change. Change subject: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmdLine .. Patch Set 11: Verified -- To view, visit http://gerrit.ovirt.org/14111 To unsubscribe, visit

Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

Antoni Segura Puimedon has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit h

Change in vdsm[master]: Remove some cases of netinfo instance creation.

Antoni Segura Puimedon has abandoned this change. Change subject: Remove some cases of netinfo instance creation. .. Patch Set 9: Abandoned will be redone after the ongoing refactoring. -- To view, visit http://gerrit.ovirt.or

Change in vdsm[master]: Reduce the amount of netinfo instantiation.

Antoni Segura Puimedon has abandoned this change. Change subject: Reduce the amount of netinfo instantiation. .. Patch Set 3: Abandoned Because of networkReloaded this needs to be done differently. Will be done across the boar

Change in vdsm[master]: WIP: Multiple Gateways Feature

Antoni Segura Puimedon has posted comments on this change. Change subject: WIP: Multiple Gateways Feature .. Patch Set 6: I would prefer that you didn't submit this (3 inline comments) A couple of changes originating from the

Change in vdsm[ovirt-3.2]: Support teardownVolumePath(None)

Federico Simoncelli has posted comments on this change. Change subject: Support teardownVolumePath(None) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15353 To unsubscribe, visit

Change in vdsm[ovirt-3.2]: Support teardownVolumePath(None)

Federico Simoncelli has submitted this change and it was merged. Change subject: Support teardownVolumePath(None) .. Support teardownVolumePath(None) Change-Id: I68bc4996ec1789e090111e8aeadaf733e163543b Bug-Url: https://bugzill

Change in vdsm[master]: Extract helper functions for updating nic and bonding's mtu

Antoni Segura Puimedon has posted comments on this change. Change subject: Extract helper functions for updating nic and bonding's mtu .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://ger

Change in vdsm[master]: Reduce the redundant parameters for addVlan()

Antoni Segura Puimedon has posted comments on this change. Change subject: Reduce the redundant parameters for addVlan() .. Patch Set 5: Looks good to me, but someone else must approve Nice simplification. We can probably simpl

Change in vdsm[master]: Separate adding libvirt network from configuring host networ...

Antoni Segura Puimedon has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 6: Looks good to me, but someone else must approve Thanks for the rebase Mar

Change in vdsm[master]: NetReload: netmodels for editBonding/removeBonding

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for editBonding/removeBonding .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2556/ : SUCCESS

Change in vdsm[master]: iproute2 binary wrapper

Antoni Segura Puimedon has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 4: (8 inline comments) Thanks for doing the wrapper. A few comments to improve the modeling and the robustness of

Change in vdsm[master]: Simplify setNewMtu()

oVirt Jenkins CI Server has posted comments on this change. Change subject: Simplify setNewMtu() .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2555/ : SUCCESS http://jenkins.ovirt.org/job/v

Change in vdsm[master]: Move removing libvirt network to configurator

Mark Wu has abandoned this change. Change subject: Move removing libvirt network to configurator .. Patch Set 3: Abandoned included in another patch -- To view, visit http://gerrit.ovirt.org/14874 To unsubscribe, visit http://

Change in vdsm[master]: Simplify setNewMtu()

Mark Wu has uploaded a new change for review. Change subject: Simplify setNewMtu() .. Simplify setNewMtu() It will update the interface's MTU only if its user being removed has the maximum MTU. Change-Id: I32e8e0d45b7887af8fd1b

Change in vdsm[master]: NetReload: netmodels for editBonding/removeBonding

Mark Wu has uploaded a new change for review. Change subject: NetReload: netmodels for editBonding/removeBonding .. NetReload: netmodels for editBonding/removeBonding Re-implement the logic of editBonding and removeBonding using

Change in vdsm[ovirt-3.2]: Support teardownVolumePath(None)

Douglas Schilling Landgraf has posted comments on this change. Change subject: Support teardownVolumePath(None) .. Patch Set 1: Looks good to me, but someone else must approve same as upstream. -- To view, visit http://gerrit.

Change in vdsm[ovirt-3.2]: Support teardownVolumePath(None)

Hello Douglas Schilling Landgraf, Federico Simoncelli, Vinzenz Feenstra, Eduardo, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/15353 to review the following change. Change subject: Support teardownVolumePath(None) .

Change in vdsm[master]: Support teardownVolumePath(None)

Dan Kenigsberg has submitted this change and it was merged. Change subject: Support teardownVolumePath(None) .. Support teardownVolumePath(None) Change-Id: I68bc4996ec1789e090111e8aeadaf733e163543b Bug-Url: https://bugzilla.red

Change in vdsm[master]: Support teardownVolumePath(None)

Dan Kenigsberg has posted comments on this change. Change subject: Support teardownVolumePath(None) .. Patch Set 1: Verified; Looks good to me, approved Thanks. -- To view, visit http://gerrit.ovirt.org/15316 To unsubscribe, v

Change in vdsm[master]: vdsm: migration progress: count memRemaining also

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration progress: count memRemaining also .. Patch Set 3: No score Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2554/ : SUC

Change in vdsm[master]: NetReload: netmodels for addNetwork

Dan Kenigsberg has submitted this change and it was merged. Change subject: NetReload: netmodels for addNetwork .. NetReload: netmodels for addNetwork This patch defines the netwok entities that we use in oVirt: - NetDevice, -

Change in vdsm[master]: NetReload: netmodels for addNetwork

Dan Kenigsberg has posted comments on this change. Change subject: NetReload: netmodels for addNetwork .. Patch Set 22: Looks good to me, approved basically copying Mark's ack. Thanks! -- To view, visit http://gerrit.ovirt.org

Change in vdsm[master]: vdsm: migration progress: count memRemaining also

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration progress: count memRemaining also .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2553/ : SUCCESS h

Change in vdsm[master]: Making getAllTasks[List and Statuses] an SPM command

oVirt Jenkins CI Server has posted comments on this change. Change subject: Making getAllTasks[List and Statuses] an SPM command .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2551/ : SUCCESS

Change in vdsm[master]: iproute2 binary wrapper

Antoni Segura Puimedon has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 4: I would prefer that you didn't submit this (4 inline comments) Beginning of the review. Will continue later. .

Change in vdsm[master]: [WIP] vdsm: memory overcommitment reporting

Peter V. Saveliev has abandoned this change. Change subject: [WIP] vdsm: memory overcommitment reporting .. Patch Set 2: Abandoned It is not a fix, neither an RFE patch. So close it as the current behaviour reflects accurate n

Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...

Yaniv Bronhaim has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script .. Patch Set 1: (3 inline comments) Fi

Change in vdsm[master]: NetReload: netmodels for addNetwork

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for addNetwork .. Patch Set 22: No score Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2550/ : SUCCESS http://

Change in vdsm[master]: Making getAllTasks[List and Statuses] an SPM command

Yaniv Bronhaim has posted comments on this change. Change subject: Making getAllTasks[List and Statuses] an SPM command .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/15345 To unsubscribe, visit http://gerri

Change in vdsm[master]: Returning response to getAllTasksList only if running as SPM

oVirt Jenkins CI Server has posted comments on this change. Change subject: Returning response to getAllTasksList only if running as SPM .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2549/ :

Change in vdsm[master]: NetReload: netmodels for addNetwork

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for addNetwork .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1724/ : FAILURE http://jenk

Change in vdsm[master]: NetReload: netmodels for addNetwork

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork .. Patch Set 22: Verified Just changed isVlanned as per Dan's suggestion. Rerun some tests and everything is green.

Change in vdsm[master]: Returning response to getAllTasksList only if running as SPM

Yaniv Bronhaim has uploaded a new change for review. Change subject: Returning response to getAllTasksList only if running as SPM .. Returning response to getAllTasksList only if running as SPM Change-Id: I46a107d8c7ddcd0b4e7404

Change in vdsm[master]: NetReload: netmodels for addNetwork

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for addNetwork .. Patch Set 22: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2548/ : FAILURE http://jenkins

Change in vdsm[master]: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addre...

Hunt Xu has posted comments on this change. Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses .. Patch Set 5: (1 inline comment) File lib/vdsm/

Change in vdsm[master]: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addre...

Hunt Xu has posted comments on this change. Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses .. Patch Set 5: Would you take a look at http://gerrit.ovirt.org/#/c/11519/. That should fix problem

Change in vdsm[master]: NetReload: netmodels for addNetwork

Mark Wu has posted comments on this change. Change subject: NetReload: netmodels for addNetwork .. Patch Set 21: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, vi

Change in vdsm[master]: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addre...

Zhou Zheng Sheng has posted comments on this change. Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/11520 To unsubscribe, visi

Change in vdsm[master]: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addre...

oVirt Jenkins CI Server has posted comments on this change. Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2547/

Change in vdsm[master]: NetReload: netmodels for addNetwork

Dan Kenigsberg has posted comments on this change. Change subject: NetReload: netmodels for addNetwork .. Patch Set 21: (1 inline comment) File lib/vdsm/netinfo.py Line 446:

Change in vdsm[master]: vdsm-tool: avoid service action redirections

Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: avoid service action redirections .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15099 To

Change in vdsm[master]: mom: add mom balloon functional tests for running vms

Doron Fediuck has posted comments on this change. Change subject: mom: add mom balloon functional tests for running vms .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1

Change in vdsm[master]: [WIP] vdsm: memory overcommitment reporting

Doron Fediuck has posted comments on this change. Change subject: [WIP] vdsm: memory overcommitment reporting .. Patch Set 2: Fails I'm not sure this is actually fixing the root cause. I have a sample where ksm is not running,

Change in vdsm[master]: NetReload: netmodels for addNetwork

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork .. Patch Set 21: Verified -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.