Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-11 Thread Connor Kuehl
On 5/11/21 5:23 AM, Stefan Hajnoczi wrote: > On Fri, May 07, 2021 at 05:15:27PM -0500, Connor Kuehl wrote: >> @@ -1245,7 +1262,8 @@ __releases(fiq->lock) >> req->in.h.nodeid, req->in.h.len, >> fuse_len_args(req->args->out_numargs, req->args->out_args)); >> >> -fsvq

Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-11 Thread Stefan Hajnoczi
On Fri, May 07, 2021 at 05:15:27PM -0500, Connor Kuehl wrote: > @@ -1245,7 +1262,8 @@ __releases(fiq->lock) >req->in.h.nodeid, req->in.h.len, >fuse_len_args(req->args->out_numargs, req->args->out_args)); > > - fsvq = &fs->vqs[queue_id]; > + fsvq = this_cpu_

Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-10 Thread Vivek Goyal
On Mon, May 10, 2021 at 11:15:21AM -0500, Connor Kuehl wrote: > On 5/10/21 10:25 AM, Vivek Goyal wrote: > > On Fri, May 07, 2021 at 03:15:27PM -0700, Connor Kuehl wrote: > >> Distribute requests across the multiqueue complex automatically based > >> on the IRQ affinity. > > > > Hi Connor, > > > >

Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-10 Thread Connor Kuehl
On 5/10/21 10:25 AM, Vivek Goyal wrote: > On Fri, May 07, 2021 at 03:15:27PM -0700, Connor Kuehl wrote: >> Distribute requests across the multiqueue complex automatically based >> on the IRQ affinity. > > Hi Connor, > > Thanks for the patch. I will look into it and also test it. > > How did you

Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-10 Thread Vivek Goyal
On Fri, May 07, 2021 at 03:15:27PM -0700, Connor Kuehl wrote: > Distribute requests across the multiqueue complex automatically based > on the IRQ affinity. Hi Connor, Thanks for the patch. I will look into it and also test it. How did you test it? Did you modify vitiofsd to support multiqueue.

Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-08 Thread Connor Kuehl
On 5/7/21 5:15 PM, Connor Kuehl wrote: > Distribute requests across the multiqueue complex automatically based > on the IRQ affinity. > > Suggested-by: Stefan Hajnoczi > Signed-off-by: Connor Kuehl > --- > fs/fuse/virtio_fs.c | 30 -- > 1 file changed, 24 insertions(

Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-07 Thread kernel test robot
Hi Connor, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on fuse/for-next] [also build test WARNING on linux/master linus/master v5.12 next-20210507] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

[PATCH] virtiofs: Enable multiple request queues

2021-05-07 Thread Connor Kuehl
Distribute requests across the multiqueue complex automatically based on the IRQ affinity. Suggested-by: Stefan Hajnoczi Signed-off-by: Connor Kuehl --- fs/fuse/virtio_fs.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/fs/fuse/virtio_fs.c b/