Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-22 Thread Willem de Bruijn
Michael S. Tsirkin wrote: > On Wed, Feb 22, 2023 at 10:14:21AM -0500, Willem de Bruijn wrote: > > Either including the link that Michael shared or quoting the relevant > > part verbatim in the commit message would help, thanks. > > > > Thinking it over, my main concern is that the prescriptive sec

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-22 Thread Michael S. Tsirkin
On Wed, Feb 22, 2023 at 10:14:21AM -0500, Willem de Bruijn wrote: > Either including the link that Michael shared or quoting the relevant > part verbatim in the commit message would help, thanks. > > Thinking it over, my main concern is that the prescriptive section in > the spec does not state wh

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-22 Thread Willem de Bruijn
Jiri Pirko wrote: > Tue, Feb 21, 2023 at 05:12:33PM CET, willemdebruijn.ker...@gmail.com wrote: > >Jiri Pirko wrote: > >> Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.ker...@gmail.com wrote: > >> >Jiri Pirko wrote: > >> >> From: Jiri Pirko > >> >> > >> >> Virtio spec introduced a feature V

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
Tue, Feb 21, 2023 at 06:21:16PM CET, m...@redhat.com wrote: >On Tue, Feb 21, 2023 at 03:47:41PM +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when >> set implicates that the driver provides the exact size of the header. > >OK b

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
Tue, Feb 21, 2023 at 05:12:33PM CET, willemdebruijn.ker...@gmail.com wrote: >Jiri Pirko wrote: >> Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.ker...@gmail.com wrote: >> >Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> >> >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which w

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2023 at 04:39:32PM +0100, Jiri Pirko wrote: > Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.ker...@gmail.com wrote: > >Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > >> set implicates that the driver

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2023 at 03:47:41PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > set implicates that the driver provides the exact size of the header. OK but I feel this is not the important point. The important points are

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Willem de Bruijn
Jiri Pirko wrote: > Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.ker...@gmail.com wrote: > >Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > >> set implicates that the driver provides the exact size of the header. > >

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.ker...@gmail.com wrote: >Jiri Pirko wrote: >> From: Jiri Pirko >> >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when >> set implicates that the driver provides the exact size of the header. >> >> Quoting the original virti

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Alvaro Karsz
> > From: Jiri Pirko > > Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > set implicates that the driver provides the exact size of the header. > > Quoting the original virtio spec: > "hdr_len is a hint to the device as to how much of the header needs to > be kept to copy i

RE: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Parav Pandit via Virtualization
> From: Jiri Pirko > Sent: Tuesday, February 21, 2023 9:48 AM > > From: Jiri Pirko > > Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > set implicates that the driver provides the exact size of the header. > > Quoting the original virtio spec: > "hdr_len is a hint to

RE: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Willem de Bruijn
Jiri Pirko wrote: > From: Jiri Pirko > > Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > set implicates that the driver provides the exact size of the header. > > Quoting the original virtio spec: > "hdr_len is a hint to the device as to how much of the header needs to >

[patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
From: Jiri Pirko Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when set implicates that the driver provides the exact size of the header. Quoting the original virtio spec: "hdr_len is a hint to the device as to how much of the header needs to be kept to copy into each packet"