Re: [webkit-dev] WebKit Transition to Git

> On Oct 13, 2020, at 2:37 PM, Konstantin Tokarev wrote: > > > > 13.10.2020, 22:33, "Maciej Stachowiak" : >>> On Oct 2, 2020, at 10:59 AM, Michael Catanzaro >>> wrote: >>> >>> On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand wrote: Would you also consider preventing merge commits

Re: [webkit-dev] WebKit Transition to Git

According to this Jonathan's bugzilla comment, a new git repository will be reconstructed. https://bugs.webkit.org/show_bug.cgi?id=214957#c12 It'd be nice if commit-qu...@webkit.org is replaced by real authors. ___ webkit-dev mailing list webkit-dev@list

Re: [webkit-dev] WebKit Transition to Git

On Fri, Oct 16, 2020 at 4:49 AM Konstantin Tokarev wrote: > > > Why would you want to do that? > > I think rich text in comments is evil, for the same reasons as HTML e-mail. > > Yes, with markdown you won't often see unreadably colored text (what happens > with HTML e-mail), but still there is pr

Re: [webkit-dev] WebKit Transition to Git

14.10.2020, 16:52, "Tetsuharu OHZEKI" : > I feel from this discussion that everybody has their own best way and > we’re tackling to resolve them at once in this migration process. > I also feel it’s a bit difficult to conclude something. > > FWIW, I would like to write some my problems about the

Re: [webkit-dev] WebKit Transition to Git

> The original goal mentionned at the start of the thread was encouraging > more people to contribute to WebKit. From that side, what's important is > trying to retain a patch submission workflow that's standardized. That can > be github/gitlab style pull requests, or Gerrit which is a different on

Re: [webkit-dev] WebKit Transition to Git (Merge Workflows)

To point something out with the squash merge vs rebase merge policies, we will definitely be enforcing squash merges at least initially because rebase merges require some extra EWS and commit-queue infrastructure. Recall that WebKit does regression testing for every commit, even if these commit

Re: [webkit-dev] WebKit Transition to Git

> 3. Changelog > I don’t feel it's a big problem to write ChangeLog file. > Of course, this is tired thing but I don’t have a strong alternative > after reading this thread. > > However the current `prepare-Changelog` script does not fit with a > branch -based workflow on Git, I feel. There is a r

Re: [webkit-dev] WebKit Transition to Git

I feel from this discussion that everybody has their own best way and we’re tackling to resolve them at once in this migration process. I also feel it’s a bit difficult to conclude something. FWIW, I would like to write some my problems about the current workflow to help figure out what is a probl

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev wrote: > > > 13.10.2020, 22:33, "Maciej Stachowiak" : > >> On Oct 2, 2020, at 10:59 AM, Michael Catanzaro > wrote: > >> > >> On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand > wrote: > >>> Would you also consider preventing merge commits in

Re: [webkit-dev] WebKit Transition to Git

On 14/10/2020 03:12, Ken Russell wrote: > On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev > wrote: > 1. Workflow 1 - "Squash merge" policy > > * Whole PR is considered to be a single atomic change of WebKit > source tree. If work is supposed to be lande

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 13, 2020 at 4:12 PM Konstantin Tokarev wrote: > > > > 14.10.2020, 02:01, "Ryosuke Niwa" : > > On Tue, Oct 13, 2020 at 3:53 PM Konstantin Tokarev > > wrote: > >> 14.10.2020, 01:45, "Ryosuke Niwa" : > >> > On Tue, Oct 13, 2020 at 3:40 PM Konstantin Tokarev > >> wrote: > >> >> 14.1

Re: [webkit-dev] WebKit Transition to Git

14.10.2020, 02:01, "Ryosuke Niwa" : > On Tue, Oct 13, 2020 at 3:53 PM Konstantin Tokarev wrote: >>  14.10.2020, 01:45, "Ryosuke Niwa" : >>  > On Tue, Oct 13, 2020 at 3:40 PM Konstantin Tokarev >> wrote: >>  >> 14.10.2020, 01:30, "Ryosuke Niwa" : >>  >> > On Tue, Oct 13, 2020 at 2:37 PM Konstan

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 13, 2020 at 3:53 PM Konstantin Tokarev wrote: > > > 14.10.2020, 01:45, "Ryosuke Niwa" : > > On Tue, Oct 13, 2020 at 3:40 PM Konstantin Tokarev > > wrote: > >> 14.10.2020, 01:30, "Ryosuke Niwa" : > >> > On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev > >> wrote: > >> >> 13.10.

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 13, 2020 at 3:19 PM Michael Catanzaro wrote: > > Detailed descriptions are very important. I don't think function-level > changelogs are; documenting changes in individual functions is > generally busywork to say what you can plainly see by just looking at > the diff. They certainly c

Re: [webkit-dev] WebKit Transition to Git

14.10.2020, 01:45, "Ryosuke Niwa" : > On Tue, Oct 13, 2020 at 3:40 PM Konstantin Tokarev wrote: >>  14.10.2020, 01:30, "Ryosuke Niwa" : >>  > On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev >> wrote: >>  >> 13.10.2020, 22:33, "Maciej Stachowiak" : >>  >> >> On Oct 2, 2020, at 10:59 AM, Mich

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 13, 2020 at 3:40 PM Konstantin Tokarev wrote: > > 14.10.2020, 01:30, "Ryosuke Niwa" : > > On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev > > wrote: > >> 13.10.2020, 22:33, "Maciej Stachowiak" : > >> >> On Oct 2, 2020, at 10:59 AM, Michael Catanzaro > >> wrote: > >> >> > >>

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 13, 2020 at 3:19 PM Michael Catanzaro wrote: > > I suppose what I'm describing is Konstantin's Workflow 2, which is > overwhelmingly popular. > > On Tue, Oct 13, 2020 at 2:19 pm, Ryosuke Niwa wrote: > > Not squashing only helps if each commit can stand on its own. At that > > point, I

Re: [webkit-dev] WebKit Transition to Git

14.10.2020, 01:30, "Ryosuke Niwa" : > On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev wrote: >>  13.10.2020, 22:33, "Maciej Stachowiak" : >>  >> On Oct 2, 2020, at 10:59 AM, Michael Catanzaro >> wrote: >>  >> >>  >> On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand >> wrote: >>  >>> Would

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev wrote: > > > 13.10.2020, 22:33, "Maciej Stachowiak" : > >> On Oct 2, 2020, at 10:59 AM, Michael Catanzaro > >> wrote: > >> > >> On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand wrote: > >>> Would you also consider preventing merge commits in

Re: [webkit-dev] WebKit Transition to Git

I suppose what I'm describing is Konstantin's Workflow 2, which is overwhelmingly popular. On Tue, Oct 13, 2020 at 2:19 pm, Ryosuke Niwa wrote: Not squashing only helps if each commit can stand on its own. At that point, I'd suggest such a sequence of commits be made into multiple PRs inste

Re: [webkit-dev] WebKit Transition to Git

13.10.2020, 22:33, "Maciej Stachowiak" : >>  On Oct 2, 2020, at 10:59 AM, Michael Catanzaro wrote: >> >>  On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand wrote: >>>  Would you also consider preventing merge commits in order to keep a >>>  clean mainline branch? >> >>  Big +1 to blocking merge

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 13, 2020 at 1:57 PM Michael Catanzaro wrote: > > On Tue, Oct 13, 2020 at 12:32 pm, Maciej Stachowiak > wrote: > > I’m assuming your objection is to regular merges, but how do you > > feel about squash merges? Or do you think all PRs should be landed by > > rebasing? > > If we want a l

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 13, 2020 at 12:32 pm, Maciej Stachowiak wrote: I’m assuming your objection is to regular merges, but how do you feel about squash merges? Or do you think all PRs should be landed by rebasing? If we want a linear history (we do), all PRs ultimately have to land as fast-forward mer

Re: [webkit-dev] WebKit Transition to Git

> On Oct 3, 2020, at 9:42 AM, Tetsuharu OHZEKI > wrote: > >>> I think having to create an account on a website isn't the main thing >>> preventing people to contribute anyway? It's more about having to use >>> project-specific tools to prepare the patch for submission (in the case >>> of WebKi

Re: [webkit-dev] WebKit Transition to Git

> On Oct 2, 2020, at 10:59 AM, Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand wrote: >> Would you also consider preventing merge commits in order to keep a >> clean mainline branch? > > Big +1 to blocking merge commits. Merge commits in a huge project like WebKi

Re: [webkit-dev] WebKit Transition to Git

Adrian Perez de Castro , 2020-10-08 00:49 +0300: > ... > Also with Git{Hub,Lab} it's an annoyance that one has to go through the web > interface to create a “pull request”. But it’s not hard to create tooling that completely eliminates the need to ever use the GitHub web UI to create pull requests

Re: [webkit-dev] WebKit Transition to Git

On Tue, 06 Oct 2020 11:15:05 -0700 Jonathan Bedard wrote: > Seems like most large projects are using some sort of bot or action to solve > this problem: https://github.com/isaacs/github/issues/581 > . Wow, “there's a bot for that” seems to be the “the

Re: [webkit-dev] WebKit Transition to Git

Hi there, There is one more annoyance I am adding below Konstantin's list… On Tue, 06 Oct 2020 03:13:32 +0300 Konstantin Tokarev wrote: > 05.10.2020, 23:41, "Yusuke Suzuki" : > > I think security component is special in terms of how to handle it already > > (e.g. not posting a test with the pa

Re: [webkit-dev] WebKit Transition to Git

On Sun, 04 Oct 2020 02:00:02 +0300 Konstantin Tokarev wrote: > 03.10.2020, 21:49, "Adrien Destugues" : > > Yes that's why I didn't elaborate much. Whichever tool you pick, there > > will always be people unhappy about it. > > Right. For example, I have negative bias against GitLab, because this

Re: [webkit-dev] WebKit Transition to Git

Hello, On Fri, 02 Oct 2020 13:48:56 -0700 Ken Russell wrote: > Excited about this migration! One comment inline. > > On Fri, Oct 2, 2020 at 9:43 AM Jonathan Bedard wrote: > > > *Patches to Pull Requests* > > In the coming months, more automation will start using the git version of > > the rep

Re: [webkit-dev] WebKit Transition to Git

Hello, On Sun, 04 Oct 2020 01:57:56 -0700 Yusuke Suzuki wrote: > GitHub is planning to have review revisions in 2020/Q4. > So, when WebKit repository is migrated, we already have that in GitHub > builtin review tool :) > > https://github.com/github/roadmap/issues/54 >

Re: [webkit-dev] WebKit Transition to Git

Hi, On Tue, 06 Oct 2020 03:42:11 +0300 Konstantin Tokarev wrote: > 05.10.2020, 13:26, "Frédéric Wang" : > > One thing to take into account is that WebKit's repository is big and > > public GitHub/GitLab prevent creating large repository by default. This > > means it might not be possible for co

Re: [webkit-dev] WebKit Transition to Git

Hello, On Wed, 07 Oct 2020 04:17:45 +0300 Konstantin Tokarev wrote: > 06.10.2020, 18:03, "Michael Catanzaro" : > > On Tue, Oct 6, 2020 at 3:13 am, Konstantin Tokarev > > wrote: > >>  1. Sub-par support for linking issues to each other > >>  -

Re: [webkit-dev] WebKit Transition to Git

On Wed, 07 Oct 2020 08:58:58 -0500 Michael Catanzaro wrote: > On Wed, Oct 7, 2020 at 4:17 am, Konstantin Tokarev > wrote: > > BTW, could you estimate how many of users which have provided > > meaningful bug reports were directed to bugs.webkit.org but never > > made it? > > A lot. I'd say may

Re: [webkit-dev] WebKit Transition to Git

On Wed, Oct 7, 2020 at 4:17 am, Konstantin Tokarev wrote: BTW, could you estimate how many of users which have provided meaningful bug reports were directed to bugs.webkit.org but never made it? A lot. I'd say maybe about half make it upstream. That's OK. We don't have time to fix everything

Re: [webkit-dev] WebKit Transition to Git

> On 6 Oct 2020, at 18:32, Yusuke Suzuki wrote: > > I don’t think this works. People in twitter etc. do not file a bug even if it > is requested by us not because Bugzilla has technical difficulties, just > because “This is not GitHub”. > So, moving to GitLab / making Bugzilla easy do not sol

Re: [webkit-dev] WebKit Transition to Git

06.10.2020, 18:03, "Michael Catanzaro" : > On Tue, Oct 6, 2020 at 3:13 am, Konstantin Tokarev > wrote: >>  1. Sub-par support for linking issues to each other >>   >> >>  Traditional bug tracking systems (like Bugzilla or JIRA) have sup

Re: [webkit-dev] WebKit Transition to Git

06.10.2020, 20:32, "Yusuke Suzuki" : >>  On Oct 5, 2020, at 5:13 PM, Konstantin Tokarev wrote: >> >>  05.10.2020, 23:41, "Yusuke Suzuki" : >>>  I think security component is special in terms of how to handle it already >>> (e.g. not posting a test with the patch etc.) >>>  To me, handling non-s

Re: [webkit-dev] WebKit Transition to Git

Seems like most large projects are using some sort of bot or action to solve this problem: https://github.com/isaacs/github/issues/581 . Jonathan > On Oct 6, 2020, at 11:07 AM, Michael Catanzaro wrote: > > On Wed, Oct 7, 2020 at 2:22 am, Tetsuharu

Re: [webkit-dev] WebKit Transition to Git

On Wed, Oct 7, 2020 at 2:22 am, Tetsuharu OHZEKI wrote: If we move to GitHub Issue, compared to bugzilla, that does not have "component watching". (I don't know the case of GitLab's Issue) We only can watch all issues or not for the repository. Oh dear. I had assumed that you could easily subs

Re: [webkit-dev] WebKit Transition to Git

> On Oct 5, 2020, at 5:13 PM, Konstantin Tokarev wrote: > > > > 05.10.2020, 23:41, "Yusuke Suzuki" : >> I think security component is special in terms of how to handle it already >> (e.g. not posting a test with the patch etc.) >> To me, handling non-security issues in GitHub and security is

Re: [webkit-dev] WebKit Transition to Git

I'm not sure about how many people in WebKit watches creating or updating bugs, but I'd like to mention that because this might be a regression if we move from bugzilla. If we move to GitHub Issue, compared to bugzilla, that does not have "component watching". (I don't know the case of GitLab's Is

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 6, 2020 at 3:13 am, Konstantin Tokarev wrote: 1. Sub-par support for linking issues to each other Traditional bug tracking systems (like Bugzilla or JIRA) have support of "related" or "linked" issues. Most important re

Re: [webkit-dev] WebKit Transition to Git

06.10.2020, 12:40, "Konstantin Tokarev" : > 06.10.2020, 11:42, "Ryosuke Niwa" : >>  On Mon, Oct 5, 2020 at 5:13 PM Konstantin Tokarev wrote: >>> >>>   1. Sub-par support for linking issues to each other >>>    >>> >>>   Traditional bug

Re: [webkit-dev] WebKit Transition to Git

06.10.2020, 11:42, "Ryosuke Niwa" : > On Mon, Oct 5, 2020 at 5:13 PM Konstantin Tokarev wrote: >>  05.10.2020, 23:41, "Yusuke Suzuki" : >>  > I think security component is special in terms of how to handle it >> already (e.g. not posting a test with the patch etc.) >>  > To me, handling non-sec

Re: [webkit-dev] WebKit Transition to Git

On Mon, Oct 5, 2020 at 5:13 PM Konstantin Tokarev wrote: > > > 05.10.2020, 23:41, "Yusuke Suzuki" : > > I think security component is special in terms of how to handle it already > > (e.g. not posting a test with the patch etc.) > > To me, handling non-security issues in GitHub and security issue

Re: [webkit-dev] WebKit Transition to Git

05.10.2020, 13:26, "Frédéric Wang" : > One thing to take into account is that WebKit's repository is big and > public GitHub/GitLab prevent creating large repository by default. This > means it might not be possible for contributors to actually fork > WebKit's repository on their account and then

Re: [webkit-dev] WebKit Transition to Git

05.10.2020, 17:19, "Robert Ma" : > On Mon, Oct 5, 2020 at 6:22 AM Frédéric Wang wrote: >> One thing to take into account is that WebKit's repository is big and >> public GitHub/GitLab prevent creating large repository by default. This >> means it might not be possible for contributors to actuall

Re: [webkit-dev] WebKit Transition to Git

05.10.2020, 23:41, "Yusuke Suzuki" : > I think security component is special in terms of how to handle it already > (e.g. not posting a test with the patch etc.) > To me, handling non-security issues in GitHub and security issues in Bugzilla > is OK. > By nature, security issues are not open. S

Re: [webkit-dev] WebKit Transition to Git

I think security component is special in terms of how to handle it already (e.g. not posting a test with the patch etc.) To me, handling non-security issues in GitHub and security issues in Bugzilla is OK. By nature, security issues are not open. Since one of our motivation of moving to GitHub i

Re: [webkit-dev] WebKit Transition to Git

On Tue, Oct 6, 2020 at 12:40 AM Jonathan Bedard wrote: > > That's one solution, but even that is somewhat insufficient because we > don’t want to give someone access to every security issue just to give > access to a single one. One of the solutions we’ve discussed is to migrate > bugs component

Re: [webkit-dev] WebKit Transition to Git

On Mon, Oct 5, 2020 at 8:40 am, Jonathan Bedard wrote: That's one solution, but even that is somewhat insufficient because we don’t want to give someone access to every security issue just to give access to a single one. One of the solutions we’ve discussed is to migrate bugs component by comp

Re: [webkit-dev] WebKit Transition to Git [Identifiers and Merge Commits]

>> Monotonic Commit Identifiers >> Of great interest to Apple?s engineers has been retaining some kind >> of ordered tag we can use to refer to commits to make defending CI >> and bisection easier. We?ve developed a scheme for this that assigns >> commits an ordered identifier per-branch, outlined

Re: [webkit-dev] WebKit Transition to Git

> On Oct 2, 2020, at 5:05 PM, Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 09:43, Jonathan Bedard wrote: >> The biggest blocker we are aware of is managing security bugs, since the >> security advisory system used by GitHub is essentially the opposite of how >> WebKit security bugs wo

Re: [webkit-dev] WebKit Transition to Git

`git describe` is quite a bit less powerful, unfortunately. First, while the string coming from `git-describe` can be used in git commands, that’s only because it contains the abbreviated commit hash, which alone is sufficient to identify a commit. Second, such identifiers end up being pretty we

Re: [webkit-dev] WebKit Transition to Git

On 05/10/2020 16:15, Robert Ma wrote: > On Mon, Oct 5, 2020 at 6:22 AM Frédéric Wang > wrote: > > One thing to take into account is that WebKit's repository is big and > public GitHub/GitLab prevent creating large repository by default. > This > means it mi

Re: [webkit-dev] WebKit Transition to Git

> One thing to take into account is that WebKit's repository is big and > public GitHub/GitLab prevent creating large repository by default. This > means it might not be possible for contributors to actually fork > WebKit's repository on their account and then create a pull request > (which is the

Re: [webkit-dev] WebKit Transition to Git

On Mon, Oct 5, 2020 at 6:22 AM Frédéric Wang wrote: > One thing to take into account is that WebKit's repository is big and > public GitHub/GitLab prevent creating large repository by default. This > means it might not be possible for contributors to actually fork > WebKit's repository on their a

Re: [webkit-dev] WebKit Transition to Git

On 02/10/2020 18:43, Jonathan Bedard wrote: Hi all, This is great to hear! Several people have already made comments about things that I wanted to say, but I'd just to add my personal point of view... I've used both Mozilla's Phabricator and Chromium's Gerrit for patches/review, and I find both o

Re: [webkit-dev] WebKit Transition to Git

On Sun, Oct 4, 2020 at 2:41 PM Konstantin Tokarev wrote: > > 02.10.2020, 19:46, "Jonathan Bedard" : > > Monotonic Commit Identifiers > > Of great interest to Apple’s engineers has been retaining some kind of > > ordered tag we can use to refer to commits to make defending CI and > > bisection ea

Re: [webkit-dev] WebKit Transition to Git

02.10.2020, 19:46, "Jonathan Bedard" : > Monotonic Commit Identifiers > Of great interest to Apple’s engineers has been retaining some kind of > ordered tag we can use to refer to commits to make defending CI and bisection > easier. We’ve developed a scheme for this that assigns commits an orde

Re: [webkit-dev] WebKit Transition to Git

GitHub is planning to have review revisions in 2020/Q4. So, when WebKit repository is migrated, we already have that in GitHub builtin review tool :) https://github.com/github/roadmap/issues/54 Best regards, Yusuke > On Oct 3, 2020, at 5:18 PM, Mic

Re: [webkit-dev] WebKit Transition to Git

On Sat, Oct 3, 2020 at 9:52 pm, Konstantin Tokarev wrote: If I understand correctly, there is no way in GitHub UI to see a difference between patches submitted at step 1 and step 3. It's still possible to see old version of patches if you navigate to old commit hash, but that's not for long as

Re: [webkit-dev] WebKit Transition to Git

03.10.2020, 21:49, "Adrien Destugues" : > Yes that's why I didn't elaborate much. Whichever tool you pick, there > will always be people unhappy about it. Right. For example, I have negative bias against GitLab, because this company have bought its open source competitor (Gitorious, which was qu

Re: [webkit-dev] WebKit Transition to Git

02.10.2020, 23:17, "Jonathan Bedard" : >>  On Oct 2, 2020, at 11:47 AM, Tetsuharu OHZEKI >> wrote: >> >>  Hi Jonathan, >> >>  As a contributor, I hear this change positively and I'm looking >>  forward to transition to a new process. >> >>  I have some questions and feelings: >> >>  1. Will we

Re: [webkit-dev] WebKit Transition to Git

03.10.2020, 05:18, "Ryosuke Niwa" : > On Fri, Oct 2, 2020 at 5:06 PM Michael Catanzaro wrote: >>  On Fri, Oct 2, 2020 at 13:48, Ken Russell wrote: >>  > Github's code review UI has a couple of feature gaps in my opinion. >>  > It's difficult to look at earlier versions of the pull request, in >

Re: [webkit-dev] WebKit Transition to Git

On Sat, Oct 03, 2020 at 08:43:40PM +0300, Konstantin Tokarev wrote: > >>  Gerrit accepts GitHub and other OAuth providers as well, so that's not a > >>  problem. We have been using this for Haiku code reviews for a few years > >>  now, and interestingly we got some complaints from people who don't

Re: [webkit-dev] WebKit Transition to Git

03.10.2020, 20:40, "Michael Catanzaro" : > On Sat, Oct 3, 2020 at 3:16 am, Ryosuke Niwa wrote: >>  I've gotta say I'm very much concerned about getting rid of change >>  logs when we move to Git. We put a lot of useful information about >>  what was causing the bug, how we fixed it, and why we f

Re: [webkit-dev] WebKit Transition to Git

03.10.2020, 19:34, "Alexey Proskuryakov" : >>  3 окт. 2020 г., в 2:24 AM, Adrien Destugues >> написал(а): >> >>  On Fri, Oct 02, 2020 at 07:05:21PM -0500, Michael Catanzaro wrote:  I realize that Gerrit might not integrate at all with hosting the repo  on Github, but has any thought b

Re: [webkit-dev] WebKit Transition to Git

On Sat, Oct 3, 2020 at 3:16 am, Ryosuke Niwa wrote: I've gotta say I'm very much concerned about getting rid of change logs when we move to Git. We put a lot of useful information about what was causing the bug, how we fixed it, and why we fixed the way we did in a change log. I've seen a few pr

Re: [webkit-dev] WebKit Transition to Git

03.10.2020, 19:46, "Tetsuharu OHZEKI" : >>>  I think having to create an account on a website isn't the main thing >>>  preventing people to contribute anyway? It's more about having to use >>>  project-specific tools to prepare the patch for submission (in the case >>>  of WebKit, having to writ

Re: [webkit-dev] WebKit Transition to Git

>> I think having to create an account on a website isn't the main thing >> preventing people to contribute anyway? It's more about having to use >> project-specific tools to prepare the patch for submission (in the case >> of WebKit, having to write the commit message in the Changelog file, for >>

Re: [webkit-dev] WebKit Transition to Git

> 3 окт. 2020 г., в 2:24 AM, Adrien Destugues > написал(а): > > On Fri, Oct 02, 2020 at 07:05:21PM -0500, Michael Catanzaro wrote: >>> I realize that Gerrit might not integrate at all with hosting the repo >>> on Github, but has any thought been given to this aspect of the >>> transition? >>

Re: [webkit-dev] WebKit Transition to Git

On Sat, Oct 3, 2020 at 2:25 AM Adrien Destugues wrote: > > On Fri, Oct 02, 2020 at 07:05:21PM -0500, Michael Catanzaro wrote: > > > I realize that Gerrit might not integrate at all with hosting the repo > > > on Github, but has any thought been given to this aspect of the > > > transition? > > > >

Re: [webkit-dev] WebKit Transition to Git

On Fri, Oct 02, 2020 at 07:05:21PM -0500, Michael Catanzaro wrote: > > I realize that Gerrit might not integrate at all with hosting the repo > > on Github, but has any thought been given to this aspect of the > > transition? > > That sounds like it would be a significant barrier to contribution,

Re: [webkit-dev] WebKit Transition to Git

> Github's code review UI has a couple of feature gaps in my opinion. It's > difficult to look at earlier versions of the pull request, in particular to > verify that issues found during code review have been fixed. I remember it > also being difficult to figure out whether all comments on earlier

Re: [webkit-dev] WebKit Transition to Git

On Fri, Oct 2, 2020 at 5:06 PM Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 13:48, Ken Russell wrote: > > Github's code review UI has a couple of feature gaps in my opinion. > > It's difficult to look at earlier versions of the pull request, in > > particular to verify that issues found du

Re: [webkit-dev] WebKit Transition to Git

On Fri, Oct 2, 2020 at 09:43, Jonathan Bedard wrote: The biggest blocker we are aware of is managing security bugs, since the security advisory system used by GitHub is essentially the opposite of how WebKit security bugs work. Moving to GitHub Issues, if it happens, will be the last part of t

Re: [webkit-dev] WebKit Transition to Git

On Fri, Oct 2, 2020 at 13:48, Ken Russell wrote: Github's code review UI has a couple of feature gaps in my opinion. It's difficult to look at earlier versions of the pull request, in particular to verify that issues found during code review have been fixed. I remember it also being difficult

Re: [webkit-dev] WebKit Transition to Git

> On Oct 2, 2020, at 11:47 AM, Tetsuharu OHZEKI > wrote: > > Hi Jonathan, > > As a contributor, I hear this change positively and I'm looking > forward to transition to a new process. > > I have some questions and feelings: > > 1. Will we continue to use https://trac.webkit.org/wiki after m

Re: [webkit-dev] WebKit Transition to Git

On Fri, Oct 2, 2020 at 11:00 AM Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand > wrote: > > Would you also consider preventing merge commits in order to keep a > > clean mainline branch? > > Big +1 to blocking merge commits. Merge commits in a huge project like > We

Re: [webkit-dev] WebKit Transition to Git

Hi Jonathan, As a contributor, I hear this change positively and I'm looking forward to transition to a new process. I have some questions and feelings: 1. Will we continue to use https://trac.webkit.org/wiki after moving to something to host the Git repository? This is just my curiosity. 2.

Re: [webkit-dev] WebKit Transition to Git

On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand wrote: Would you also consider preventing merge commits in order to keep a clean mainline branch? Big +1 to blocking merge commits. Merge commits in a huge project like WebKit would make commit archaeology very frustrating. (I assume this is i

Re: [webkit-dev] WebKit Transition to Git

This is great! On Fri, 2020-10-02 at 09:43 -0700, Jonathan Bedard wrote: > Hello WebKit Contributors, > > This year, Apple would like to push WebKit’s source code management > off of Subversion and onto git. Our rationale for this is the rest of > the industry has settled on git as their source c

[webkit-dev] WebKit Transition to Git

Hello WebKit Contributors, This year, Apple would like to push WebKit’s source code management off of Subversion and onto git. Our rationale for this is the rest of the industry has settled on git as their source code management solution. We’re also interested in moving to a hosted Git solutio