Re: [Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/unread_read_outbox_messages into lp:widelands-website

2016-11-28 Thread kaputtnik
Funktioniert :-) Ist nur ein bisschen unklar warum das Kursiv dargestellt wird. Evtll einen Tooltip per title="Recipient hasn't read this post yet." einfügen? Gibt ne kleine Erklärung... -- https://code.launchpad.net/~janus-jhor/widelands-website/unread_read_outbox_messages/+merge/311994 Your t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_economy_window into lp:widelands

2016-11-28 Thread GunChleoc
About the window handling for economy merge, as I see it, we have 3 options: 1. Have the boolean in Economy like in the current implementation. 2. InteractiveBase::unique_windows(), with InteractiveBase subscribing to the note 3. InteractiveBase::unique_windows(), with EconomyWindow reading the

[Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/unread_read_outbox_messages into lp:widelands-website

2016-11-28 Thread janus
janus has proposed merging lp:~janus-jhor/widelands-website/unread_read_outbox_messages into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~janus-jhor/widelands-website/unread_read_outbox_messages/+merge/311994

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler_warnings_201611 into lp:widelands

2016-11-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 1629. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/177405601. Appveyor build 1467. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_compiler_w

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 1660. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/179421689. Appveyor build 1500. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_casern_wor

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1624216-horsepocalypse into lp:widelands

2016-11-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 1607. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/175655541. Appveyor build 1445. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_162421

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fsmenu_fullscreen_3_mapselect into lp:widelands

2016-11-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 1610. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/175973070. Appveyor build 1448. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fsmenu_ful

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1426465-scenario-timings into lp:widelands

2016-11-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 1621. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/176654850. Appveyor build 1459. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_142646

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler_warnings_201611 into lp:widelands

2016-11-28 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: ('The read operation timed out',) -- https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widela

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_economy_window into lp:widelands

2016-11-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 1644. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/178236731. Appveyor build 1482. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_notificati

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlimages_rework into lp:widelands-website

2016-11-28 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/wlimages_rework into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1523256 in Widelands Website: "Uploading images with uppercase letters cause server error" https://bugs.l

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-28 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: ('The read operation timed out',) -- https://code.launchpad.net/~widelands-dev/widelands/casern_workersqueue/+merge/309763 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/c

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1624216-horsepocalypse into lp:widelands

2016-11-28 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: ('The read operation timed out',) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1624216-horsepocalypse/+merge/310221 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/wide

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fsmenu_fullscreen_3_mapselect into lp:widelands

2016-11-28 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: ('The read operation timed out',) -- https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_3_mapselect/+merge/310744 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/w

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1426465-scenario-timings into lp:widelands

2016-11-28 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: ('The read operation timed out',) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1426465-scenario-timings/+merge/39 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/wi

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler_warnings_201611 into lp:widelands

2016-11-28 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: ('The read operation timed out',) -- https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widela

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_economy_window into lp:widelands

2016-11-28 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: ('The read operation timed out',) -- https://code.launchpad.net/~widelands-dev/widelands/notifications_economy_window/+merge/311572 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/notifications

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler_warnings_201611 into lp:widelands

2016-11-28 Thread Notabilis
I know, I shouldn't, but anyway: I only looked at the diff and most of it looks good. I do not like the change in network.h, though. I am not sure about it, but isn't the constructor taking the address of a temporary? -- https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_20161

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-28 Thread Notabilis
Thank you both for looking at this. When looking sooner in the travis log I found these lines: test/maps/plain.wmf/scripting/test_casern.lua ... Running Widelands ... *** Error in `build/src/widelands': double free or corruption (!prev): 0x0670d1e0 *** FAIL So you are right SirVer: A

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/mac_os_x_build_fixes into lp:widelands

2016-11-28 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/mac_os_x_build_fixes into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/mac_os_x_build_fixes/+merge/311802 -- Your team Widelands Developers is subscr

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-28 Thread SirVer
Gun pinged me to take a look at this. First impression: Looking over the travis output there is clearly a bug in the code somewhere. It is flaky as it sometimes succeeds and sometimes fails. There is no correlation to the compiler (gcc/clang both are flaky) or the type of build (debug/release).

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mac_os_x_build_fixes into lp:widelands

2016-11-28 Thread SirVer
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/mac_os_x_build_fixes/+merge/311802 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mac_os_x_build_fixes. ___ Mailing list: https://launchpad.net/~

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_seafaring_split into lp:widelands

2016-11-28 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/ai_seafaring_split into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_split/+merge/311544 -- Your team Widelands Developers is subscribed

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/mac_os_x_build_fixes into lp:widelands

2016-11-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 1657. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/179369228. Appveyor build 1497. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_mac_os_x_b

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_seafaring_split into lp:widelands

2016-11-28 Thread GunChleoc
Correct - you would need to do more refactoring before you can split off a library in CMake. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_split/+merge/311544 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_seafaring_sp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mac_os_x_build_fixes into lp:widelands

2016-11-28 Thread GunChleoc
Review: Approve Tested and working on Ubuntu. -- https://code.launchpad.net/~widelands-dev/widelands/mac_os_x_build_fixes/+merge/311802 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mac_os_x_build_fixes. ___ Mailin

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/animation_scaling into lp:widelands

2016-11-28 Thread GunChleoc
Fixed in trunk. -- https://code.launchpad.net/~widelands-dev/widelands/animation_scaling/+merge/310718 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/animation_scaling. ___ Mailing list: https://launchpad.net/~widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-28 Thread GunChleoc
As far as I understand the log output of the failed tests and the Python script, widelands itself exits with a return code != 0 - maybe a new assert in the code itself somewhere is causing this, rather than the test code? -- https://code.launchpad.net/~widelands-dev/widelands/casern_workersqueue

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mac_os_x_build_fixes into lp:widelands

2016-11-28 Thread SirVer
Thanks for the review!! I merged trunk and repushed. I want to see travis green before merging this. -- https://code.launchpad.net/~widelands-dev/widelands/mac_os_x_build_fixes/+merge/311802 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mac_os_x_build_fixes.