Code LGTM so far - will have to look into the saveloading thing.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1191295-no-seafaring-builder/+merge/315525
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1191295-no-seafaring-b
Notabilis has proposed merging
lp:~widelands-dev/widelands/bug-1191295-no-seafaring-builder into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1191295 in widelands: "Seafaring: builder not listed in expedition list
in port"
https://bugs.launchpad.
@kaputtnik: I found no way of explicitly closing the files that works while
keeping the wrapper functions. All I get is errors, even .close() won't work.
I also find the code to include the file utils script ridiculously ugly, do you
know a more elegant way of doing that?
@Haso50: fix_formattin
The proposal to merge lp:~widelands-dev/widelands/build_docs_on_travis into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/build_docs_on_travis/+merge/315431
--
Your team Widelands Developers is subs
I am giving up on this branch. We'd require sphinx 1.4 to build our docs, but
travis only has 1.2. I am not willing to put in more time to fix this.
--
https://code.launchpad.net/~widelands-dev/widelands/build_docs_on_travis/+merge/315431
Your team Widelands Developers is subscribed to branch
l
Review: Approve test, use
Testing is all fine
update_copyright_script$ ./utils/update_copyright.py
Usage: update_copyright.py
brombeere:update_copyright_script $ ./utils/update_copyright.py 2017
Updating copyright year to: 2017 ... lots of dots ... done.
brombeere:update_copyright_script $ bzr
Continuous integration builds have changed state:
Travis build 1866. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/194739060.
Appveyor build 1703. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_build_doc
Continuous integration builds have changed state:
Travis build 1865. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/194738386.
Appveyor build 1702. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_switch_dir
Have you tried modifying the parameters in map view.cc? Maybe you find better
ones.
> Am 24.01.2017 um 09:18 schrieb GunChleoc :
>
> Review: Approve
>
> Gave it a quick spin - my visual cortex can handle this version. So, it's
> either this, or jump.
> --
> https://code.launchpad.net/~widela
Maybe a silly question: Looks like the files are opened but not closed?
Python programmers using mostly the 'with' statement when handling files, which
automatically closes files. See the last example in
https://docs.python.org/2/tutorial/inputoutput.html#methods-of-file-objects
--
https://co
Review: Approve
Gave it a quick spin - my visual cortex can handle this version. So, it's
either this, or jump.
--
https://code.launchpad.net/~widelands-dev/widelands/switch_direction/+merge/315432
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/switch_directi
Continuous integration builds have changed state:
Travis build 1864. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/194595810.
Appveyor build 1700. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_glossary_c
The proposal to merge lp:~widelands-dev/widelands/bug-1625502-tips-in-help into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1625502-tips-in-help/+merge/312969
--
Your team Widelands Developers i
Review: Approve
Code LGTM. We should have branches ready to fix the errors before merging
though, because this will make Travis unusable for all other branches in the
meantime.
--
https://code.launchpad.net/~widelands-dev/widelands/build_docs_on_travis/+merge/315431
Your team Widelands Develope
I'll give it a spin to see how it feels. If we can't get this to work without
making me motion sick, we'll have to keep the smooth scrolling for the
scenarios only and simply jump like we used to. The way it is now, the feature
is blocking me from using the minimap.
--
https://code.launchpad.ne
Thanks for the review - added replies to your comments.
Diff comments:
>
> === added file 'utils/file_utils.py'
> --- utils/file_utils.py 1970-01-01 00:00:00 +
> +++ utils/file_utils.py 2017-01-23 12:35:34 +
> @@ -0,0 +1,32 @@
> +#!/usr/bin/env python
> +# -*- coding: utf-8 -
Ups, forgot that one.
--
https://code.launchpad.net/~widelands-dev/widelands-website/post_django1_8_cleanup/+merge/315301
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-d
Let's get this branch in so we can add the content changes in another branch.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1625502-tips-in-help/+merge/312969
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1625502-tips-in-help.
18 matches
Mail list logo
