Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

2007-05-12 Thread James Hawkins
On 5/12/07, Andrew Riedi <[EMAIL PROTECTED]> wrote: Perhaps give an example? "Please include a one-liner in your email stating what you did. Example: changelog: I fixed function X that was causing bug Y. Note: There is no need to edit the ChangeLog file itself." How is the above? The only

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

2007-05-12 Thread Andrew Riedi
Perhaps give an example? "Please include a one-liner in your email stating what you did. Example: changelog: I fixed function X that was causing bug Y. Note: There is no need to edit the ChangeLog file itself." How is the above? -- Andrew Riedi

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

2007-05-12 Thread Tony Lambregts
Vincent Fourmond wrote: > Stefan Dösinger wrote: >> also you do not have to >> modify the ChangeLog file, git does that automatically when AJ commits the >> patch. > > I just followed the instructions on > http://winehq.org/site/sending_patches. If they are not correct, please > update this p

Re: shell32: check result of HeapAlloc()

2007-05-12 Thread James Hawkins
On 5/12/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: --- wine-0.9.37-orig/dlls/shell32/folders.c 2007-05-12 22:53:06.0 + +++ wine-0.9.37/dlls/shell32/folders.c 2007-05-13 00:17:00.0 + @@ -81,11 +81,15 @@ IExtractIconW* IExtractIconW_Constructor TRACE("%p

Re: msi: undo RegisterProduct/PublishProduct

2007-05-12 Thread Misha Koshelev
On Sat, 2007-05-12 at 16:31 -0500, James Hawkins wrote: > On 5/12/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: > > Hi, > > > > I am starting to write some automation conformance tests for things that > > I could check only after a package has been installed (and before it was > > removed) like Pro

Re: Internet explorer not detected

2007-05-12 Thread Tom Spear
On 5/12/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > really "%SYSTEMDRIVE%\Program Files\Internet Explorer", right? I > don't really feel sorry for apps that assume everything is running "Program Files" isn't hardcoded either, like on my German locale its "Programme". Which would be done a

Re: msi: undo RegisterProduct/PublishProduct

2007-05-12 Thread James Hawkins
On 5/12/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: Hi, I am starting to write some automation conformance tests for things that I could check only after a package has been installed (and before it was removed) like ProductInfo and RelatedProducts. I've added the install functionality into the

msi: undo RegisterProduct/PublishProduct

2007-05-12 Thread Misha Koshelev
Hi, I am starting to write some automation conformance tests for things that I could check only after a package has been installed (and before it was removed) like ProductInfo and RelatedProducts. I've added the install functionality into the conformance test, and it works beautifully on Windows,

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

2007-05-12 Thread Vincent Fourmond
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stefan Dösinger wrote: > Am Samstag 12 Mai 2007 15:00 schrieb Vincent Fourmond: >> (IDirectDrawSurfaceImpl_SetClipper): fixes segfault at HMMIV startup. >> --- >> ChangeLog|6 ++ >> dlls/ddraw/surface.c |5 +++-- >> 2 files cha

Re: PATCH - implement LockWorkStation using xdg-screensaver

2007-05-12 Thread Steven Edwards
Hi Hans, On 5/12/07, Hans Leidekker <[EMAIL PROTECTED]> wrote: How about the following patch? I added an option --lock to wineboot which does an execvp using the Unix search path. LockWorkStation then calls CreateProcess on "wineboot --lock", analogous to what ExitWindowsEx does. Thanks a lot.

Re: PATCH - implement LockWorkStation using xdg-screensaver

2007-05-12 Thread Steven Edwards
Hi Hans, On 5/12/07, Hans Leidekker <[EMAIL PROTECTED]> wrote: How about the following patch? I added an option --lock to wineboot which does an execvp using the Unix search path. LockWorkStation then calls CreateProcess on "wineboot --lock", analogous to what ExitWindowsEx does. When running i

Re: [PATCH] no wined3ddevice - no surface

2007-05-12 Thread Marcus Meissner
On Sat, May 12, 2007 at 06:21:56PM +0200, Stefan Dösinger wrote: > Am Samstag 12 Mai 2007 16:20 schrieb Marcus Meissner: > > Hi, > > > > If wineD3DDevice is not set, than do return > > failure (and do not reference NULL ifaces). > Actually the ddraw object shouldn't be createable in the first place

Re: PATCH - implement LockWorkStation using xdg-screensaver

2007-05-12 Thread Stefan Dösinger
Am Samstag 12 Mai 2007 12:13 schrieb Steven Edwards: > Hi, > This patch was an attempt to implemented LockWorkStation using > xdg-screensaver. It works for my simple test app that calls the > function but my real world application Process Explorer ends up > hanging now rather than crashing and stil

Re: Small Direct3D milestone

2007-05-12 Thread Stefan Dösinger
Am Samstag 12 Mai 2007 00:02 schrieb Raymond Barbiero: > > >> continueing work on software or shader emulation of it. I considered > > >> vertex blending a somewhat academic feature. > > FYI, I get similar vertex blending errors playing Oblivion. Oblivion is a direct3d9 game which makes heavy use o

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c

2007-05-12 Thread Stefan Dösinger
Am Samstag 12 Mai 2007 15:00 schrieb Vincent Fourmond: > (IDirectDrawSurfaceImpl_SetClipper): fixes segfault at HMMIV startup. > --- > ChangeLog|6 ++ > dlls/ddraw/surface.c |5 +++-- > 2 files changed, 9 insertions(+), 2 deletions(-) Now that wined3d stores the clipper, th

Re: [PATCH] no wined3ddevice - no surface

2007-05-12 Thread Stefan Dösinger
Am Samstag 12 Mai 2007 16:20 schrieb Marcus Meissner: > Hi, > > If wineD3DDevice is not set, than do return > failure (and do not reference NULL ifaces). Actually the ddraw object shouldn't be createable in the first place without a wined3d device object. Or do you want to modify ddraw to do somet

Re: include: Include local not system sql.h header

2007-05-12 Thread Andrew Talbot
It looks like I needed to tell my linting tool to search the local include directory before searching the system one. -- Andy.

Re: PATCH - implement LockWorkStation using xdg-screensaver

2007-05-12 Thread Marcus Meissner
On Sat, May 12, 2007 at 06:13:42AM -0400, Steven Edwards wrote: > Hi, > This patch was an attempt to implemented LockWorkStation using > xdg-screensaver. It works for my simple test app that calls the > function but my real world application Process Explorer ends up > hanging now rather than crashi

include: Include local not system sql.h header

2007-05-12 Thread Andrew Talbot
I have just sent in a patch to use Wine's sql.h instead of the system one, because I noticed that the latter includes , which appears to redefine DWORD as unsigned long, based on its reckoning that the size of a long integer is four bytes on default platforms, whereas - with _MSC_VER undefined - DW

Fast events

2007-05-12 Thread Maarten Lankhorst
Hi all, Since I'm trying to improve on winmm's timing scheduling, the best improvement I can find is getting rid of the wineserver calls, they add a huge delay to the timer and that is bad for something that should sleep all the time to get better scheduling. I tried sending in a patch that used l

Re: Small Direct3D milestone

2007-05-12 Thread Vitaly Budovski
Martin Owens wrote: Woot, thank you so much! Stefan D�singer, is this a time to ask you for help getting the really really easy bug in X11DRV_DIB_MapColor, oh go on pretty please with sugar on top? http://bugs.winehq.org/show_bug.cgi?id=6670 It looks like a duplicate of http://bugs.winehq.or

Re: [PATCH] initialize pSurface, since we process it on failure

2007-05-12 Thread Stefan Dösinger
Am Samstag 12 Mai 2007 11:39 schrieb Marcus Meissner: > Hi, > > Not sure if we should perhaps not do the ICOM CAST magic on a failing > CreateSurface call here. > > But initializing pSurface to NULL also helps. The ICOM_CAST thing should set the output to NULL of the surface returned by ddraw7_Cre

Re: Small Direct3D milestone

2007-05-12 Thread Stefan Dösinger
Am Samstag 12 Mai 2007 06:12 schrieb Martin Owens: > Woot, thank you so much! > > Stefan Dösinger, is this a time to ask you for help getting the really > really easy bug in X11DRV_DIB_MapColor, oh go on pretty please with > sugar on top? > > http://bugs.winehq.org/show_bug.cgi?id=6670 I'm sorry, b

Re: Internet explorer not detected

2007-05-12 Thread Stefan Dösinger
> really "%SYSTEMDRIVE%\Program Files\Internet Explorer", right? I > don't really feel sorry for apps that assume everything is running "Program Files" isn't hardcoded either, like on my German locale its "Programme". pgpO4O12Z4czX.pgp Description: PGP signature

Re: Current behavior of netapi32-access tests on W2K3 and Vista

2007-05-12 Thread Kai Blin
On Friday 11 May 2007 20:08, Paul Vriens wrote: > Hi, > > Not so long ago some tests where added for NetUserAdd and friends. While > browsing I found that I have about 6 testuser home directories on W2K3 and > 4 on Vista (which is the amount of tests I ran on those platforms). Whoops, sorry about