Re: inetmib1(3/31): Add tests for SnmpExtensionInit

2008-06-25 Thread Paul Vriens
Juan Lang wrote: > --Juan > > These tests import snmpapi, which isn't available on win95. Do we need to cater for that and do LoadLibrary/GetProcAddress ? -- Cheers, Paul.

Re: shell32: iconcache.c: Add stub implementation for SHGetIconOverlayIndex[AW] (RESEND)

2008-06-25 Thread Zac Brown
Zac Brown wrote: > Add stub implementation for SHGetIconOverlayIndex[AW]. > > Mentioned in Bug 7447, though it does not seem to need a full > implementation yet. Since its documented in MSDN, may as well add the > stub implementation of it. > > > ---

Re: shell32: iconcache.c: Add stub implementation for SHGetIconOverlayIndex[AW]

2008-06-25 Thread Zac Brown
Zac Brown wrote: > Add stub implementation for SHGetIconOverlayIndex[AW]. > > --Zac > > > > > scratch this one.

Re: "remote" start/stop of relay/snoop output

2008-06-25 Thread Massimo
Massimo ha scritto: > Massimo ha scritto: >> Austin English ha scritto: >>> On Mon, Jun 23, 2008 at 5:57 PM, <[EMAIL PROTECTED]> wrote: I asked that question some years ago, and IIRC then it was not possible, so I resorted to add an external filter app in order to start/stop relays

Re: "remote" start/stop of relay/snoop output

2008-06-25 Thread Massimo
Massimo ha scritto: > Austin English ha scritto: >> On Mon, Jun 23, 2008 at 5:57 PM, <[EMAIL PROTECTED]> wrote: >>> I asked that question some years ago, and IIRC then it was not possible, >>> so I resorted to add an external filter app in order to start/stop >>> relays on an already running app.

Re: rasapi32: return an error for invalid paramaters

2008-06-25 Thread Austin English
On Wed, Jun 25, 2008 at 12:12 PM, Juan Lang <[EMAIL PROTECTED]> wrote: > Hi Austin, at the risk of getting flamed for discussing elementary C > here I'll give some feedback. Appreciate the help. I don't have any C experience, so this testcase was hacked together by looking at a few other testcases

Re: [1/3] wininet/tests: add InternetErrorDlg tests

2008-06-25 Thread James Hawkins
On Wed, Jun 25, 2008 at 11:00 AM, Alexander Morozov <[EMAIL PROTECTED]> wrote: > Changelog: > Add InternetErrorDlg tests > > I ran these tests on Win98 and WinXP > > From 687f7d365b97d1da95db222e5bd5bbdf5c62c76f Mon Sep 17 00:00:00 2001 > From: Alexander Morozov <[EMAIL PROTECTED]> > Date: Wed, 25

Re: richedit: fix failing EM_GETCHARFORMAT test on all platforms

2008-06-25 Thread Austin English
On Wed, Jun 25, 2008 at 10:51 AM, Alex Villací­s Lasso <[EMAIL PROTECTED]> wrote: > Default richedit font (System) in Windows causes native richedit to report > CFM_BOLD as always set, regardless of selection, or previous calls to > EM_SETCHARFORMAT. Switch to Courier New in order to see that riche

Re: rasapi32: return an error for invalid paramaters

2008-06-25 Thread Juan Lang
Hi Austin, at the risk of getting flamed for discussing elementary C here I'll give some feedback. +static void test_rasenum(void) +{ + +BOOL result; + Indentation and whitespace are a little funny here. + LPRASDEVINFO = sizeof(RASDEVINFO); This is a little confused. You've named a type

wininet: fix crash

2008-06-25 Thread Alexander Morozov
Changelog: fix InternetErrorDlg crash From 6ab5655ebe26611387c2586b06fad78c16de7239 Mon Sep 17 00:00:00 2001 From: Alexander Morozov <[EMAIL PROTECTED]> Date: Wed, 25 Jun 2008 19:05:40 +0400 Subject: [PATCH] wininet: fix crash --- dlls/wininet/dialogs.c |3 +++ dlls/wininet/tests/dialog

Re: Revert "winspool.drv: Make sure the printer driver registry entry exists.

2008-06-25 Thread Huw Davies
On Wed, Jun 25, 2008 at 11:28:35AM +0100, Huw Davies wrote: > On Wed, Jun 25, 2008 at 12:17:36AM +0200, Detlef Riekenberg wrote: > > On Di, 2008-06-24 at 10:25 -0700, Dan Kegel wrote: > > > Today I started getting a heap corruption and crash in localspl: > > > ... > > > Anyone know what's up with t

Re: rasapi32: return an error for invalid paramaters

2008-06-25 Thread Austin English
On Tue, Jun 24, 2008 at 4:55 PM, Austin English <[EMAIL PROTECTED]> wrote: > On Tue, Jun 24, 2008 at 3:55 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >> On Tue, Jun 24, 2008 at 3:47 PM, Austin English <[EMAIL PROTECTED]> wrote: >>> >> >> Changes like these are so simple that you really should go t

richedit: fix failing EM_GETCHARFORMAT test on all platforms

2008-06-25 Thread Alex Villací­s Lasso
Default richedit font (System) in Windows causes native richedit to report CFM_BOLD as always set, regardless of selection, or previous calls to EM_SETCHARFORMAT. Switch to Courier New in order to see that richedit really sets the CFM_BOLD attribute in the correct selection. This fix was succe

Re: wininet: InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported

2008-06-25 Thread Lei Zhang
On Wed, Jun 25, 2008 at 8:46 AM, Alexander Morozov <[EMAIL PROTECTED]> wrote: > Changelog: > InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported > > From b89937296efd5a45772027f07b2fdbf80b5f480d Mon Sep 17 00:00:00 2001 > From: Alexander Morozov <[EMAIL PROTECTED]> > Date:

Re: wininet/tests: add InternetErrorDlg tests

2008-06-25 Thread Austin English
On Wed, Jun 25, 2008 at 10:44 AM, Alexander Morozov <[EMAIL PROTECTED]> wrote: > Changelog: > Add InternetErrorDlg tests > > I ran these tests on Win98 and WinXP > > From 687f7d365b97d1da95db222e5bd5bbdf5c62c76f Mon Sep 17 00:00:00 2001 > From: Alexander Morozov <[EMAIL PROTECTED]> > Date: Wed, 25

wininet/tests: add InternetErrorDlg tests

2008-06-25 Thread Alexander Morozov
Changelog: Add InternetErrorDlg tests I ran these tests on Win98 and WinXP From 687f7d365b97d1da95db222e5bd5bbdf5c62c76f Mon Sep 17 00:00:00 2001 From: Alexander Morozov <[EMAIL PROTECTED]> Date: Wed, 25 Jun 2008 19:01:42 +0400 Subject: [PATCH] wininet/tests: add InternetErrorDlg tests --- dlls/

Re: [6/7] gdiplus: Implemented GdipGetPathData with test

2008-06-25 Thread Nikolay Sivov
Paul Vriens wrote: > Nikolay Sivov wrote: >> Paul Vriens wrote: >>> Nikolay Sivov wrote: >>> >>> Hi, >>> >>> We seem to have numerous failures (and even more serious, test >>> crashes) with these tests on Windows. I did check a few things >>> myself but I'm lacking the knowledge to look further i

wininet: InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported

2008-06-25 Thread Alexander Morozov
Changelog: InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported From b89937296efd5a45772027f07b2fdbf80b5f480d Mon Sep 17 00:00:00 2001 From: Alexander Morozov <[EMAIL PROTECTED]> Date: Wed, 25 Jun 2008 19:07:34 +0400 Subject: [PATCH] wininet: InternetErrorDlg should return E

[Wine] Shortcuts not appearing in gnome panel drawers

2008-06-25 Thread Darragh Bailey
Tried posting the following question on wine-users. I suspect that those behind the creation of the mechanism by which wine creates launchers from windows shortcuts don't read that list. - Forwarded message from Darragh Bailey <[EMAIL PROTECTED]> - I'm trying to trace why launchers create

Re: [6/7] gdiplus: Implemented GdipGetPathData with test

2008-06-25 Thread Paul Vriens
Nikolay Sivov wrote: > Paul Vriens wrote: >> Nikolay Sivov wrote: >> >> Hi, >> >> We seem to have numerous failures (and even more serious, test >> crashes) with these tests on Windows. I did check a few things myself >> but I'm lacking the knowledge to look further in to this. >> >> Running the

Re: [6/7] gdiplus: Implemented GdipGetPathData with test

2008-06-25 Thread Nikolay Sivov
Paul Vriens wrote: > Nikolay Sivov wrote: >> Changelog: >> - Implemented GdipGetPathData with test >> >> --- >> dlls/gdiplus/gdiplus.spec |2 +- >> dlls/gdiplus/graphicspath.c | 22 ++ >> dlls/gdiplus/tests/graphicspath.c | 23 +++ >

Re: [6/7] gdiplus: Implemented GdipGetPathData with test

2008-06-25 Thread Paul Vriens
Nikolay Sivov wrote: > Changelog: > - Implemented GdipGetPathData with test > > --- > dlls/gdiplus/gdiplus.spec |2 +- > dlls/gdiplus/graphicspath.c | 22 ++ > dlls/gdiplus/tests/graphicspath.c | 23 +++ > include/gdiplusflat.h

Re: richedit: Added missing defines and structures to richedit.h

2008-06-25 Thread Dylan Smith
Thanks for catching that. I didn't mean to leave that in, and should have searched my patch for those comments. I'll fix fix it and resubmit the patch. On Wed, Jun 25, 2008 at 5:24 AM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > Hello Dylan, > > Dylan Smith wrote: > >> I tried to make riched

Re: user32:tests:msg.c Add msg tests for SetActiveWindow()

2008-06-25 Thread Anatoly Lyutin
Dmitry Timoshkov wrote: > Isn't the comment above is clear enough to which test it belongs to? > Yes, It my fall. I have posted a patch again. -- Best regards Anatoly Lyutin.

Re: user32:tests:msg.c Add msg tests for SetActiveWindow()

2008-06-25 Thread Dmitry Timoshkov
Anatoly Lyutin <[EMAIL PROTECTED]> wrote: > @@ -10845,6 +10997,7 @@ START_TEST(msg) > /* keep it the last test, under Windows it tends to break the tests > * which rely on active/foreground windows being correct. > */ > +test_SetActiveWindow(); > test_SetForegroundWindow(

Re: gdiplus/graphicspath test crashes

2008-06-25 Thread Alistair Leslie-Hughes
"Paul Vriens" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Alistair Leslie-Hughes wrote: >> "Paul Vriens" <[EMAIL PROTECTED]> wrote in message >> news:[EMAIL PROTECTED] >>> Hi, >>> >> > I usually overcome these compile issues with a trick I've learned from > Hans > Leidekker: > >

Re: Revert "winspool.drv: Make sure the printer driver registry entry exists.

2008-06-25 Thread Huw Davies
On Wed, Jun 25, 2008 at 12:17:36AM +0200, Detlef Riekenberg wrote: > On Di, 2008-06-24 at 10:25 -0700, Dan Kegel wrote: > > Today I started getting a heap corruption and crash in localspl: > > ... > > Anyone know what's up with that? > > That was introduced by Huw (added a circular dependance). >

Re: gdiplus/graphicspath test crashes

2008-06-25 Thread Paul Vriens
Alistair Leslie-Hughes wrote: > "Paul Vriens" <[EMAIL PROTECTED]> wrote in message > news:[EMAIL PROTECTED] >> Hi, >> >> I've noticed that the mentioned tests crashes when run via Paul Millar's >> winetest executable. Compiling myself and running the test works fine. >> >> Any one else seeing this

Re: gdiplus/graphicspath test crashes

2008-06-25 Thread Alistair Leslie-Hughes
"Paul Vriens" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Hi, > > I've noticed that the mentioned tests crashes when run via Paul Millar's > winetest executable. Compiling myself and running the test works fine. > > Any one else seeing this? > I think my XP box crashes. Currentl

Re: urlmon: Fix a few test failures

2008-06-25 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > One of the failures only happens with IE6, and the other was failing > across all platforms. > > Changelog: > * Fix a few test failures. This doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c

Re: inetmib1(16/31): Use a helper function to get the item and instance of the MIB2 interface table

2008-06-25 Thread Alexandre Julliard
"Juan Lang" <[EMAIL PROTECTED]> writes: > From 94c46a93327a62e4cdafd3c06f472efb82ee42af Mon Sep 17 00:00:00 2001 > From: Juan Lang <[EMAIL PROTECTED]> > Date: Tue, 20 May 2008 20:59:42 -0700 > Subject: [PATCH] Use a helper function to get the item and instance of the > MIB2 interface table This

Re: richedit: Added missing defines and structures to richedit.h

2008-06-25 Thread Michael Stefaniuc
Hello Dylan, Dylan Smith wrote: > I tried to make richedit.h more consistent with the public SDK headers > by adding anything any missing defines and structures that I could find. > --- > include/richedit.h | 395 > ++-- > 1 files changed, 384 ins

What to do with wrong AeDebug entries in the registry on Windows boxes?

2008-06-25 Thread Paul Vriens
Hi, I guess it's a leftover from old kernel/debugger tests but on some Windows boxes this registry key is filled with our test-debugger information. This is maybe/probably the reason some tests show "Timeout" for one box and "Crashed" for others. What would be the best approach to "restore"

gdiplus/graphicspath test crashes

2008-06-25 Thread Paul Vriens
Hi, I've noticed that the mentioned tests crashes when run via Paul Millar's winetest executable. Compiling myself and running the test works fine. Any one else seeing this? -- Cheers, Paul.