Re: d3dx9: Implementation of D3DXMatrixDecompose 2/2

2008-08-05 Thread David Adam
Hi, some remarks +if (((*poutscale).x==0)||((*poutscale).y==0)||((*poutscale).z==0)) should be +if ((poutscale->x==0)||(poutscale->y==0)||(poutscale->z==0)) No need to redefine a module fonction Replace +poutscale->x=module(pM->m[0][0],pM->m[0][1],pM->m[0][2]); by + poutscale->x=D3D

Re: advapi32: Implement GetSecurityInfo. [take 2]

2008-08-05 Thread Dmitry Timoshkov
"Dan Hipschman" <[EMAIL PROTECTED]> wrote: > +#include ... > DWORD WINAPI GetSecurityInfo( > HANDLE hObject, SE_OBJECT_TYPE ObjectType, > @@ -2718,8 +2735,44 @@ DWORD WINAPI GetSecurityInfo( > PSECURITY_DESCRIPTOR *ppSecurityDescriptor > ) > { > - FIXME("stub!\n"); > - return ERROR_BAD_

Re: user32: DdeClientTransaction should return 0 in the last param forDDE_DATA

2008-08-05 Thread Dmitry Timoshkov
"Jeff Latimer" <[EMAIL PROTECTED]> wrote: > --- a/dlls/user32/dde_client.c > +++ b/dlls/user32/dde_client.c > @@ -520,6 +520,7 @@ static WDML_QUEUE_STATE > WDML_HandleRequestReply(WDML_CONV* pConv, MSG* msg, WDML > case WM_DDE_DATA: > UnpackDDElParam(WM_DDE_DATA, msg->lParam, &uiLo, &

Re: [PATCH] oleaut32: Fix some corner cases in VarBstrCmp.

2008-08-05 Thread Lei Zhang
On Tue, Aug 5, 2008 at 3:15 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > That's ugly, you shouldn't need such special handling here, you should > simply fall through to the normal comparisons which should give the > correct results. Falling through didn't work. CompareStringW does not like

Re: d3dx9: Implementation of D3DXMatrixDecompose 2/2

2008-08-05 Thread H. Verbeet
2008/8/5 David Adam <[EMAIL PROTECTED]>: > Hi, > > some remarks > > +if (((*poutscale).x==0)||((*poutscale).y==0)||((*poutscale).z==0)) > should be > +if ((poutscale->x==0)||(poutscale->y==0)||(poutscale->z==0)) > To add to that, you really should test your error paths in your test case. A

Re: d3dx9: Implementation of D3DXGetDeclLength

2008-08-05 Thread H. Verbeet
2008/8/5 Luis Busquets <[EMAIL PROTECTED]>: > +static const D3DVERTEXELEMENT9 lc={0xFF,0,D3DDECLTYPE_UNUSED,0,0,0}; What do you use this for? > +while ((pdecl+i)->Stream!=0xFF) > +{ > +i++; You might as well increment pdecl itself. Also keep in mind that Alexandre won't be back be

Vacation

2008-08-05 Thread Alexandre Julliard
Folks, I'm leaving on vacation, so there won't be any commits for a while. Of course thanks to git that shouldn't prevent you from filling my mailbox with patches... I'll be back on the 18th, and release 1.1.3 will thus be on the 22nd. -- Alexandre Julliard [EMAIL PROTECTED]

Re: [WineHQ] [4/4] news: Remove the 'Weekly Newsletters' box from the home page.

2008-08-05 Thread Jeremy Newman
They should be fine. I will get them in sometime today, and clean them up if that is even needed. Thanks for the work. Francois Gouget wrote: > On Mon, 4 Aug 2008, Jeremy Newman wrote: > >> I have no intention of removing the WWN box. Removing it will leave a >> large gaping hole on that right

Re: [dplayx 01/12] Tests for CreateGroup

2008-08-05 Thread Ismael Barros
On 8/5/08, Paul Vriens <[EMAIL PROTECTED]> wrote: > Ismael Barros wrote: >> Tests for CreateGroup >> Fixed the implementation of CreateGroup and CreateGroupInGroup so that >> it doesn't segfault when the service provider is not initialized >> >> --- >> dlls/dplayx/dplay.c| 10 ++ >> dlls

Re: DIB engine status

2008-08-05 Thread Huw Davies
On Fri, Aug 01, 2008 at 06:23:43PM +0400, Сергей Новосёлов wrote: > We'd like to continue develop your version. When are you going > to remain this project? Great! Please send me patches and I'll apply them. I'll probably merge with WineHQ on every WineHQ release. I'm not planning on doing any

Re: Patch checking robot coming

2008-08-05 Thread Ambroz Bizjak
I've written some code for the chroot, though it has proven to be harder than I taught it would, especially because of all the development tools and libraries that need to be copied into the chroot. Right now it will only work on Gentoo, other distributions will require some fine-tuning of paths, e

Re: [1/2] user32: Add a test for ToUnicode (try 5)

2008-08-05 Thread Andre Wisplinghoff
Paul Vriens wrote: > Just some things that caught my attention: > > Could you trim the length for some of the lines somewhat? I also don't think > you > need all those comments in the first call to ToUnicode. > > There is a C++ comment in the patch, should be avoided. > > And as a last one, is it

Re: [2/2] user32:focus.c Remove unneeded palette messages.

2008-08-05 Thread Anatoly Lyutin
Dmitry Timoshkov wrote: > "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: > >> I run test-cases on 98 and XP and I can not see where this messages >> have been posted in tests. In Wine this messages have not processing. >> >> Does anybody something know about this? > > Try to run the tests in a palett

Re: [PATCH] oleaut32: Fix some corner cases in VarBstrCmp.

2008-08-05 Thread Alexandre Julliard
"Lei Zhang" <[EMAIL PROTECTED]> writes: > diff --git a/dlls/oleaut32/vartype.c b/dlls/oleaut32/vartype.c > index daeac85..713ebae 100644 > --- a/dlls/oleaut32/vartype.c > +++ b/dlls/oleaut32/vartype.c > @@ -6942,7 +6942,24 @@ HRESULT WINAPI VarBstrCmp(BSTR pbstrLeft, BSTR > pbstrRight, LCID lcid,

Re: msxml3: Add ISAXContentHandler_endPrefix event (1/7)

2008-08-05 Thread Alexandre Julliard
Piotr Caban <[EMAIL PROTECTED]> writes: > +static HRESULT namespacePush(saxlocator *locator, int ns) > +{ > +if(locator->nsStackLast+1>locator->nsStackSize) > +{ > +locator->nsStackSize += STACKALLOCATIONSIZE; > +locator->nsStack = HeapReAlloc(GetProcessHeap(), 0, > +

Re: d3dx9: Implementation of D3DXMatrixDecompose and tests

2008-08-05 Thread tony . wasserka
Hi, 1. The order of +/*The components of the translation transformation vector are straigth in the fourth column of the transformation matrix*/ +(*pouttranslation).x=(*pM).m[3][0]; +(*pouttranslation).y=(*pM).m[3][1]; +(*pouttranslation).z=(*pM).m[3][2]; + +/*Let's calculate

Re: [NJS#80583] Re: ntdll: import dll from dir of referring dll if not found instandard locations

2008-08-05 Thread Dmitry Timoshkov
"Hongbo Ni" <[EMAIL PROTECTED]> wrote: > I have posted a another patch regarding to windows hook into another > process. > http://www.winehq.org/pipermail/wine-patches/2008-August/059069.html > > Basically it change LoadlibraryW to LoadlibraryExW with Alt-path. > > Could you please let me know