Re: [NJS#80583] Re: [TRY2]user32/tests: add tests for creating subclassed builtinclass windows

2008-08-07 Thread Hongbo Ni
Dmitry Timoshkov wrote: >>+"Edit", >>+"Button", >>+"Static", >>+"ComboBox", >>+"ComboLBox", >>+"ListBox", >>+"#32770", /* dialog */ >>+}; > >You forgot "ScrollBar" and some other builtin classes. Ok all other builtin classes added for t

Re: Networking problems with IDU Verwaltung software

2008-08-07 Thread Hin-Tak Leung
Werner LEMBERG wrote: >> If your software really is trying to use winsock to access the database, try >> running it with "WINEDEBUG=+winsock wine app.exe" to log the winsock calls >> that are being made. > > This gives > > trace:winsock:DllMain 0x7e6a 0x1 0x1 > trace:winsock:WSAStartup

Re: advapi32: Implement GetSecurityInfo. [take 3]

2008-08-07 Thread Vitaliy Margolen
Juan Lang wrote: > Hi Dan, > > +if (ppSecurityDescriptor) > +*ppSecurityDescriptor = sd; > + > > you leak sd in the (implicit) else block here. > --Juan > > There are no other options here. I'm sure windows will leak it as well. Did anyone mentioned already how well win32api is des

Re: [8/11] ole32 : basic inprocess handler implentation

2008-08-07 Thread Alistair Leslie-Hughes
<[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED]> Modify the stub implementation of GetDestCtx, to "emulate" a local machine instead of a remote machine. This trick is needed to allow handle marshalling > + *pdwDestContext = MSHCTX_NOSHAREDMEM; //MSHCTX_DIFFERENTMACHINE;> c++ s

Re: Networking problems with IDU Verwaltung software

2008-08-07 Thread Juan Lang
This discussion really would be better taken up in bugzilla. --Juan

Re: Networking problems with IDU Verwaltung software

2008-08-07 Thread Werner LEMBERG
> It is probably irrelevant, but something is looking for the visual C > 8 runtime and not finding it. You can install VC80 runtime with > winetricks. Well, the program comes with a setup for VC80 files (which I intentionally haven't installed to make Wine debugging easier due to non-tainting --

Re: Networking problems with IDU Verwaltung software

2008-08-07 Thread Werner LEMBERG
> Hi Werner, fancy seeing you in a different list... :-) > I was wondering why you do warn+all (not very useful). I would be > doing +relay or +odbc or one of the others. Hrmpf. Using WINEDEBUG=+relay gives me a 237MByte log file, using WINEDEBUG=+warn:relay produces nothing (except the unrela

Re: Networking problems with IDU Verwaltung software

2008-08-07 Thread Werner LEMBERG
> If your software really is trying to use winsock to access the database, try > running it with "WINEDEBUG=+winsock wine app.exe" to log the winsock calls > that are being made. This gives trace:winsock:DllMain 0x7e6a 0x1 0x1 trace:winsock:WSAStartup verReq=202 trace:winsock:WSAStar

Re: advapi32: Implement GetSecurityInfo. [take 3]

2008-08-07 Thread Dan Hipschman
On Thu, Aug 07, 2008 at 02:33:35PM -0700, Juan Lang wrote: > > I guess I should elaborate on that. You can request any of the four > > parts of the security descriptor and pass NULL for the SD itself and > > Windows will return them without anyway to free the memory. > > I can see what MSDN says

Re: advapi32: Implement GetSecurityInfo. [take 3]

2008-08-07 Thread Juan Lang
> I guess I should elaborate on that. You can request any of the four > parts of the security descriptor and pass NULL for the SD itself and > Windows will return them without anyway to free the memory. I can see what MSDN says it does, but your tests don't check that calling GetSecurityInfo with

Re: advapi32: Implement GetSecurityInfo. [take 3]

2008-08-07 Thread Dan Hipschman
On Thu, Aug 07, 2008 at 02:28:10PM -0700, Dan Hipschman wrote: > On Thu, Aug 07, 2008 at 02:25:00PM -0700, Juan Lang wrote: > > +if (ppSecurityDescriptor) > > +*ppSecurityDescriptor = sd; > > + > > > > you leak sd in the (implicit) else block here. > > So does Windows. I guess I shou

Re: advapi32: Implement GetSecurityInfo. [take 3]

2008-08-07 Thread Juan Lang
>> you leak sd in the (implicit) else block here. > > So does Windows. In that case, you should include that in your tests, as it's not especially obvious. --Juan

Re: advapi32: Implement GetSecurityInfo. [take 3]

2008-08-07 Thread Dan Hipschman
On Thu, Aug 07, 2008 at 02:25:00PM -0700, Juan Lang wrote: > +if (ppSecurityDescriptor) > +*ppSecurityDescriptor = sd; > + > > you leak sd in the (implicit) else block here. So does Windows.

Re: advapi32: Implement GetSecurityInfo. [take 3]

2008-08-07 Thread Juan Lang
Hi Dan, +if (ppSecurityDescriptor) +*ppSecurityDescriptor = sd; + you leak sd in the (implicit) else block here. --Juan

Re: Networking problems with IDU Verwaltung software

2008-08-07 Thread Hin-Tak Leung
Hi Werner, fancy seeing you in a different list... I was wondering why you do warn+all (not very useful). I would be doing +relay or +odbc or one of the others. Here is a useful link: http://wiki.jswindle.com/index.php/Wine_Debug_Channels --- On Thu, 7/8/08, Werner LEMBERG <[EMAIL PROTECTED]>

Re: Make RegisterDeviceNotificationW behave likeRegisterDeviceNotificationA

2008-08-07 Thread Dmitry Timoshkov
"Zachary Goldberg" <[EMAIL PROTECTED]> wrote: > Your patch is more likely to be accepted if it comes with a test which > works on windows, didnt pass in wine before but passes now and > demonstrates why the new behavior is correct. There is no need for a test since that's not really an implementa

Re: user32: DdeClientTransaction should return 0 in the last paramforDDE_DATA

2008-08-07 Thread Dmitry Timoshkov
"Jeff Latimer" <[EMAIL PROTECTED]> wrote: >> Although there is no tests for all DdeClientTransaction cases, it should >> be pretty safe to assume that all request types behave similar in >> returning >> handling state. > That is not how it looked when I set ack to DMLERR_NO_ERROR at the start >

Re: Make RegisterDeviceNotificationW behave like RegisterDeviceNotificationA

2008-08-07 Thread Zachary Goldberg
On 8/6/08, Martin Profittlich <[EMAIL PROTECTED]> wrote: > Hello! > > This patch fixes bug 14781 (http://bugs.winehq.org/show_bug.cgi?id=14781). > > Some Native Instruments apps like Kontakt 3 and Kore Player crash on startup, > shortly after calling RegisterDeviceNotificationW(). This stub curren

Re: taskmgr: Converted some functions and variables to Unicode

2008-08-07 Thread Nikolay Sivov
Vladimir Pankratov wrote: > -if (DialogBox(hInst, MAKEINTRESOURCE(IDD_COLUMNS_DIALOG), hMainWnd, > ColumnsDialogWndProc) == IDOK) > +if (DialogBoxW(hInst, (LPWSTR)MAKEINTRESOURCE(IDD_COLUMNS_DIALOG), > hMainWnd, ColumnsDialogWndProc) == IDOK) Why not to use MAKEINTRESOURCEW?

Re: Networking problems with IDU Verwaltung software

2008-08-07 Thread Kai Blin
On Thursday 07 August 2008 10:33:28 Werner LEMBERG wrote: > I try to make run a German software bundle called `IDU Verwaltung'. > It seems to work, however, I can't make it to connect to a PostgreSQL > database. I have enabled PostgreSQL access in my firewall. > > Interestingly, I couldn't find i

Re: user32: DdeClientTransaction should return 0 in the last param forDDE_DATA

2008-08-07 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "Jeff Latimer" <[EMAIL PROTECTED]> wrote: > >> MSDN does not show DdeCientTransaction as returning in res >> DDE_FNOTPROCESSED. Is this the standard test to see if it is zero? >> Otherwise an actual test for 0 would be just as good. > > Existing tests already check for

Re: user32: DdeClientTransaction should return 0 in the last param forDDE_DATA

2008-08-07 Thread Dmitry Timoshkov
"Jeff Latimer" <[EMAIL PROTECTED]> wrote: > MSDN does not show DdeCientTransaction as returning in res > DDE_FNOTPROCESSED. Is this the standard test to see if it is zero? > Otherwise an actual test for 0 would be just as good. Existing tests already check for DDE_FNOTPROCESSED. Using just 0

Re: user32: DdeClientTransaction should return 0 in the last param forDDE_DATA

2008-08-07 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "Jeff Latimer" <[EMAIL PROTECTED]> wrote: > >> >> + if (ack) *ack = ERROR_SUCCESS; >> >> >> ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); >> -todo_wine >> -{ >> -ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got >> %08x\n", r

Re: Networking problems with IDU Verwaltung software

2008-08-07 Thread Alistair Leslie-Hughes
Werner LEMBERG wrote: > [wine 1.1.2] > [openSuSE 10.2, kernel 2.6.21-rc6] > > Folks, > > > I try to make run a German software bundle called `IDU Verwaltung'. > It seems to work, however, I can't make it to connect to a PostgreSQL > database. I have enabled PostgreSQL access in my firewall. Ho

Networking problems with IDU Verwaltung software

2008-08-07 Thread Werner LEMBERG
[wine 1.1.2] [openSuSE 10.2, kernel 2.6.21-rc6] Folks, I try to make run a German software bundle called `IDU Verwaltung'. It seems to work, however, I can't make it to connect to a PostgreSQL database. I have enabled PostgreSQL access in my firewall. Interestingly, I couldn't find informatio