Re: AppDB rating definitions, was: Re: Canonical and wine

2008-12-15 Thread Austin English
On Mon, Dec 15, 2008 at 10:56 PM, Ben Klein wrote: > Mentioning bug severity levels in appdb submission rules is asking for > trouble. Most appdb users don't use bugzilla at all. Agreed. Please bottom post on Wine mailing lists. > 2008/12/16 Rosanne DiMesio : >> On Mon, 15 Dec 2008 19:28:18 -06

Re: AppDB rating definitions, was: Re: Canonical and wine

2008-12-15 Thread Ben Klein
Mentioning bug severity levels in appdb submission rules is asking for trouble. Most appdb users don't use bugzilla at all. 2008/12/16 Rosanne DiMesio : > On Mon, 15 Dec 2008 19:28:18 -0600 > "Austin English" wrote: > >> 2008/12/15 M.Kiesel : >> > On Fri, 12 Dec 2008, Austin English wrote: >> > >

Re: AppDB rating definitions, was: Re: Canonical and wine

2008-12-15 Thread Rosanne DiMesio
On Mon, 15 Dec 2008 19:28:18 -0600 "Austin English" wrote: > 2008/12/15 M.Kiesel : > > On Fri, 12 Dec 2008, Austin English wrote: > > > >> If I had a nickel for every times I've seen platinum and gold ratings for > >> apps that had dozens of native dlls or complicated scripts to work around > >>

Re: AppDB rating definitions, was: Re: Canonical and wine

2008-12-15 Thread Austin English
2008/12/15 M.Kiesel : > On Fri, 12 Dec 2008, Austin English wrote: > >> If I had a nickel for every times I've seen platinum and gold ratings for >> apps that had dozens of native dlls or complicated scripts to work around >> wine bugs, I'd be a much richer man. > > What about clarifying the wordin

patch to fix bug 8072, but need some help with tests

2008-12-15 Thread ricardo filipe
hi guys! after many days tinkering on this i managed to make the notification work! (pump fist) now media player classic correctly displays the files when browsing on "Open File" with no native libraries :) i would like some feedback on the patch though because there is some "repeated" code an

Re: Another machine passing tests

2008-12-15 Thread Alasdair Sinclair
Austin English wrote: > On Mon, Dec 15, 2008 at 2:04 PM, Zachary Goldberg wrote: > >> All, >> >> It seems we have another machine which passes all tests on Wine >> >> http://test.winehq.org/data/bd25af9dba280e3d80f3080140f2f5ab2cd0dfb3/ >> >> Huzzah! >> >> --Zach >> >> >> >> > > Who's mach

Re: AppDB rating definitions, was: Re: Canonical and wine

2008-12-15 Thread Sparr
I think that Highest Settings is unfair, there are issues with many games in Windows with settings maxed (Check Oblivion forums, every problem we have in wine is also had by people in native windows). Default settings is a far more appropriate measuring stick. I also think there needs to be a revi

Re: Unused vtables and debug channels

2008-12-15 Thread Andrew Talbot
Ken Thomases wrote: > On Dec 15, 2008, at 3:41 PM, Andrew Talbot wrote: > >> It appears that the following vtables and Wine debug channels are >> not being used, so I am considering removing them. Please let me >> know, therefore, if you have plans for any of them and want them kept. >> >> >> Win

AppDB rating definitions, was: Re: Canonical and wine

2008-12-15 Thread M.Kiesel
On Fri, 12 Dec 2008, Austin English wrote: If I had a nickel for every times I've seen platinum and gold ratings for apps that had dozens of native dlls or complicated scripts to work around wine bugs, I'd be a much richer man. What about clarifying the wording on http://appdb.winehq.org/help

Re: Unused vtables and debug channels

2008-12-15 Thread Ken Thomases
On Dec 15, 2008, at 3:41 PM, Andrew Talbot wrote: > It appears that the following vtables and Wine debug channels are > not being used, so I am considering removing them. Please let me > know, therefore, if you have plans for any of them and want them kept. > > > Wine debug channels in: > > [.

Re: Unused vtables and debug channels

2008-12-15 Thread James Hawkins
On Mon, Dec 15, 2008 at 3:36 PM, Henri Verbeet wrote: > 2008/12/15 James Hawkins : >> Why would you remove any of them? That's like removing stub functions >> because we don't know if they're ever called. >> > Although it probably doesn't make sense to remove these if people have > plans for them

Re: Unused vtables and debug channels

2008-12-15 Thread Henri Verbeet
2008/12/15 Austin English : > The same argument would apply to the debug channels. They don't hurt > anything, and when needed, are easier to use if already in place. > > What do you gain by removing them? > It doesn't work that way. The question should be if you can justify keeping a piece of code

Re: Unused vtables and debug channels

2008-12-15 Thread Henri Verbeet
2008/12/15 James Hawkins : > Why would you remove any of them? That's like removing stub functions > because we don't know if they're ever called. > Although it probably doesn't make sense to remove these if people have plans for them, I do think that in general you shouldn't add code until it's a

Re: Unused vtables and debug channels

2008-12-15 Thread Austin English
On Mon, Dec 15, 2008 at 4:52 PM, Andrew Talbot wrote: > James Hawkins wrote: > >> >> Why would you remove any of them? That's like removing stub functions >> because we don't know if they're ever called. >> > > OK. I get the message; I shall leave the vtables alone. May I take out the > unused de

Re: Unused vtables and debug channels

2008-12-15 Thread Andrew Talbot
James Hawkins wrote: > > Why would you remove any of them? That's like removing stub functions > because we don't know if they're ever called. > OK. I get the message; I shall leave the vtables alone. May I take out the unused debug channels, though? I presume they can easily be re-introduced

Re: Unused vtables and debug channels

2008-12-15 Thread Christian Costa
I Agree. There was also this can of cleanup in d3dxof and direct music dlls whereas there are not complete. Some code are put in place as placeholder for future developments in one hand and there is some clean-up to remove them in the other. I don't see the point. Christian James Hawkins a écr

Re: amstream: Some fixes

2008-12-15 Thread Christian Costa
Alexandre Julliard a écrit : > Christian Costa writes: > > >> commit bb5a3b161d69bb2dc0e5be8cbbc5268dbc7d513f >> Author: Christian Costa >> Date: Sun Dec 14 00:46:24 2008 +0100 >> >> Some fixes. >> > > Please avoid white space changes, and provide a proper log message, > "some fixes

Re: d3dxof: Add a test to dump an X object data (enabled when objects.txt and templates.txt are present) (try 2)

2008-12-15 Thread Christian Costa
Hi Stefan, Damned. You discovered all my secret activities. ;-) More seriously, thanks for noticing that. :-) There is some memory leakage issues remaining which cause some apps to run out of memory. This is due to the lack of ref count handling between objects. Bug 16293 deals with that. http

Re: Unused vtables and debug channels

2008-12-15 Thread Henri Verbeet
2008/12/15 Andrew Talbot : > secur32/schannel.c This one isn't unused, but all its uses are inside an #ifdef.

Re: Unused vtables and debug channels

2008-12-15 Thread James Hawkins
On Mon, Dec 15, 2008 at 1:41 PM, Andrew Talbot wrote: > It appears that the following vtables and Wine debug channels are not being > used, so I am considering removing them. Please let me know, therefore, if > you have plans for any of them and want them kept. > > Why would you remove any of t

Unused vtables and debug channels

2008-12-15 Thread Andrew Talbot
It appears that the following vtables and Wine debug channels are not being used, so I am considering removing them. Please let me know, therefore, if you have plans for any of them and want them kept. Vtables: IDirectXFileBinary_Vtbl d3dxof/d3dxof.c IDirectXFileObject_Vtbl

Re: msi: improve a debugging message

2008-12-15 Thread James Hawkins
On Mon, Dec 15, 2008 at 1:15 PM, Austin English wrote: > -- > -Austin > Are you adding this because you've been debugging the msi db code? Knowing the row number that we failed to insert is not helpful. In most cases, this message is harmless and should be a warn or removed completely as this is

Re: Another machine passing tests

2008-12-15 Thread Paul Vriens
Zachary Goldberg wrote: > All, > > It seems we have another machine which passes all tests on Wine > > http://test.winehq.org/data/bd25af9dba280e3d80f3080140f2f5ab2cd0dfb3/ > > Huzzah! > > --Zach > > And unfortunately it has one error in the last run. Getting consistent test results will be

Re: Another machine passing tests

2008-12-15 Thread Austin English
On Mon, Dec 15, 2008 at 2:04 PM, Zachary Goldberg wrote: > All, > > It seems we have another machine which passes all tests on Wine > > http://test.winehq.org/data/bd25af9dba280e3d80f3080140f2f5ab2cd0dfb3/ > > Huzzah! > > --Zach > > > Who's machine is that, Aric's? -- -Austin

Re: [4/10] WineD3D: Some GL_EXT_fog_coord prototype fixes

2008-12-15 Thread Henri Verbeet
2008/12/15 Stefan Dösinger : > -typedef void (WINE_GLAPI * PGLFNGLFOGCOORDFVEXTPROC) (GLfloat intesity); > -typedef void (WINE_GLAPI * PGLFNGLFOGCOORDDEXTPROC) (GLfloat intesity); > -typedef void (WINE_GLAPI * PGLFNGLFOGCOORDDVEXTPROC) (GLfloat intesity); > +typedef void (WINE_GLAPI * PGLFNGLFOGCOO

Another machine passing tests

2008-12-15 Thread Zachary Goldberg
All, It seems we have another machine which passes all tests on Wine http://test.winehq.org/data/bd25af9dba280e3d80f3080140f2f5ab2cd0dfb3/ Huzzah! --Zach

Re: wine-1.2 release criteria?

2008-12-15 Thread Massimo Del Fedele
Reece Dunn ha scritto: > 2008/12/15 Dan Kegel : > >> - DIB Engine >> As mentioned in >> http://www.winehq.org/wwn/354#Another%20shot%20at%20a%20DIB%20Engine >> Massimo picked up Jesse's DIB engine code and has been trying to >> use it with Autocad. He says he's starting to get fonts working. >> (

Re: wine-1.2 release criteria?

2008-12-15 Thread Pavel Troller
> > * USB Support (iPod, etc.) > No motion here, I think. > I see a big potential here. What makes me crazy, is to beg my colleagues running windoze to - flash my Nokia phone with a new firmware - Program an EPROM in a progammer - Use an SDR (Software Defined Radio) - a box with just a radio

Re: wine-1.2 release criteria?

2008-12-15 Thread Reece Dunn
2008/12/15 Dan Kegel : > - DIB Engine > As mentioned in > http://www.winehq.org/wwn/354#Another%20shot%20at%20a%20DIB%20Engine > Massimo picked up Jesse's DIB engine code and has been trying to > use it with Autocad. He says he's starting to get fonts working. > (It's surprising that he chose Jes

wine-1.2 release criteria?

2008-12-15 Thread Dan Kegel
It's been six months since the release of 1.0, maybe now is a good time to review the 1.2 release criteria listed in http://www.winehq.org/wwn/353#WineConf%202008%20Keynote One big item that wasn't listed is "make asian users happy". I think we're starting to see some motion on that, cf. http://bu

Re: user32: Sign-compare warnings fix (Try 2)

2008-12-15 Thread James Mckenzie
-Original Message- >From: Alexandre Julliard >Sent: Dec 15, 2008 5:25 AM >To: Andrew Talbot >Cc: wine-devel@winehq.org >Subject: Re: user32: Sign-compare warnings fix (Try 2) > >Andrew Talbot writes: > >> diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c >> index 9dd9083..4ea1959

Re: user32: Sign-compare warnings fix (Try 2)

2008-12-15 Thread Alexandre Julliard
Andrew Talbot writes: > diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c > index 9dd9083..4ea1959 100644 > --- a/dlls/user32/dialog.c > +++ b/dlls/user32/dialog.c > @@ -84,9 +84,9 @@ typedef struct >/* Radio button group */ > typedef struct > { > -UINT firstID; > -UINT lastI

Re: amstream: Some fixes

2008-12-15 Thread Alexandre Julliard
Christian Costa writes: > commit bb5a3b161d69bb2dc0e5be8cbbc5268dbc7d513f > Author: Christian Costa > Date: Sun Dec 14 00:46:24 2008 +0100 > > Some fixes. Please avoid white space changes, and provide a proper log message, "some fixes" doesn't say anything about the change. -- Alexandre

Re: richedit: OpenClipboard doesn't need to be given a window handle.

2008-12-15 Thread Alexandre Julliard
"Dylan Smith" writes: > I have been looking to reduce the number of places where window handles > are used, so I did a relay trace to see if native richedit controls gave > a non-null handle when calling OpenClipboard. The relay trace showed > that NULL was being used, even for normal windowed r

Re: Wine64 hello world app runs!

2008-12-15 Thread Maarten Lankhorst
Hi Zach, Zachary Goldberg schreef: > 2008/12/5 Maarten Lankhorst : > >> ... > > So 9 days, a WWN article, and a Slashdot article this story's gotten a > lot of press. I know we've talked a bit offline Maarten about this > but would you perhaps have any other updates for readers at large? I >