Re: secur32: check for variable before freeing it

2009-10-13 Thread Vitaliy Margolen
Juan Lang wrote: >> Seems NULL comes from 'handle_idx >= schan_handle_count'. > Right, and that came about due to a double free that Steam seems to like to > do. It could be a false alarm with Steam, after all it's a "silent" crash No memory dump file is created either. Was pointing out a possibl

Re: secur32: check for variable before freeing it

2009-10-13 Thread Juan Lang
> Seems NULL comes from 'handle_idx >= schan_handle_count'. Right, and that came about due to a double free that Steam seems to like to do. --Juan

Re: [1/10] Check for ms_hook_prologue attribute support, make a first function hookable

2009-10-13 Thread Dmitry Timoshkov
"Stefan Dösinger" wrote: -HRESULT WINAPI DirectInput8Create(HINSTANCE hinst, DWORD dwVersion, REFIID riid, LPVOID *ppDI, LPUNKNOWN punkOuter) { +HRESULT WINAPI DECLSPEC_HOTPATCH DirectInput8Create(HINSTANCE hinst, DWORD dwVersion, REFIID riid, LPVOID *ppDI, LPUNKNOWN punkOuter) { Probably D

Re: secur32: check for variable before freeing it

2009-10-13 Thread Austin English
On Tue, Oct 13, 2009 at 11:12 AM, Austin English wrote: > On Tue, Oct 13, 2009 at 8:30 AM, Vitaliy Margolen > wrote: >> Henri Verbeet wrote: >>> 2009/10/13 Austin English :              cred = schan_free_handle(i, SCHAN_HANDLE_CRED); -            pgnutls_certificate_free_credentials(cre

Re: secur32: check for variable before freeing it

2009-10-13 Thread Vitaliy Margolen
Austin English wrote: > What OS? 32/64-bit? 64-bit, Wine of course is 32-bit. Vitaliy.

Re: [4/10] OpenGL32: Give wglSwapBuffer a real function, make it hookable

2009-10-13 Thread Roderick Colenbrander
You should also patch make_opengl because openg32.spec is automatically generated. Roderick On Tue, Oct 13, 2009 at 10:04 PM, Stefan Dösinger wrote: > >

Re: [PATCH 1/2] oleaut32/tests: Test return value of SysReAllocStringLen for the null terminator.

2009-10-13 Thread Nikolay Sivov
Alexander Kochetkov wrote: This test works fine under windows 98, XP and under wine. And allways check for the null terminator. see bug 20334. Hi, Alexander. You patches should not break test in order they are supposed to be applied: your test currently misses todo_wine here: --- +

Re: [1/10] Check for ms_hook_prologue attribute support, make a first function hookable

2009-10-13 Thread Stefan Dösinger
Am 13.10.2009 um 22:50 schrieb Nikolay Sivov: Stefan Dösinger wrote: This makes use of the gcc attribute added to gcc svn yesterday: http://gcc.gnu.org/ml/gcc-cvs/2009-10/msg00319.html Hi, Stefan. Could you explain me br

Business professors preaching Wine

2009-10-13 Thread Zachary Goldberg
Thought you guys might enjoy this short story from my day: So I was in a class on product design (at the school of business @ the U of Penn) and my prof is going on about some software we'll need and how to use it. Out of the blue he says "And unfortunately it only works on Windows. But there is

Re: [1/3] mshtml: Add test suite for IHTMLLocation

2009-10-13 Thread Andrew Eikum
Nikolay Sivov wrote: Hi, Andrew. This series is broken, patch body is formatted. Sorry about that, had a misconfigured mail client. Should be fixed on the resend. Thanks

Re: [1/3] mshtml: Add test suite for IHTMLLocation

2009-10-13 Thread Nikolay Sivov
aei...@codeweavers.com wrote: --- dlls/mshtml/tests/Makefile.in|1 + dlls/mshtml/tests/htmllocation.c | 383 ++ 2 files changed, 384 insertions(+), 0 deletions(-) create mode 100644 dlls/mshtml/tests/htmllocation.c diff --git a/dlls/mshtml/tests/Mak

Re: secur32: check for variable before freeing it

2009-10-13 Thread Austin English
On Tue, Oct 13, 2009 at 8:30 AM, Vitaliy Margolen wrote: > Henri Verbeet wrote: >> 2009/10/13 Austin English : >>>              cred = schan_free_handle(i, SCHAN_HANDLE_CRED); >>> -            pgnutls_certificate_free_credentials(cred->credentials); >>> +            if(cred) >>> pgnutls_certifica

Re: Help me get a patch into Wine

2009-10-13 Thread Austin English
On Mon, Oct 12, 2009 at 2:18 PM, Charles Davis wrote: > Keith Muir wrote: >> Charles Davis wrote: >>> Damn it, I keep forgetting to reply all. >>> >>> Charles Davis wrote: >>> Vitaliy Margolen wrote: > Charles Davis wrote: > >> Hi, >> >> My name is Charles Davis, but

Re: secur32: check for variable before freeing it

2009-10-13 Thread Vitaliy Margolen
Henri Verbeet wrote: > 2009/10/13 Austin English : >> cred = schan_free_handle(i, SCHAN_HANDLE_CRED); >> -pgnutls_certificate_free_credentials(cred->credentials); >> +if(cred) >> pgnutls_certificate_free_credentials(cred->credentials); > I don't think "cred" is

Re: secur32: check for variable before freeing it

2009-10-13 Thread Henri Verbeet
2009/10/13 Austin English : > cred = schan_free_handle(i, SCHAN_HANDLE_CRED); > -pgnutls_certificate_free_credentials(cred->credentials); > +if(cred) pgnutls_certificate_free_credentials(cred->credentials); I don't think "cred" is ever supposed to be NULL. Could

Re: rsaenh: Fix the accepted RC2 key length, based on a test case by Dan Kegel.

2009-10-13 Thread Hans Leidekker
On Tuesday 13 October 2009 08:46:59 am Dmitry Timoshkov wrote: > +ret = pCryptImportKey(provider, (BYTE*)&key_blob, > + sizeof(BLOBHEADER)+sizeof(DWORD)+key_length, > + 0, CRYPT_IPSEC_HMAC_KEY, &hkey); > +ok(ret, "CryptImportKey error %u\n", GetLas

Re: native retest needed: GetDeviceIdentifier()

2009-10-13 Thread Stefan Dösinger
Am 13.10.2009 um 09:20 schrieb Markus Stockhausen: > + ok(1==0, "last bytes of szDriver string are %08x\n", dddi2[0x7f]); > + ok(1==0, "last bytes of szDescription string are %08x \n", dddi2[0xff]); Note that you can only test these parts if strlen(pddi.*) indicates t

Re: native retest needed: GetDeviceIdentifier()

2009-10-13 Thread Jeff Zaroyko
On Tue, Oct 13, 2009 at 6:20 PM, Markus Stockhausen wrote: > According to Stefans suggestion I have implemented a test for the string > copies into the identifier structure. Test is designed to fail to give > me a hint what is going on. Hopefully someone can post the results of a > test run in nat

Re: IsWindowUnicode() is always true after RegisterClassW

2009-10-13 Thread Alexandre Julliard
Nikolay Sivov writes: > Ah thanks, so whar<->char is done automatically depending on > SendMessageA or SendMessageW used? > > Next question if you don't mind: IsWindowUnicode() for Wine created > common controls window handles > will always return TRUE, so I could easily drop such checks? I expe

Re: native retest needed: GetDeviceIdentifier()

2009-10-13 Thread Paul Vriens
On 10/13/2009 09:20 AM, Markus Stockhausen wrote: + ok(1==0, "last bytes of szDriver string are %08x\n", dddi2[0x7f]); Hi Markus, You know that you can use trace() for that? Windows XP SP3 (real box): ddrawmodes.c:670: Test failed: last bytes of szDriver string are ddraw

native retest needed: GetDeviceIdentifier()

2009-10-13 Thread Markus Stockhausen
According to Stefans suggestion I have implemented a test for the string copies into the identifier structure. Test is designed to fail to give me a hint what is going on. Hopefully someone can post the results of a test run in native environment. Thank you diff --git a/dlls/ddraw/tests/ddrawmodes