Re: windows shutdown process

2009-11-28 Thread Ben Peddell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Vincent Povirk wrote: > In order to find the correct fix for bug 18753, I've been examining > the shutdown process on Windows. I have written a program that logs > the messages sent to it, and I've run it on Windows 7. What I found > was that a shutdow

Re: gdi32 : Correction of bug 20850 Write buffer overflow in WidenPath()

2009-11-28 Thread Dan Kegel
On Sat, Nov 28, 2009 at 5:04 PM, Laurent Vromman wrote: > -    pStrokes = HeapAlloc(GetProcessHeap(), 0, numStrokes * > sizeof(GdiPath*)); > -    pStrokes[0] = HeapAlloc(GetProcessHeap(), 0, sizeof(GdiPath)); > -    PATH_InitGdiPath(pStrokes[0]); > -    pStrokes[0]->pFlags = HeapAlloc(GetProcessHe

Re: kernel32.dll: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible (try 2)

2009-11-28 Thread Rob Shearman
2009/11/27 Paul Chitescu : > --- ./dlls/kernel32/locale.c.orig 2009-11-02 05:45:10.0 +0200 > +++ ./dlls/kernel32/locale.c 2009-11-26 19:35:39.0 +0200 > @@ -3017,7 +3017,7 @@ > RtlInitUnicodeString( &keyName, szKeyName ); > InitializeObjectAttributes(&attr, &keyName, 0

Re: services.exe: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible

2009-11-28 Thread Rob Shearman
2009/11/27 Paul Chitescu : > @@ -376,7 +376,7 @@ > InitializeCriticalSection(&(*db)->cs); > > err = RegCreateKeyExW(HKEY_LOCAL_MACHINE, SZ_SERVICES_KEY, 0, NULL, > - REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, NULL, > + REG_OPTION_NON_VOLATIL

Re: advapi32.dll: Reduce Registry access to MAXIMUM_ALLOWED wherever possible

2009-11-28 Thread Rob Shearman
2009/11/27 Paul Chitescu : > Changelog: >        advapi32.dll: Reduce Registry access to MAXIMUM_ALLOWED wherever > possible > > Makes read operation succeed on read/only Registry keys. Needs tests to show that this behaviour matches that on Windows. You should be able to achieve this by setting

Re: Wine programs - replicating bad design/bugs

2009-11-28 Thread Jerome Leclanche
The issue with notepad is, the search menu is completely different in Windows notepad (AFAIK it's in Edit and there's no search menu). Fair enough for 18622. J. Leclanche / Adys On Sat, Nov 28, 2009 at 6:20 PM, Vitaliy Margolen wrote: > Jerome Leclanche wrote: >> http://bugs.winehq.org/show_b

Re: Corrections for signal handlers

2009-11-28 Thread Vitaliy Margolen
Don't CC wine-patches. Markus Elfring wrote: >> Original printed more useful information. >> Just dropping it in sake of "correctness" is wrong. >> You'll have to come up with something that prints the same >> or don't touch it. > > I am aware of the desire to get some data for easier program deb

Re: Corrections for signal handlers

2009-11-28 Thread Vitaliy Margolen
Markus Elfring wrote: > Hello, > > Some signal handler implementations are also affected by technical details > that are described in an article by Justin Pincar. > https://www.securecoding.cert.org/confluence/display/seccode/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers >

Re: Wine programs - replicating bad design/bugs

2009-11-28 Thread Vitaliy Margolen
Jerome Leclanche wrote: > http://bugs.winehq.org/show_bug.cgi?id=20844 IMHO this could be done, however this will be a "hidden feature". You can't add that to the menu - it will break programs that "script" notepad (yes there are programs like that). > ** http://bugs.winehq.org/show_bug.cgi?id=186

re: Corrections for signal handlers

2009-11-28 Thread Dan Kegel
I'm not sure this change does what you think: - fflush(stdout); ... +(void) fsync(STDOUT_FILENO); The real problem with your change is that *we don't care* whether the output of wineserver is garbled, because it is low priority debugging information, and I've never seen it garbled in pr

Re: Whitespace cleanups

2009-11-28 Thread Jerome Leclanche
I was just working on shell32/shlview.c: ShellView_OnNotify. There is so much mixing between tabs, spaces, different indent levels, trailing whitespace and what not that the code is properly unreadable. git-blame is one thing, but when it goes as far as almost preventing a developer to make change

Wine programs - replicating bad design/bugs

2009-11-28 Thread Jerome Leclanche
Ok, posting here to get a broader feedback on the issue. Recently, another bug* was closed about an enhancement to a wine program - a minor feature not present on Windows. This is an issue I've seen brought up before, and which I've brought up myself**. As far as the win32 api goes, I can totally

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

2009-11-28 Thread Paul Vriens
On 11/24/2009 02:41 PM, Alexandre Hardy wrote: The MSDN: http://msdn.microsoft.com/en-us/library/aa364980(VS.85).aspx states that GetLongPathNameW returns the length of the string required to hold the pathname if the buffer is too small to hold the path. In the case where the buffer is too s