Re: listview: Fix LISTVIEW_CancelEditLabel to not save the changed text

2009-12-05 Thread Nikolay Sivov
Jeff Latimer wrote: --- dlls/comctl32/listview.c |2 +- dlls/comctl32/tests/listview.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Hi, Jeff. This is obviously wrong. Test will fail on native systems after your patch. What is a problem with current code, any bugs repor

Re: Using trace in tests

2009-12-05 Thread James McKenzie
James McKenzie wrote: > Charles Davis wrote: > >> James McKenzie wrote: >> >> >>> Charles Davis wrote: >>> >>> James McKenzie wrote: > All: > > I'm asking a question again, don't 'shoot' me, but I've noticed the use > of

Re: Using trace in tests

2009-12-05 Thread James McKenzie
Charles Davis wrote: > James McKenzie wrote: > >> Charles Davis wrote: >> >>> James McKenzie wrote: >>> >>> All: I'm asking a question again, don't 'shoot' me, but I've noticed the use of the trace() function in tests and I would like to use this to troubl

Re: Using trace in tests

2009-12-05 Thread Charles Davis
James McKenzie wrote: > Charles Davis wrote: >> James McKenzie wrote: >> >>> All: >>> >>> I'm asking a question again, don't 'shoot' me, but I've noticed the use >>> of the trace() function in tests and I would like to use this to >>> troubleshoot what is incorrect in the EM_FORMATRANGE patch as

Re: Using trace in tests

2009-12-05 Thread James McKenzie
Charles Davis wrote: > James McKenzie wrote: > >> All: >> >> I'm asking a question again, don't 'shoot' me, but I've noticed the use >> of the trace() function in tests and I would like to use this to >> troubleshoot what is incorrect in the EM_FORMATRANGE patch as it is not >> passing on MacOSX

Re: Using trace in tests

2009-12-05 Thread Charles Davis
James McKenzie wrote: > All: > > I'm asking a question again, don't 'shoot' me, but I've noticed the use > of the trace() function in tests and I would like to use this to > troubleshoot what is incorrect in the EM_FORMATRANGE patch as it is not > passing on MacOSX builds. The test appears to pas

Using trace in tests

2009-12-05 Thread James McKenzie
All: I'm asking a question again, don't 'shoot' me, but I've noticed the use of the trace() function in tests and I would like to use this to troubleshoot what is incorrect in the EM_FORMATRANGE patch as it is not passing on MacOSX builds. The test appears to pass on WindowsXP sp2 as the failures

Re: Please Review - Revised OS X Application Bundle patch

2009-12-05 Thread Mike Kronenberg
On 05.12.2009, at 23:45, Steven Edwards wrote: > Hi Mike, > > On Sat, Dec 5, 2009 at 2:43 PM, Mike Kronenberg > wrote: > > I cut out the rest of the discussion for the moment as I am short on > time and it's clear we all have a different philosphical POV on how > Wine should behave. I'll leave

Re: Please Review - Revised OS X Application Bundle patch

2009-12-05 Thread Steven Edwards
Hi Mike, On Sat, Dec 5, 2009 at 2:43 PM, Mike Kronenberg wrote: I cut out the rest of the discussion for the moment as I am short on time and it's clear we all have a different philosphical POV on how Wine should behave. I'll leave it up to Alexandre to decide as far as my patch goes for app bun

Re: Leaks galore!

2009-12-05 Thread Dan Kegel
On Sat, Dec 5, 2009 at 7:39 AM, Dan Kegel wrote: > http://kegel.com/wine/valgrind/logs/2009-12-05-01.15/ > shows the same results as > http://kegel.com/wine/valgrind/logs/2009-12-04-18.45/ > but with a looser filter And http://kegel.com/wine/valgrind/logs/2009-12-05-08.01/ fixes a problem where I

Re: Please Review - Revised OS X Application Bundle patch

2009-12-05 Thread Mike Kronenberg
On 04.12.2009, at 19:10, wrote: >> The Application bundle provides a mostly 1 to 1 mapping for any *.lnk >> that is generated and processed by Wine Menu Builder. > What is this "Wine Menu Builder"? > > IMHO the Mac's ".app is one icon" does not match the typical > installation on MS-Windows w

Re: Leaks galore!

2009-12-05 Thread Dan Kegel
On Sat, Dec 5, 2009 at 10:00 AM, Stefan Dösinger wrote: > in vg-ddraw-d3d.txt: >  Conditional jump or move depends on uninitialised value(s) >    at  ??? (in /dev/zero) >    by  surface_load_ds_location (surface.c:4504) >    by  IWineD3DDeviceImpl_SetDepthStencilSurface (device.c:6273) > etc > > I

Re: Leaks galore!

2009-12-05 Thread Henri Verbeet
2009/12/5 Stefan Dösinger : > Hi Dan, > > in vg-ddraw-d3d.txt: >  Conditional jump or move depends on uninitialised value(s) >    at  ??? (in /dev/zero) >    by  surface_load_ds_location (surface.c:4504) >    by  IWineD3DDeviceImpl_SetDepthStencilSurface (device.c:6273) > etc > > It seems that this

Re: Leaks galore!

2009-12-05 Thread Stefan Dösinger
Hi Dan, in vg-ddraw-d3d.txt: Conditional jump or move depends on uninitialised value(s) at ??? (in /dev/zero) by surface_load_ds_location (surface.c:4504) by IWineD3DDeviceImpl_SetDepthStencilSurface (device.c:6273) etc It seems that this happens in a function that the compiler in

Leaks galore!

2009-12-05 Thread Dan Kegel
http://kegel.com/wine/valgrind/logs/2009-12-05-01.15/ shows the same results as http://kegel.com/wine/valgrind/logs/2009-12-04-18.45/ but with a looser filter, i.e. I now even show files whose only sin is a memory leak (in the past, I had suppressed those because I cared more about non-leak errors)

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now

2009-12-05 Thread Alexandre Julliard
Roderick Colenbrander writes: > Right now we are a couple of months away for a Wine 1.2 freeze. If > dsound->openal works well enough it might be a good short-term > solution but the code should be written in such a way that it would be > easy to move it to a wasapi backend (I imagine that we wil

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now

2009-12-05 Thread Roderick Colenbrander
On Sat, Dec 5, 2009 at 12:50 PM, Stefan Dösinger wrote: > > Am 05.12.2009 um 10:35 schrieb Chris Robinson: >> Except it also has API-provided 3D features that would be a big benefit for >> implementing DSound3D, > This is indeed a big plus for OpenAL - if we use our own sound system we'll > have

Re: shdocvw: Implement IWebBrowser2_get_Name

2009-12-05 Thread Paul Vriens
On 12/04/2009 06:54 PM, Paul Vriens wrote: On 12/04/2009 12:51 PM, Alistair Leslie-Hughes wrote: Hi, Changelog: shdocvw: Implement IWebBrowser2_get_Name Best Regards Alistair Leslie-Hughes Hi Alistair, This one introduces a test failure on non-English boxes: https://winetestbot.geldorp.

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now

2009-12-05 Thread Stefan Dösinger
Am 05.12.2009 um 10:35 schrieb Chris Robinson: > Except it also has API-provided 3D features that would be a big benefit for > implementing DSound3D, This is indeed a big plus for OpenAL - if we use our own sound system we'll have to reimplement DSound3D features. It fits the "sit on the shoulde

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now

2009-12-05 Thread Chris Robinson
On Friday 04 December 2009 3:53:46 pm Stefan Dösinger wrote: > Am 04.12.2009 um 18:51 schrieb Chris Robinson: > > Though you'll still need a way to talk to the hardware. Using > > ALSA/OSS/etc directly has proven problematic with not only the current > > design and upkeep, but properly implementing