Re: [PATCH] user32: honor bfOffBits in BITMAP_Load

2010-04-06 Thread Dmitry Timoshkov
Wolfram Sang wrote: > Hmm, do you have a pointer for a test verifying how something should > look like (in contrast to checking a return value)? Was this not > necessary for LoadImage() in general? Have a look at gdi32 bitmap tests. -- Dmitry.

Direct3D testing project (GSoC)

2010-04-06 Thread Conrad Buck
Hello devels, I'm looking at submitting a SoC proposal to the wine project, but I'm feeling a little overwhelmed as my current coding experience is all over the place, and very little of it working with existing projects. My most recent work has been looking low-level code and algorithms behi

Re: winmm: Rewrite time.c using ntdll timers

2010-04-06 Thread Steven Edwards
On Tue, Apr 6, 2010 at 6:08 PM, Maarten Lankhorst wrote: > --- > Should fix bug 22252 as a side effect. It should also make it possible to > run our winmm on windows for wave playback because the timers are now using > win32 apis. :) Thanks, I've been waiting for something like this since 0383e4e

Re: user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found

2010-04-06 Thread Mikhail Maroukhine
Hello, Ok. Thanks for note. I will write test soon. Mikhail On Mon, 05 Apr 2010 21:06:05 +0700, Dan Kegel wrote: "Mikhail Maroukhine" wrote: user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found Behavior checked on Windows XP Welcome to Wine development! Poker play

bt all broken?

2010-04-06 Thread Dan Kegel
winedbg's bt all seems broken since sometime between 1.1.40 and now. Has anybody else seen this?

Wine FIXME Report March 2010

2010-04-06 Thread Michael Stefaniuc
Wine FIXME Report March 2010 The data for this report comprise the emails from March 2010 archives of the mailing lists wine-{bugs,devel,users} as well as the bugzilla attachments referenced by the wine-bugs emails. Although WARN messages were collected too they aren't

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-06 Thread Alexandre Julliard
Mike Kaplinskiy writes: > Would allowing adding the fd to the poll loop after it has been > removed be more sane? Otherwise we have to resort to ugly things like > sock_try_event (which only half work). I don't think that makes sense either. The error condition is not going to go away so you can

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-06 Thread Mike Kaplinskiy
On Tue, Apr 6, 2010 at 1:08 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> Remove the fd from the poll list so we don't get POLLHUP/POLLERR >> messages when we ask for no events > > This is wrong, even when selecting for no events you want to receive > POLLHUP/POLLERR. If you really

Re: Native Windows web Browser plugins for Linux Mozilla

2010-04-06 Thread Roderick Colenbrander
KDE used to have a plugin called 'reaktivate' which was also something similar. Roderick On Tue, Apr 6, 2010 at 3:52 PM, Tom Wickline wrote: > e.g. CrossOver Plugin thats now part of CrossOver Office... > > :) > > Tom > > On Tue, Apr 6, 2010 at 4:24 PM, Joni Salmela > wrote: >> >> I have an id

Re: msvidc32/msvideo1 question: upside down buffers?

2010-04-06 Thread Maarten Lankhorst
Hi Joerg, On 06-04-10 17:47, joerg-cyril.hoe...@t-systems.com wrote: does anybody know why msvideo_decode_8bit(), when imported from the FFmpeg project in 2004, was changed such that the pixels[] array became filled upside down? See how #ifdef ORIGINAL, which shows the original FFmpeg code,

msvidc32/msvideo1 question: upside down buffers?

2010-04-06 Thread Joerg-Cyril.Hoehle
Hi, does anybody know why msvideo_decode_8bit(), when imported from the FFmpeg project in 2004, was changed such that the pixels[] array became filled upside down? See how #ifdef ORIGINAL, which shows the original FFmpeg code, differs from the #else branch in msvideo1.c Do buffers in Wine wo

Re: [PATCH] user32: honor bfOffBits in BITMAP_Load

2010-04-06 Thread Henri Verbeet
On 6 April 2010 16:42, Wolfram Sang wrote: >> Besides "?:" is absolutely not readable, >> putting an explicit 0 there would help a bit. > > :D Okay, that proves your point. This is a short from for 'offbits ? > offbits : size'. Will fix that. > I also think that's a gcc extension, in general Wine

Re: [PATCH] user32: honor bfOffBits in BITMAP_Load

2010-04-06 Thread Wolfram Sang
Dmitry Timoshkov wrote: > Wolfram Sang wrote: > >> +offbits = bmfh->bfOffBits - sizeof(BITMAPFILEHEADER); > >> +bits = (char *)info + (offbits ?: size); > > The purpose of offbits is not clear. It has the same purpose as 'offbits' in BmpFrameDecode_ReadUncompressed() from bmpdecode

Re: [PATCH] user32: honor bfOffBits in BITMAP_Load

2010-04-06 Thread Dmitry Timoshkov
Wolfram Sang wrote: > +offbits = bmfh->bfOffBits - sizeof(BITMAPFILEHEADER); > +bits = (char *)info + (offbits ?: size); The purpose of offbits is not clear. Besides "?:" is absolutely not readable, putting an explicit 0 there would help a bit. Adding a test case wouldn't hurt eithe

Re: Native Windows web Browser plugins for Linux Mozilla

2010-04-06 Thread Tom Wickline
e.g. CrossOver Plugin thats now part of CrossOver Office... :) Tom On Tue, Apr 6, 2010 at 4:24 PM, Joni Salmela wrote: > > I have an idea how to get native windows mozilla plugins to work in > native Linux mozilla... > > as you know in Chrome each new tab is its own independent process yet > th

Native Windows web Browser plugins for Linux Mozilla

2010-04-06 Thread Joni Salmela
I have an idea how to get native windows mozilla plugins to work in native Linux mozilla... as you know in Chrome each new tab is its own independent process yet they all share a parent x-window so... if you could create a Windows which would host an active-x plugin or just the mozilla NP_PAPI pl

Re: Working on "DOS" VGA.

2010-04-06 Thread Saulius Krasuckas
* On Tue, 6 Apr 2010, Saulius Krasuckas wrote: > > There exists some branch of DOSBox called MegaBuild. [3] > > It implements LPT port emulation and enhances serial port emulation (at > least for DirectSerial mode -- now MegaBuild5 switches DSR-DTR/DCD > signal pair (and CTS-RTS one also) corre

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-06 Thread Alexandre Julliard
Mike Kaplinskiy writes: > Remove the fd from the poll list so we don't get POLLHUP/POLLERR > messages when we ask for no events This is wrong, even when selecting for no events you want to receive POLLHUP/POLLERR. If you really don't want any events you have to use -1 to remove the fd from the l

[PATCH 1/5] winmm: Improve MCI's Sysinfo command.

2010-04-06 Thread Joerg-Cyril.Hoehle
Hi, Eric Pouech wrote: >SYSINFO_PARMS.wDeviceType = (WORD)(DWORD)MCI_ALL_DEVICE_ID; >work better ? I tested ... = (WORD)MCI_ALL_DEVICE_ID which should do the same. It does not yield the "all" functionality. >did you check what mciGetDeviceID("all") returns on Vista or XP ? Yes, and it is in the

Re: Working on "DOS" VGA.

2010-04-06 Thread Saulius Krasuckas
* On Mon, 5 Apr 2010, k4king wrote: > > << > While they focus mostly on games, they aren't against general fixes. > >> > From memory they don't support lpt ports (for similar reasons) wheras > you can multi play games with serial ports so they do support those. There exists some branch of DOSBo

Icon Patches Feedback

2010-04-06 Thread Joel Holdsworth
Hi,   Are there any thoughts about my latest round of icon patches?   Thanks Joel