Re: [1/2] include/wine: add option to specify the unittest target via environment variable

2010-04-19 Thread Paul Vriens
On 04/19/2010 11:44 PM, Stefan Leichter wrote: --- include/wine/test.h |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) Hi Stefan, What's the idea/thought behind this (or what problem are you trying to solve)? -- Cheers, Paul.

Re: [shell32/tests] Fix a test failure on Windows 2000

2010-04-19 Thread Paul Vriens
On 04/19/2010 08:22 PM, Paul Vriens wrote: Hi, NT4 and lower don't run these tests so maybe it should be "shell32 5.0 and lower" instead of "Windows 2000". This one was reported by the testbot to wine-devel btw. Changelog Fix a test failure on Windows 2000 Please ignore this one. Nikolay wi

Re: Future of the WWN

2010-04-19 Thread Zachary Goldberg
On Mon, Apr 19, 2010 at 11:48 AM, Edward Savage wrote: > > Sounds like a good plan.  I've been working on a personal schedule of > one story per week excluding weeks where I've had a lot of work to do. >  So far over the last month since I started that's ended up with two > stories, one of which i

Tasklist/Tasklets (Was: Re: Remove NoAppDBEntry keyword?)

2010-04-19 Thread Michael Stefaniuc
On 04/10/2010 03:01 AM, Austin English wrote: On Mon, Nov 9, 2009 at 12:47 AM, Dan Kegel wrote: Jerome Leclanche wrote: Austin English wrote: Anyone opposed to removing that keyword? +1 on removing it. It would be nice to have a bugzilla filter to replace it, too. Are we keeping "tasklist

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more

2010-04-19 Thread Marcus Meissner
On Mon, Apr 19, 2010 at 02:50:58PM +0200, Maarten Lankhorst wrote: > Hi Marcus, > > 2010/4/19 Marcus Meissner : > > Hi, > > > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > > For MMX/SSE operations we however need to have the stack aligned > > to 16 (2^4). > > > > So specify t

Re: winecfg: Add SP2 for Vista

2010-04-19 Thread Austin English
2010/4/19 André Hentschel : > Internet Explorer 9 Preview needs it. > --- >  programs/winecfg/appdefaults.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winecfg/appdefaults.c b/programs/winecfg/appdefaults.c > index 8d28b0a..cf07fe8 100644 > --- a/programs

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

2010-04-19 Thread Christian Costa
Tony Wasserka a écrit : +static inline void check_ref(IUnknown *obj, int exp) +static inline void check_release(IUnknown *obj, int exp) We shouldn't use these function definitions anymore IMO, either do the ref check in the code itself, or replace the check_ref and check_release functions

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

2010-04-19 Thread Christian Costa
is_pow2 was in util.c, then remove. That's why I put then in texture.c. But that's better to put them in util.c just in case there are used from another part. BTW, is your name Paulo, Jéremie or David ? ;-) paulo lesgaz a écrit : Maybe this function should be in util.c. A+ David --- En dat

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

2010-04-19 Thread Christian Costa
Ben Klein a écrit : On 19 April 2010 19:43, Henri Verbeet wrote: On 19 April 2010 09:43, Christian Costa wrote: +BOOL is_pow2(UINT num) +{ +UINT i; + +if (!num) return FALSE; +for (i = 0; num >> 1; i++) num >>= 1; + +return (num << i) == num; +} This should at

Re: ISP causes winhttp test failures

2010-04-19 Thread Stefan Dösinger
Am 19.04.2010 um 17:50 schrieb Austin English: > Have you complained to your ISP? The ones in this area have a webpage > that allows you to disable it. Indeed, there was a way. Well hidden, in the FAQ(Small gray-on-white font size 8 link at the bottom), in one of the many junk questions. But it s

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

2010-04-19 Thread Christian Costa
Henri Verbeet a écrit : On 19 April 2010 09:43, Christian Costa wrote: +BOOL is_pow2(UINT num) +{ +UINT i; + +if (!num) return FALSE; +for (i = 0; num >> 1; i++) num >>= 1; + +return (num << i) == num; +} This should at least be static. You can also just replace it with

Re: Jacek Caban : jscript: Fixed String. match implementation for non-global regexps.

2010-04-19 Thread Alexandre Julliard
Paul Chitescu writes: > This patch is somehow b0rked in CVS. regexp.c and tests/regexp.js were > commited and then reverted. > > Is it possible to have them synched back to git? I've disabled the updates for now, until I can find the time to look into what happened here. -- Alexandre Julliard

wine in press

2010-04-19 Thread Stefan Leichter
Hi, while reading the german heise news i came across an article about wine. Luckily there is an english version too: http://www.h-online.com/open/news/item/Wine-update-improves-Direct3D-and-64-bit-support-980599.html german version: http://www.heise.de/open/meldung/Wine-mit-verbesserter-3D-u

Re: Benchmarking D3D?

2010-04-19 Thread Roderick Colenbrander
On Mon, Apr 19, 2010 at 1:44 PM, Stefan Dösinger wrote: > > Am 18.04.2010 um 20:42 schrieb Roderick Colenbrander: >> Implementation details aside it would be very useful if a mechanism >> can take advantage of GPU monitor APIs like the ones from nvidia >> perfkit and GL_AMD_performance_monitor. Th

Re: Jacek Caban : jscript: Fixed String. match implementation for non-global regexps.

2010-04-19 Thread Paul Chitescu
On Thursday 15 April 2010 07:37:36 pm Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 6f17fa5298449114a8532778b8a6c0f8a5c505de > URL: http://source.winehq.org/git/wine.git/?a=commit;h=6f17fa5298449114a8532778b8a6c0f8a5c505de > > Author: Jacek Caban > Date: Thu Apr 15 12:

Re: ISP causes winhttp test failures

2010-04-19 Thread Austin English
On Mon, Apr 19, 2010 at 7:18 AM, Michael Stefaniuc wrote: > Stefan Dösinger wrote: >> Am 18.04.2010 um 22:15 schrieb Marcus Meissner: >>> Does >>> >>> notexist.example.com  work? >> $ ping notexist.example.com >> ping: unknown host notexist.example.com >> >> Looks good. And beyond that, anything t

Re: Future of the WWN

2010-04-19 Thread Edward Savage
On Tue, Apr 20, 2010 at 12:24 AM, Zachary Goldberg wrote: > Hey folks. > > I plan on releasing one WWN per Wine release which > at a minimum will include a very short news section and the > bugzilla/appdb stats.  I will also be "crown sourcing" news via the > Wine Wiki: http://wiki.winehq.org/Rece

Future of the WWN

2010-04-19 Thread Zachary Goldberg
Hey folks. I plan on releasing one WWN per Wine release which at a minimum will include a very short news section and the bugzilla/appdb stats. I will also be "crown sourcing" news via the Wine Wiki: http://wiki.winehq.org/RecentNewsQueue. If you would like to get a news article into the WWN ple

Re: winmm: Rewrite time.c using windows timer queues

2010-04-19 Thread Alexandre Julliard
Maarten Lankhorst writes: > @@ -50,16 +33,14 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(mmtime); > > -typedef struct tagWINE_TIMERENTRY { > -struct list entry; > -UINTwDelay; > -UINTwResol; > -LPTIMECALLBACK

Re: [PATCH 4/5] shlwapi: Implement SHCreateThreadRef

2010-04-19 Thread Alexandre Julliard
Detlef Riekenberg writes: > @@ -120,6 +120,89 @@ typedef struct tagSHLWAPI_THREAD_INFO >IUnknown *refIE; /* Reference to the IE process */ > } SHLWAPI_THREAD_INFO, *LPSHLWAPI_THREAD_INFO; > > +typedef struct > +{ > + void* lpVtbl; > + LONG *ref; > +} threadref; You

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

2010-04-19 Thread Tony Wasserka
> +static inline void check_ref(IUnknown *obj, int exp) > +static inline void check_release(IUnknown *obj, int exp) We shouldn't use these function definitions anymore IMO, either do the ref check in the code itself, or replace the check_ref and check_release functions with macros; the reason is

Re: [4/6] msi: Add beginnings of a test module that concentrates on patches.

2010-04-19 Thread Greg Geldorp
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1590 Your paranoid android.

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more

2010-04-19 Thread Maarten Lankhorst
Hi Marcus, 2010/4/19 Marcus Meissner : > Hi, > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > For MMX/SSE operations we however need to have the stack aligned > to 16 (2^4). > > So specify this explicitly. > > (This should probably be even part of attribute((stdcall)) perhaps

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more

2010-04-19 Thread Alexandre Julliard
Marcus Meissner writes: > This is not going to fly, as I very much doubt we will be able to > convince them. > > Do we have examples of Linux code that doesn't do it? > > They have their call chain adjusted to have 16 byte alignment and only > ensure this for main() and so suggest to the develope

Re: ISP causes winhttp test failures

2010-04-19 Thread Michael Stefaniuc
Stefan Dösinger wrote: > Am 18.04.2010 um 22:15 schrieb Marcus Meissner: >> Does >> >> notexist.example.com work? > $ ping notexist.example.com > ping: unknown host notexist.example.com > > Looks good. And beyond that, anything that doesn't start with www behaves > properly too: > > $ ping www

Re: Benchmarking D3D?

2010-04-19 Thread Stefan Dösinger
Am 18.04.2010 um 20:42 schrieb Roderick Colenbrander: > Implementation details aside it would be very useful if a mechanism > can take advantage of GPU monitor APIs like the ones from nvidia > perfkit and GL_AMD_performance_monitor. This would also allow us to > monitor what is holding up the GPU.

d3dx9: Add a stubbed D3DXDeclaratorFromFVF

2010-04-19 Thread David Adam
Hi, patch from Tony Wasserka. A+ David 0001-Add-a-stubbed-D3DXDeclaratorFromFVF.patch Description: Binary data

Re: ISP causes winhttp test failures

2010-04-19 Thread Stefan Dösinger
Am 18.04.2010 um 22:15 schrieb Marcus Meissner: > Does > > notexist.example.com work? $ ping notexist.example.com ping: unknown host notexist.example.com Looks good. And beyond that, anything that doesn't start with www behaves properly too: $ ping www.srevaewedoc.com PING www.srevaewedoc.co

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

2010-04-19 Thread paulo lesgaz
Maybe this function should be in util.c. A+ David --- En date de : Lun 19.4.10, Henri Verbeet a écrit : De: Henri Verbeet Objet: Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests À: wine-devel@winehq.org Date: Lundi 19 avril 2010, 11h43 On 19 April 2010 09:43, Christian C

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

2010-04-19 Thread Ben Klein
On 19 April 2010 19:43, Henri Verbeet wrote: > On 19 April 2010 09:43, Christian Costa wrote: >> +BOOL is_pow2(UINT num) >> +{ >> +    UINT i; >> + >> +    if (!num) return FALSE; >> +    for (i = 0; num >> 1; i++) num >>= 1; >> + >> +    return (num << i) == num; >> +} > This should at least be

Re: [8/11] shell32: Complete IFolderView::ItemCount() implementation

2010-04-19 Thread Greg Geldorp
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1576 Your paranoid android.

Re: [5/11] shell32: Load shell folder column names as A/W strings depending on 9x/NT selector

2010-04-19 Thread Greg Geldorp
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1574 Your paranoid android.

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

2010-04-19 Thread Henri Verbeet
On 19 April 2010 09:43, Christian Costa wrote: > +BOOL is_pow2(UINT num) > +{ > +UINT i; > + > +if (!num) return FALSE; > +for (i = 0; num >> 1; i++) num >>= 1; > + > +return (num << i) == num; > +} This should at least be static. You can also just replace it with "return !(num & (

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more

2010-04-19 Thread Marcus Meissner
On Mon, Apr 19, 2010 at 11:10:54AM +0200, Alexandre Julliard wrote: > Marcus Meissner writes: > > > Hi, > > > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > > For MMX/SSE operations we however need to have the stack aligned > > to 16 (2^4). > > > > So specify this explicitly.

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more

2010-04-19 Thread Alexandre Julliard
Marcus Meissner writes: > Hi, > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > For MMX/SSE operations we however need to have the stack aligned > to 16 (2^4). > > So specify this explicitly. > > (This should probably be even part of attribute((stdcall)) perhaps > in gcc. Not

Re: TestBot changes

2010-04-19 Thread Paul Vriens
Hi Ge, On 04/19/2010 10:18 AM, Greg Geldorp wrote: Hi Paul, From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] On 04/19/2010 09:46 AM, Greg Geldorp wrote: - Skip tests if required DLL is not available Winetest.exe has some extra testing for com and .net provided dll's. Does the testbot t

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more

2010-04-19 Thread Marcus Meissner
On Sun, Apr 18, 2010 at 04:28:54PM -0600, Charles Davis wrote: > On 4/18/10 4:17 PM, Marcus Meissner wrote: > > Hi, > > > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > > For MMX/SSE operations we however need to have the stack aligned > > to 16 (2^4). > > > > So specify this

RE: TestBot changes

2010-04-19 Thread Greg Geldorp
Hi Paul, > From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] > > On 04/19/2010 09:46 AM, Greg Geldorp wrote: > > - Skip tests if required DLL is not available > > Winetest.exe has some extra testing for com and .net provided dll's. > Does the testbot take this into account as well? I starte

Re: TestBot changes

2010-04-19 Thread Paul Vriens
On 04/19/2010 09:46 AM, Greg Geldorp wrote: I've made a bunch of changes to TestBot, aimed at improving its reliability for processing wine-patches submissions and preventing false positives (where the bot incorrectly claims a patch introduces a new failure.) For the moment it won't send error re

TestBot changes

2010-04-19 Thread Greg Geldorp
I've made a bunch of changes to TestBot, aimed at improving its reliability for processing wine-patches submissions and preventing false positives (where the bot incorrectly claims a patch introduces a new failure.) For the moment it won't send error reports directly to wine-devel, instead it sends