On 7/18/2010 10:17, Austin English wrote:
Passed all the vm's on wtb.
Hi, Austin. This looks strange:
+
+hFile = CreateFileA("c:\\*.*",
GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,FILE_ATTRIBUTE_NORMAL,NULL );
+ok(GetLastError() == ERROR_INVALID_NAME || broken(GetLastError() ==
James wrote:
> This whole line of thought was rejected, at least once.
Yes, but see his later patchset. I think he's
now just trying to provide a uniform abstraction for the existing
ad-hoc single-shot FIXMEs without adding any new ones,
following Henri's advice in
http://www.winehq.org/pipermail
On Sat, Jul 17, 2010 at 11:32 PM, Dmitry Timoshkov
wrote:
>
> Testing other values besides 0 would be helpful, in particular values like
> sizeof(class) - 1 and sizeof(class) + 1. Did you inspect all the places
> in Wine which call RegisterClassEx()? Also, GetClassInfoEx() in Wine is an
> obvious
Dylan Smith wrote:
> +wcexA.cbSize= 0;
> +wcexA.style = cls.style;
> +wcexA.lpfnWndProc = cls.lpfnWndProc;
> +wcexA.cbClsExtra= cls.cbClsExtra;
> +wcexA.cbWndExtra= cls.cbWndExtra;
> +wcexA.hInstance = cls.hInstance;
> +wcexA.hIcon
Max TenEyck Woodbury wrote:
---
dlls/user.exe16/user.c | 48
1 files changed, 24 insertions(+), 24 deletions(-)
This whole line of thought was rejected, at least once. What is your
justification to add this to the project. This should be
On Sat, Jul 17, 2010 at 1:29 AM, Max TenEyck Woodbury
wrote:
> +#define WINE_FIXME_ONCE(args...) do { } while(0)
> +#define WINE_FIXME_ONCE_ONCE_(ch) WINE_FIXME_ONCE
I think you want WINE_FIXME_ONCE_ not WINE_FIXME_ONCE_ONCE_.
> +#define WINE_FIXME_ONCE(args...) do { } while(0)
> +#define WINE_FI
On Sat, Jul 17, 2010 at 7:02 AM, Pigeon wrote:
>
> WSASendTo/WSARecvFrom, wrapped in a different function name, so that
> internal calls from ws2_32 itself will not trigger programs like Garena,
> which catches WSASendTo/WSARecvFrom calls.
>
> Reference: Wine Bug Id #16047
>
> ---
> dlls/ws2_32/s
Let me know what you guys think of this one, I think it will be
somewhat controversial. There is a registry key to enable this
currently, but it should really occur by default and maybe be
unchangeable. If you have multiple cards, like a USB mic for capture,
scan_devices to 0, as would occur on ma
On Sat, Jul 17, 2010 at 6:02 AM, Pigeon wrote:
>
> WSASendTo/WSARecvFrom, wrapped in a different function name, so that
> internal calls from ws2_32 itself will not trigger programs like Garena,
> which catches WSASendTo/WSARecvFrom calls.
>
> Reference: Wine Bug Id #16047
>
> ---
Need your real
On 17 July 2010 09:07, Andrey Turkin wrote:
> +#ifdef NONAMELESSUNION
> +# define U(x) (x).u
> +#else
> +# define U(x) (x)
> +#endif
I think this is already done in wine/test.h?
> +static BOOL WINAPI accumulating_stream_output(DIGEST_HANDLE handle, BYTE *pb,
> + DWORD cb)
"pb" can probably be c
On 17 July 2010 09:06, Andrey Turkin wrote:
> +if (nt->OptionalHeader.FileAlignment <= 0)
I can't comment much on the changes themselves, but FileAlignment is
unsigned, so can't be < 0.
On 17 July 2010 12:43, Florian Köberle wrote:
> diff --git a/dlls/wined3d/swapchain_base.c b/dlls/wined3d/swapchain_base.c
> index 1817de2..3f2a4e5 100644
> --- a/dlls/wined3d/swapchain_base.c
> +++ b/dlls/wined3d/swapchain_base.c
> @@ -131,7 +131,7 @@ HRESULT WINAPI
> IWineD3DBaseSwapChainImpl_G
On 17 July 2010 12:43, Florian Köberle wrote:
> + if ((caps.Caps & D3DCAPS_READ_SCANLINE) == 0) {
> + ZeroMemory( &rasterStatus, sizeof(rasterStatus) );
> + hr = IDirect3DDevice9_GetRasterStatus(pDevice, 0, &rasterStatus);
> + todo_wine
> + ok(hr == D3DERR_INVALIDCAL
On 17 July 2010 13:28, Jacek Caban wrote:
> +}else if(V_VT(v1) == VT_EMPTY) {
> +*cmp = V_VT(v1) == VT_EMPTY ? 0 : 1;
That looks wrong, should that read "*cmp = V_VT(v2) == VT_EMPTY ? 0 :
1;" instead?
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3425
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3423
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3421
Your paranoid android.
On Saturday 17 July 2010 18:19:50 Dan Kegel wrote:
> I was worried that mapping the file will fail if you're
> low on address space and are running this function
> on a large PE file.
> It ought to be possible to write a test to see how
> the function behaves when you've used up oodles
> of address
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3426
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3424
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3422
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3417
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3418
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3419
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3420
Your paranoid android.
On Sat, 2010-07-17 at 15:39 +0200, Frédéric Delanoy wrote:
> On Sat, Jul 17, 2010 at 14:43, Misha Koshelev wrote:
> > On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote:
> >> Misha Koshelev wrote:
> > p.s. Do I remember correctly AJ does not commit on weekends?
>
> Exactly. 5 times a week sh
On 7/17/2010 21:20, David Hedberg wrote:
Thanks for the pointers, I'll see if I can expand the tests somewhat
and send a new version, probably simply using the local SetStyle
helper (unless the tests shows something really weird).
I realized that probably not all modes could be supported with v5
On Sat, Jul 17, 2010 at 8:04 AM, Jeff Cook wrote:
> ---
> dlls/winealsa.drv/waveinit.c | 4
> 1 files changed, 4 insertions(+), 0 deletions(-)
Patches should be sent to wine-patches, not wine-devel. Unless you're
asking for comments/review.
--
-Austin
On Sat, Jul 17, 2010 at 5:51 PM, Nikolay Sivov wrote:
> On 7/17/2010 19:45, David Hedberg wrote:
>>
>> On Sat, Jul 17, 2010 at 5:30 PM, Nikolay Sivov
>> wrote:
>>>
>>> On 7/17/2010 19:08, David Hedberg wrote:
static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface,
UI
On 7/17/2010 19:45, David Hedberg wrote:
On Sat, Jul 17, 2010 at 5:30 PM, Nikolay Sivov wrote:
On 7/17/2010 19:08, David Hedberg wrote:
static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UINT
mode)
{
- IShellViewImpl *This = impl_from_IFolderView(iface);
- F
On Sat, Jul 17, 2010 at 5:30 PM, Nikolay Sivov wrote:
> On 7/17/2010 19:08, David Hedberg wrote:
>>
>> static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UINT
>> mode)
>> {
>> - IShellViewImpl *This = impl_from_IFolderView(iface);
>> - FIXME("(%p)->(%u), stub\n", Th
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3414
Your paranoid android.
On 7/17/2010 19:08, David Hedberg wrote:
+static HRESULT WINAPI ISF_Desktop_IPersistFolder2_fnInitialize(
+IPersistFolder2 *iface, LPCITEMIDLIST pidl)
+{
+FIXME("Not implemented.\n");
+return E_NOTIMPL;
Call it just "stub" and dump parameters please.
+
+pidl = NULL;
+
On 7/17/2010 19:08, David Hedberg wrote:
static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UINT mode)
{
- IShellViewImpl *This = impl_from_IFolderView(iface);
- FIXME("(%p)->(%u), stub\n", This, mode);
- return E_NOTIMPL;
+IShellViewImpl *This = im
Hi Max
Welcome to Wine.
Your Patch "[Add '_ONCE' variants of DPRINTF, FIXME, WARN.]"
( http://source.winehq.org/patches/data/63503 )
has a typo near the end:
#define ERR_ONCE WINE_ERR_ONCEE
--
By by ... Detlef
___
Neu:
I was worried that mapping the file will fail if you're
low on address space and are running this function
on a large PE file.
It ought to be possible to write a test to see how
the function behaves when you've used up oodles
of address space, though it'd be tricky to make
the test reliable.
I see
On Sat, 17 Jul 2010 10:43:00 +0200
Gert van den Berg wrote:
> It might be a good idea to try and get most potential bug reports
> discussed on the forum first?
>
That's what I meant when I suggested adding a line above the comment box (or
anywhere on the page that seems suitable). Some users
On Sat, Jul 17, 2010 at 14:43, Misha Koshelev wrote:
> On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote:
>> Misha Koshelev wrote:
> p.s. Do I remember correctly AJ does not commit on weekends?
Exactly. 5 times a week should be sufficient ;)
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3405
Your paranoid android.
---
dlls/winealsa.drv/waveinit.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/dlls/winealsa.drv/waveinit.c b/dlls/winealsa.drv/waveinit.c
index 4da53c9..4ae93bb 100644
--- a/dlls/winealsa.drv/waveinit.c
+++ b/dlls/winealsa.drv/waveinit.c
@@ -106,6 +106,10 @@ static
This patch fixes bug #12706 and creates a mixer for snd-usb-audio cards,
which have only a single Mic control and nothing else. Subsequent
patches may be needed to make this useful depending on configuration.
I am including this here for commentary before I submit to wine-patches.
This is my f
Hello
my first mail with the 1.4 MB attachment got luckily filtered by the
mailinglist. This is a slightly modified version of it:
According to the MSDN GetRasterStatus should return D3DERR_INVALIDCALL
if the flag D3DCAPS_READ_SCANLINE isn't set [0].
I wrote a test which tests exactly that stat
On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote:
> Misha Koshelev wrote:
> > Dear All:
> >
> > Congrats on 1.2!
> >
> > I have begun sending my patches from my repository:
> > http://github.com/misha680/wine/commits/master
> >
> >
> Misha:
>
> Might I make a tiny suggestion: Send in on
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3401
Your paranoid android.
On Sat, Jul 17, 2010 at 01:21:19PM +0200, Marcus Meissner wrote:
> ---
> news/de/2010071601.xml |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/news/de/2010071601.xml b/news/de/2010071601.xml
> index b521984..5dc2a1a 100644
> --- a/news/de/2010071601.xml
> +++ b/n
On 17 July 2010 16:07, Scott Ritchie wrote:
> On 07/16/2010 11:22 AM, Alexandre Julliard wrote:
>> Folks,
>>
>> First I want to thank everybody for your great work of the past two
>> years. I'm very happy with what we have achieved with 1.2 (even if we
>> didn't manage to get the regression number
---
dlls/d3d9/tests/device.c |1 -
dlls/wined3d/swapchain_base.c |2 +-
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c
index 0acedcb..2345c34 100644
--- a/dlls/d3d9/tests/device.c
+++ b/dlls/d3d9/tests/device.c
@@ -27
---
dlls/d3d9/tests/device.c | 53 ++
1 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c
index ba25760..0acedcb 100644
--- a/dlls/d3d9/tests/device.c
+++ b/dlls/d3d9/tests/device.c
@@ -27
Sorry for the big attachment, didn't realize that crosstests executables
are so large.
On Sat, Jul 17, 2010 at 10:27, David Gerard wrote:
> You are going to get noise. Stopping people reporting bugs is probably
> not the answer. It's hard enough to get bug reports out of people
> already.
A "Where do I" (of "What do I do when...") section in the FAQ
might help in some cases? (w
On 17 July 2010 03:56, James McKenzie wrote:
> Does this sound doable and is it permissible? I don't want folks walking
> away because they cannot post, but if they are posting garbage it doesn't
> help us.
It depends also on the balance you want between
(a) the possibility of a bad comment o
51 matches
Mail list logo
