Re: Add Intel GM45 detection

2010-09-15 Thread Dmitry Timoshkov
Jaime Rave wrote: > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -1109,7 +1109,8 @@ static const struct gpu_description > gpu_description_table[] = > {HW_VENDOR_INTEL, CARD_INTEL_I915G, "Intel(R) > 82915G/GV/910GL Express Chipset Family", DR

Re: msxml3/tests: Skip tests if IXMLDOMDocument2 can't be obtained

2010-09-15 Thread Nikolay Sivov
On 9/16/2010 02:27, Nikolay Sivov wrote: This is supposed to fix test bot failures. Please ignore this one.

Re: WineAPI wiki progress (resent)

2010-09-15 Thread Max TenEyck Woodbury
On 09/15/2010 10:47 PM, Max TenEyck Woodbury wrote: Actually, that was a mistake on my part. If you use: https://sourceforge.net/apps/mediawiki/wineapi/index.php you can skip the login. ARGH! Make that: http://sourceforge.net/apps/mediawiki/wineapi/index.php - Max

Re: WineAPI wiki progress (resent)

2010-09-15 Thread Max TenEyck Woodbury
On 09/15/2010 10:56 AM, Francois Gouget wrote: On Wed, 15 Sep 2010, Max TenEyck Woodbury wrote: The previous version ended up as a reply to something inappropriate. The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository wit

Re: WineAPI wiki progress (resent)

2010-09-15 Thread Max TenEyck Woodbury
On 09/15/2010 10:25 AM, GOUJON Alexandre wrote: On 09/15/2010 03:32 PM, Max TenEyck Woodbury wrote: The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository with classifications of the directory content. Well, to be frank, I

Re: d3dx9_36: Implement D3DXCreateMesh and initial ID3DXMesh methods. (try 3)

2010-09-15 Thread misha680
Henri Verbeet wrote: > > On 15 September 2010 01:55, Misha Koshelev wrote: >> +while (count < MAX_FVF_DECL_SIZE && (count == 0 || >> declaration[count-1].Stream != 0xFF)) >> +{ >> +count++; >> +} > ...and similarly you'd want to use D3DXGetDeclLength() here, though I > wonde

Re: msxml3/tests: Skip tests if IXMLDOMDocument2 can't be obtained

2010-09-15 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5250 Your paranoid android.

Re: [PATCH] [Server]: ensure we set proper errors when getting a NULL fd out of a handle

2010-09-15 Thread Alexandre Julliard
Eric Pouech writes: > (would hang for example server_get_unix_fd when an improper handle was > passed, as no error > was returned from server call) > Fix for #24394. The individual get_fd() functions are supposed to set the appropriate error when returning NULL. -- Alexandre Julliard julli...

Re: ddraw: Allow creating back buffer for DirectX 1 interfaces.

2010-09-15 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5248 Your paranoid android.

Re: msxml3: Implement property SelectionNamespaces for XPath (try #3/resend)

2010-09-15 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5247 Your paranoid android.

Re: intention of stubs with arch flag, specially in msvcp*

2010-09-15 Thread André Hentschel
Am 15.09.2010 19:44, schrieb Alexandre Julliard: > André Hentschel writes: > >> The last one silently gets ignored, but the one with the arch flag causes >> winebuild >> to put some extra assembler code into the dll. >> >> So is this intented? > > No. Try something like this: > > diff --git a/

Re: [Patch 5/5] Add some more schannel tests

2010-09-15 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5246 Your paranoid android.

Re: intention of stubs with arch flag, specially in msvcp*

2010-09-15 Thread Alexandre Julliard
André Hentschel writes: > The last one silently gets ignored, but the one with the arch flag causes > winebuild > to put some extra assembler code into the dll. > > So is this intented? No. Try something like this: diff --git a/tools/winebuild/parser.c b/tools/winebuild/parser.c index bc483c9.

intention of stubs with arch flag, specially in msvcp*

2010-09-15 Thread André Hentschel
Hi all, I used to think the arch flag is only used to say "this function is only available on win32" or to say the same for win64. We do that e.g. in msvcp* dlls. So i am not sure why those stubs like @ stub -arch=win32 function differ so heavy from stubs like @ stub function The last

Re: Different Wine FAQs on winehq

2010-09-15 Thread Austin English
2010/9/15 Frédéric Delanoy : > A STFW for wine faq gives as first result this page > > http://www.winehq.org/site/docs/wine-faq/index (old version of the FAQ) > > instead of > > http://wiki.winehq.org/FAQ (linked from home > support) > > The former contains some outdated information. Shouldn't it b

Re: WineAPI wiki progress (resent)

2010-09-15 Thread Francois Gouget
On Wed, 15 Sep 2010, Max TenEyck Woodbury wrote: > The previous version ended up as a reply to something inappropriate. > > The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php > now has pages for the directories in the Wine Repository with > classifications of the directory conte

Re: [msxml3/tests] Step to the next item on failure as well

2010-09-15 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5243 Your paranoid android.

Re: WineAPI wiki progress (resent)

2010-09-15 Thread Reece Dunn
On 15 September 2010 15:25, GOUJON Alexandre wrote: > On 09/15/2010 03:32 PM, Max TenEyck Woodbury wrote: >> >> The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php >> now has pages for the directories in the Wine Repository with >> classifications of the directory content. > > Wel

Re: WineAPI wiki progress (resent)

2010-09-15 Thread GOUJON Alexandre
On 09/15/2010 03:32 PM, Max TenEyck Woodbury wrote: The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository with classifications of the directory content. Well, to be frank, I don't like the structure. Doxygen is able to prod

Re: [4/4] msxml3: Properly set default value for SelectionLanguage property

2010-09-15 Thread Paul Vriens
On 09/15/2010 04:11 PM, Paul Vriens wrote: On 09/14/2010 07:20 AM, Nikolay Sivov wrote: Properly set default value for SelectionLanguage property Hi Nikolay, I wondered why there were only a few testbot reports on test.winehq.org. Looking at the reports on test.winehq.org (I have an account)

Different Wine FAQs on winehq

2010-09-15 Thread Frédéric Delanoy
A STFW for wine faq gives as first result this page http://www.winehq.org/site/docs/wine-faq/index (old version of the FAQ) instead of http://wiki.winehq.org/FAQ (linked from home > support) The former contains some outdated information. Shouldn't it be suppressed (after a check to see if does

Re: [4/4] msxml3: Properly set default value for SelectionLanguage property

2010-09-15 Thread Paul Vriens
On 09/14/2010 07:20 AM, Nikolay Sivov wrote: Properly set default value for SelectionLanguage property Hi Nikolay, I wondered why there were only a few testbot reports on test.winehq.org. Looking at the reports on test.winehq.org (I have an account) shows that the reports are filled (12000+

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-15 Thread Marko Nikolic
Henri Verbeet wrote: > On 14 September 2010 15:44, Mike Frysinger wrote: >> note: i couldnt find a statement of what C standard wine aims for. if >> it is attempting pre-c99, then this will have to be done differently. >> perhaps introducing a project-wide define like "VARARRAY" which >> expands

Re: user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without an IDOK

2010-09-15 Thread Vladimir Panteleev
Hello Dmitry, Wednesday, September 15, 2010, 11:30:38 AM, you wrote: > It's better, but since BN_CLICKED is 0, there is no need to introduce wParam. I reduced the patch to two lines (it's not visible from the context, but there's a "return TRUE" lower to make up for the removed one). Hopefully i

Re: user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without an IDOK

2010-09-15 Thread Vladimir Panteleev
Hello Dmitry, Wednesday, September 15, 2010, 10:35:20 AM, you wrote: > It would be cleaner to use an existing SendMessage() instead of > introducing a duplicate. How does this look? I took the opportunity to remove the duplicate "GetDlgItem(hwndDlg, LOWORD(dw))". -- Best regards, Vladimir

WineAPI wiki progress (resent)

2010-09-15 Thread Max TenEyck Woodbury
The previous version ended up as a reply to something inappropriate. The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository with classifications of the directory content. Please take a look at it and tell me if you think the

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Marcus Meissner
On Wed, Sep 15, 2010 at 12:40:46PM +0100, Huw Davies wrote: > On Wed, Sep 15, 2010 at 01:34:06PM +0200, Marcus Meissner wrote: > > On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote: > > > On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > > > > Marcus Meissner wrote: > >

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Huw Davies
On Wed, Sep 15, 2010 at 01:34:06PM +0200, Marcus Meissner wrote: > On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote: > > On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > > > Marcus Meissner wrote: > > > > > > > + if (!unk) { > > > > + FIXME("hr was %d, but unk i

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Marcus Meissner
On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote: > On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > > Marcus Meissner wrote: > > > > > + if (!unk) { > > > + FIXME("hr was %d, but unk is NULL?\n", hr); > > > + return E_FAIL; > > > + } > > > > IDropTarget_

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Marcus Meissner
On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > + if (!unk) { > > + FIXME("hr was %d, but unk is NULL?\n", hr); > > + return E_FAIL; > > + } > > IDropTarget_QueryInterface() should be fixed instead. I am not sure where where the DropT

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Huw Davies
On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > + if (!unk) { > > + FIXME("hr was %d, but unk is NULL?\n", hr); > > + return E_FAIL; > > + } > > IDropTarget_QueryInterface() should be fixed instead. The implementation is in abiword, s

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Dmitry Timoshkov
Marcus Meissner wrote: > + if (!unk) { > + FIXME("hr was %d, but unk is NULL?\n", hr); > + return E_FAIL; > + } IDropTarget_QueryInterface() should be fixed instead. -- Dmitry.

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-15 Thread Henri Verbeet
On 15 September 2010 12:22, Henri Verbeet wrote: > On 14 September 2010 15:44, Mike Frysinger wrote: >> note: i couldnt find a statement of what C standard wine aims for.  if >>        it is attempting pre-c99, then this will have to be done differently. >>        perhaps introducing a project-wi

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-15 Thread Henri Verbeet
On 14 September 2010 15:44, Mike Frysinger wrote: > note: i couldnt find a statement of what C standard wine aims for.  if >        it is attempting pre-c99, then this will have to be done differently. >        perhaps introducing a project-wide define like "VARARRAY" which >        expands into [

Re: d3dx9_36: Implement D3DXCreateMesh and initial ID3DXMesh methods. (try 3)

2010-09-15 Thread Henri Verbeet
On 15 September 2010 01:55, Misha Koshelev wrote: > +while (count < MAX_FVF_DECL_SIZE && (count == 0 || > declaration[count-1].Stream != 0xFF)) > +{ > +count++; > +} ...and similarly you'd want to use D3DXGetDeclLength() here, though I wonder if implementing DrawSubset() isn't

Re: user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without an IDOK

2010-09-15 Thread Dmitry Timoshkov
Vladimir Panteleev wrote: > I reduced the patch to two lines (it's not visible from the context, > but there's a "return TRUE" lower to make up for the removed one). > Hopefully it's not too cryptic now. Thanks for the feedback. Looks good to me. -- Dmitry.

Re: user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without an IDOK

2010-09-15 Thread Dmitry Timoshkov
Vladimir Panteleev wrote: > How does this look? I took the opportunity to remove the duplicate > "GetDlgItem(hwndDlg, LOWORD(dw))". It's better, but since BN_CLICKED is 0, there is no need to introduce wParam. -- Dmitry.

Re: user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without an IDOK

2010-09-15 Thread Dmitry Timoshkov
Vladimir Panteleev wrote: > diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c > index aac8a4d..ee99710 100644 > --- a/dlls/user32/dialog.c > +++ b/dlls/user32/dialog.c > @@ -1221,6 +1221,11 @@ BOOL WINAPI IsDialogMessageW( HWND hwndDlg, LPMSG msg ) > else if (DC_HASDEFID =