Re: [1/2] user32: fix FindWindowEx behavior if window name is an empty charachter

2010-10-04 Thread Dmitry Timoshkov
Louis Lenders wrote: > @@ -1756,6 +1756,10 @@ HWND WINAPI FindWindowExW( HWND parent, HWND child, > LPCWSTR className, LPCWSTR t > { > while (list[i]) > { > +/* Handle special case where empty title bar or no title bar > exists, so GetWindowsText would return

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)

2010-10-04 Thread Mike Kaplinskiy
On Mon, Oct 4, 2010 at 2:18 PM, Rudolf Mayerhofer wrote: >>I don't know much about kernel32/ntdll, but I'm pretty sure that you >>could get this to work through ntdll. NtQuerySystemInformation with >>SystemProcessorInformation/SystemLogicalProcessorInformation (see >>http://undocumented.ntinternal

Re: psapi/tests: macro cleanup

2010-10-04 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5813 Your paranoid android.

Re: [PATCH] comctl32/tests: Add tests for negative subitems independent of local settings

2010-10-04 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5811 Your paranoid android.

Re: [2/2] user32/tests: Test FindWindowEx for empty window title

2010-10-04 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5803 Your paranoid android.

Re: [PATCH 2/3] urlmon: Added Abort tests.

2010-10-04 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5782 Your paranoid android.

Re: [PATCH 3/3] urlmon: Added Abort support to BindProtocol.

2010-10-04 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5783 Your paranoid android.

Re: cryptui: Fix a crash with certification path

2010-10-04 Thread Juan Lang
Hi André, I see your patch didn't get committed. In case it's waiting for a comment from me, it looks fine: I assume you've imported a certificate that isn't otherwise trusted, and viewing it results in a crash? I don't see the crash here. Thanks, --Juan

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)

2010-10-04 Thread Rudolf Mayerhofer
>I don't know much about kernel32/ntdll, but I'm pretty sure that you >could get this to work through ntdll. NtQuerySystemInformation with >SystemProcessorInformation/SystemLogicalProcessorInformation (see >http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/System%20Information/S

Re: include: Added d3d10_1.idl.

2010-10-04 Thread Rico Schüller
Am 04.10.2010 18:35, schrieb Jacek Caban: On 10/3/10 5:44 PM, Rico Schüller wrote: Am 02.10.2010 15:29, schrieb Jacek Caban: +typedef enum D3D10_SRV_DIMENSION1 +{ +D3D10_1_SRV_DIMENSION_UNKNOWN = 0, ... +D3D10_1_SRV_DIMENSION_TEXTURECUBE = 9, +D3D10_1_SRV_DIMENSION_

Re: include: Added d3d10_1.idl.

2010-10-04 Thread Jacek Caban
On 10/3/10 5:44 PM, Rico Schüller wrote: Am 02.10.2010 15:29, schrieb Jacek Caban: +typedef enum D3D10_SRV_DIMENSION1 +{ +D3D10_1_SRV_DIMENSION_UNKNOWN = 0, ... +D3D10_1_SRV_DIMENSION_TEXTURECUBE = 9, +D3D10_1_SRV_DIMENSION_TEXTURECUBEARRAY = 10 +} D3D10_SRV_DIMENSI

Re: winspool.drv: return maximum possible size of the buffer when no buffer specified

2010-10-04 Thread Vitaly Perov
On Monday 04 October 2010 19:03:21 Alexandre Julliard wrote: > Vitaly Perov writes: > > @@ -1398,7 +1398,7 @@ static void convert_printerinfo_W_to_A(LPBYTE out, > > LPBYTE pPrintersW, dmA = DEVMODEdupWtoA(piW->pDevMode); > > if (dmA) { > > /* align DEV

Re: psapi/tests: remove an ugly macro

2010-10-04 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5776 Your paranoid android.

Re: winspool.drv: return maximum possible size of the buffer when no buffer specified

2010-10-04 Thread Alexandre Julliard
Vitaly Perov writes: > @@ -1398,7 +1398,7 @@ static void convert_printerinfo_W_to_A(LPBYTE out, > LPBYTE pPrintersW, > dmA = DEVMODEdupWtoA(piW->pDevMode); > if (dmA) { > /* align DEVMODEA to a DWORD boundary */ > -

Re: cmd: Add a space at the end of the first echo'ed batch line [try2]

2010-10-04 Thread Alexandre Julliard
Alexandre Goujon writes: > -...@pwd@>echo Tests for cmd's builtin comma...@todo_space@ > +...@pwd@>echo Tests for cmd's builtin commands You'll need to define a @space@ symbol, normal trailing spaces will get mangled. -- Alexandre Julliard julli...@winehq.org

Re: winex11: choose header exclusiv

2010-10-04 Thread Alexandre Julliard
André Hentschel writes: > @@ -29,8 +29,7 @@ > > #ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H > #include > -#endif > -#ifdef HAVE_X11_EXTENSIONS_XF86VMPROTO_H > +#elif defined (HAVE_X11_EXTENSIONS_XF86VMPROTO_H) > #include > #endif This doesn't make sense, all it will most likely achieve is to

Re: New version of exe-thumbnailer (0.7)

2010-10-04 Thread Octavian Voicu
On Mon, Oct 4, 2010 at 5:07 AM, Nicholas van Oudtshoorn wrote: > Just to note, KDE/Dolphin already has built-in support for thumnbailing exe > files. (Although, in Fedora at least, it's not enabled by default; just tell > dolphin to show previews for "Microsoft Windows Executables". > > I've also

Re: New version of exe-thumbnailer (0.7)

2010-10-04 Thread Damjan Jovanovic
On Mon, Oct 4, 2010 at 4:07 AM, Nicholas van Oudtshoorn wrote: > On 10/04/2010 08:39 AM, Octavian Voicu wrote: >> >> On Fri, Oct 1, 2010 at 11:18 PM, Scott Ritchie > > wrote: >> >>    Includes much prettier icons, support for Vista icons (with icoutils >>    0.29.1) and