Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

2011-01-30 Thread Peter Schlaile
Hi Vitaliy, On Sun, 30 Jan 2011, Vitaliy Margolen wrote: On 01/30/2011 04:16 AM, Peter Schlaile wrote: Hi, find fix for a crash in create_alpha_bitmap() attached. If it's easy to reproduce please create a test that demonstrates the problem. hmm, don't know, the application that triggered

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-30 Thread Janne Hakonen
> > If I need to make changes to, say, test cases, should I also send bug fix > > patch again even if there is no changes to that? > > Please. If it is two separate patches, be sure to make it a series > (label them 1/2, 2/2) and that the tests pass before/after each patch. > Ok, thanks for the

Re: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-30 Thread Austin English
On Sun, Jan 30, 2011 at 22:15, Janne Hakonen wrote: >>Also, it is custom to mark your resubmissions with corrections as [try x]. >> Makes it easier to determine what you are doing. > I posted my patches to patches mailing list only once so far, so there > hasn't been any retries yet. > But, I shal

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-30 Thread Janne Hakonen
> Did you try this on WindowsXP or Windows7 to make sure that the win_skip did not function on those platforms? My understanding is that win_skip works on all Windows platforms not just WindowsNT or Windows2000. Well, I did test that skip doesn't happen on my home computer, whic

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

2011-01-30 Thread Vitaliy Margolen
On 01/30/2011 12:02 PM, Peter Schlaile wrote: Nevertheless: I hope, I explained pretty well, how and why the current code is wrong (aquiring a bitmap-pointer using CreateDIBSection, setting this bitmap to readonly using the fast track code path within StretchDIBits, writing to this bitmap again.)

Re: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-30 Thread James McKenzie
On 1/28/11 11:54 AM, Janne Hakonen wrote: > Now, when I ran these tests on Testbot using all base VMs, the tests were run also on W2KPROSP4 and WNT4WSSP6. However, the > function seems to buggy in those. It throws access violation whenever it is not skipping frames. > Is there some way I could

Re: [PATCH 2/2] mshtml: Added support for recursive script runners

2011-01-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8753 Your paranoid android.

Re: RFC: Adding Mac support to secur32/schannel.c

2011-01-30 Thread Henri Verbeet
On 28 January 2011 17:36, Juan Lang wrote: > What's the issue with building GnuTLS? Is it that GnuTLS doesn't > support the Mac Keychain? Is it that it's an external dependency? If > the latter, we already pull in quite a bit that isn't found on the > Mac, so the incremental change isn't large.

Re: RFC: Adding Mac support to secur32/schannel.c

2011-01-30 Thread James McKenzie
On 1/28/11 9:36 AM, Juan Lang wrote: Hi Ken, I'm planning to add an alternative implementation of schannel (SSL/TLS) support for the Mac. The current implementation is based on GnuTLS. That library is not typically found on Mac OS X. Although packagers can build it and ship it and its dep

Re: Policy regarding 3rd party "windows" distributions and winetest

2011-01-30 Thread GOUJON Alexandre
On 01/30/2011 07:27 PM, James McKenzie wrote: I think Dan Kegel does not want them in the Winetest list. I'll defer to AJ as to what HE wants. Sure ! The boss's always right. And it should be great to find a way to identify these "fake" windows. On 01/30/2011 07:29 PM, F Capela wrote: Couple

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

2011-01-30 Thread Vitaliy Margolen
On 01/30/2011 04:16 AM, Peter Schlaile wrote: Hi, find fix for a crash in create_alpha_bitmap() attached. If it's easy to reproduce please create a test that demonstrates the problem. Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but should test for alpha channel != 25

Re: Policy regarding 3rd party "windows" distributions and winetest

2011-01-30 Thread F Capela
> From: GOUJON Alexandre > > On 01/30/2011 04:47 PM, James McKenzie wrote: >> On 1/27/11 7:04 PM, Dan Kegel wrote: >>> I suspect that we should discourage people from submitting >>> winetest results from 3rd party repackagings of Microsoft Windows, >>> e.g. http://thepiratebay.org/torrent/4254053

Re: Policy regarding 3rd party "windows" distributions and winetest

2011-01-30 Thread James McKenzie
On 1/30/11 9:02 AM, GOUJON Alexandre wrote: On 01/30/2011 04:47 PM, James McKenzie wrote: On 1/27/11 7:04 PM, Dan Kegel wrote: I suspect that we should discourage people from submitting winetest results from 3rd party repackagings of Microsoft Windows, e.g. http://thepiratebay.org/torrent/42540

Re: MapleStory Wine Bug

2011-01-30 Thread James McKenzie
On 1/30/11 10:35 AM, Jack Edmonds wrote: I recently submitted a bug (http://bugs.winehq.org/show_bug.cgi?id=25934). I'm not sure if I did a good job on the submission, but if I did, I was thinking it would be a good first bug to work on so as to introduce me to the Wine source code. I was wonderi

MapleStory Wine Bug

2011-01-30 Thread Jack Edmonds
I recently submitted a bug (http://bugs.winehq.org/show_bug.cgi?id=25934). I'm not sure if I did a good job on the submission, but if I did, I was thinking it would be a good first bug to work on so as to introduce me to the Wine source code. I was wondering if someone could help me get started on

Re: user32: Replicate Windows behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*

2011-01-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8728 Your paranoid android.

Re: Wine FAQ edits

2011-01-30 Thread Vitaliy
On 01/29/2011 12:21 PM, Dan Kegel wrote: Hi Albert, http://wiki.winehq.org/FAQ?action=diff&rev2=384&rev1=383 looks like it was a pretty big edit. Try smaller ones, and try to do just one kind of change per edit. That, and the fact that some changes where questionable, and broken: -cd ~/.wine

Re: Policy regarding 3rd party "windows" distributions and winetest

2011-01-30 Thread Juan Lang
> I mean, yeah it's not legal, it's bad and what you want but what about if > they provide results that differ from the daily bot results ? So what? You know that the Windows software may have changed, and you can't replicate the results yourself (unless you also feel like breaking the law). > D

Re: Policy regarding 3rd party "windows" distributions and winetest

2011-01-30 Thread GOUJON Alexandre
On 01/30/2011 04:47 PM, James McKenzie wrote: On 1/27/11 7:04 PM, Dan Kegel wrote: I suspect that we should discourage people from submitting winetest results from 3rd party repackagings of Microsoft Windows, e.g. http://thepiratebay.org/torrent/4254053/MicroXP_v0.82_-_eXPerience Agreed? +1.

Re: Policy regarding 3rd party "windows" distributions and winetest

2011-01-30 Thread James McKenzie
On 1/27/11 7:04 PM, Dan Kegel wrote: I suspect that we should discourage people from submitting winetest results from 3rd party repackagings of Microsoft Windows, e.g. http://thepiratebay.org/torrent/4254053/MicroXP_v0.82_-_eXPerience Agreed? +1. And that is a pirate version of Windows anyway.

Re: ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces

2011-01-30 Thread James McKenzie
On 1/29/11 6:53 AM, Qian Hong wrote: Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented fu