Re: comctl32/tests: make sure to use return values (LLVM/Clang) (try 2)

2011-02-16 Thread Dmitry Timoshkov
Austin English wrote: > +r = SendMessage(hwnd, LVM_SETICONSPACING, 0, MAKELONG(100,50)); > +ok(r, "failed\n"); Please use a more informative failure message. > r = SendMessage(hwnd, WM_NOTIFYFORMAT, 0, NF_QUERY); > +todo_wine expect(2, r); 2 is NFR_UNICODE. -- Dmitry.

Re: comctl32/tests: make sure to use return values (LLVM/Clang) (1/6)

2011-02-16 Thread Austin English
On Wed, Feb 16, 2011 at 18:39, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbo

Re: comctl32/tests: make sure to use return values (LLVM/Clang) (1/6)

2011-02-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9336 Your paranoid android.

Re: [PATCH] Implement software DXT1 compression

2011-02-16 Thread alberto
>I haven't investigated very closely, but my impression is that you >want to use libsquish. I'm not sure if it has C bindings, or if the >API is entirely right for what we need, but maybe they accept patches. Yes, there are bindings, but wouldn't this pose the same legal problems as libtxc_dxtn?

Re: Anyone using Wine D3D under Parallels?

2011-02-16 Thread Misha Koshelev
On Wed, Feb 16, 2011 at 4:00 PM, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Am 16.02.2011 um 02:24 schrieb Misha Koshelev: >> What would you recommend using? Do you mean MacOS itself in this >> specific instance, or was that a general comment (i.e., use Fedora n

Re: Anyone using Wine D3D under Parallels?

2011-02-16 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 16.02.2011 um 02:24 schrieb Misha Koshelev: > What would you recommend using? Do you mean MacOS itself in this > specific instance, or was that a general comment (i.e., use Fedora not > Ubuntu). I am nowadays mostly using Linux for development, but

Re: wintrust/tests: Fix a leak (valgrind)

2011-02-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9309 Your paranoid android.

Somewhat barebones patch to implement D3DXCreateRenderToSurface for bug 24899, how much more needs to be implemented?

2011-02-16 Thread Misha Koshelev
Dear All: Looking at d3dx9 bugs, bug 24899 requires D3DXCreateRenderToSurface. This, somewhat barebones, patch, implements core functionality of D3DXCreateRenderToSurface, along with a barebones ID3DXRenderToSurface implementation. I was wondering, in order to get this patch accepted into the wi

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)

2011-02-16 Thread Nikolay Sivov
On 2/16/2011 16:19, Alexandre Julliard wrote: Nikolay Sivov writes: @@ -381,9 +386,40 @@ static HRESULT WINAPI xslprocessor_Invoke( static HRESULT WINAPI xslprocessor_put_input( IXSLProcessor *iface, VARIANT input ) { xslprocessor *This = impl_from_IXSLProcessor( iface ); +IXMLD

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)

2011-02-16 Thread Joris Huizer
Hello, I think I found a (possible) little issue in the patch: If one would pass a VARIANT of incorrect type to the xslprocessor_put_input() function (say type BSTR), the first type checks fail and leave hr uninitialised; in case it happened to have the value S_OK the other if block is skipped

Re: winmm: Simplify MCI_DumpCommandTable a bit. (RETRY)

2011-02-16 Thread Alexandre Julliard
Gerald Pfeifer writes: > Ping. Any objection to this, given that this has not been used for > quite a while? The variable is here for documentation, you don't want to remove it. You can comment it out if it's not used. -- Alexandre Julliard julli...@winehq.org

Re: gameux/gamestatistics.c: Make sure each VARIANT is cleared after use (valgrind)

2011-02-16 Thread Alexandre Julliard
Joris Huizer writes: > @@ -511,24 +511,27 @@ static HRESULT GAMEUX_loadStatisticsFromFile(struct > GAMEUX_STATS *data) > > if(SUCCEEDED(hr)) > { > -hr = IXMLDOMElement_getAttribute(categoryElement, > bstrIndex, &vValue); > -

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)

2011-02-16 Thread Alexandre Julliard
Nikolay Sivov writes: > @@ -381,9 +386,40 @@ static HRESULT WINAPI xslprocessor_Invoke( > static HRESULT WINAPI xslprocessor_put_input( IXSLProcessor *iface, VARIANT > input ) > { > xslprocessor *This = impl_from_IXSLProcessor( iface ); > +IXMLDOMNode *input_node; > +HRESULT hr; >

Re: comctl32/tests: Add casts to avoid comparison of different int types. [take 2]

2011-02-16 Thread Alexandre Julliard
Gerald Pfeifer writes: > This is the first hunk of a patch a few days ago; testbot.winehq.org > thinks it's fine: https://testbot.winehq.org/JobDetails.pl?Key=9291 You don't need casts. If the variable has the wrong type you can change that. -- Alexandre Julliard julli...@winehq.org

wine64 issues in dlls/msvcr90/tests/msvcr90.c

2011-02-16 Thread Peter Urbanec
As of a few days ago, I'm seeing the following errors when building wine64 with gcc (Gentoo 4.5.2 p1.0, pie-0.4.5) 4.5.2 dlls/msvcr90/tests/msvcr90.c:137:14: warning: 'do_call_func1' defined but not used dlls/msvcr90/tests/msvcr90.c:147:14: warning: 'do_call_func2' defined but not used dlls/m

Re: [1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend)

2011-02-16 Thread Alistair Leslie-Hughes
Hi Jacek, -- From: "Jacek Caban" Sent: Wednesday, February 16, 2011 8:44 PM To: "Alistair Leslie-Hughes" Cc: "Wine Devel" Subject: Re: [1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend) We need to just ignore two know

Re: [1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend)

2011-02-16 Thread Jacek Caban
On 2/15/11 9:26 AM, Alistair Leslie-Hughes wrote: Hi Jacek, On 14/02/2011 9:48 PM, Jacek Caban wrote: On 2/14/11 10:03 AM, Alistair Leslie-Hughes wrote: Changelog: mshtml: Ignore IActiveScript interface for IXMLHTTPRequest mshtml? + else if ( IsEqualGUID( riid,&IID_IActiveScript)) + { + TRA