Hi,
any problem with the patch
http://source.winehq.org/patches/data/74702
A+
David
David Laight wrote:
> On Fri, May 27, 2011 at 10:09:04PM +0400, Nikolay Sivov wrote:
>> On Fri, May 27, 2011 at 5:16 PM, Marko Nikolic wrote:
>> > ---
>> > ?dlls/comctl32/tests/treeview.c | ? ?6 +++---
>> > ?1 files changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/dlls/comctl32/tes
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11350
Your paranoid android
On Tuesday 31 May 2011 17:48:14 Sean Sube wrote:
> +static const DWORD ps_code[] =
> +{
> +0x0200, 0x021F, 0x9000, 0xA00F0800,
> +0x021F, 0x8000, 0xB00F, 0x0342,
> +0x800F, 0xB0E4, 0xA0E4, 0x0201,
> +0x800F0800,
On 05/31/2011 12:02 PM, Dmitry Timoshkov wrote:
Adam Martinson wrote:
+/* Check the current process and all ancestors. Some apps run sub-processes
that
+ * have the IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but the parent process
doesn't.
+ * (eg, Dragon NaturallySpeaking 7 setup runs Instal
On 05/31/2011 12:09 PM, Dmitry Timoshkov wrote:
Adam Martinson wrote:
+if (osver.dwMajorVersion>= 5)
That's a wrong check for win9x.
It's not, it's a check for win2k and later, the stuff in that block
isn't done for win9x.
Adam Martinson wrote:
> +if (osver.dwMajorVersion >= 5)
That's a wrong check for win9x.
--
Dmitry.
Adam Martinson wrote:
> +/* Check the current process and all ancestors. Some apps run sub-processes
> that
> + * have the IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but the parent process
> doesn't.
> + * (eg, Dragon NaturallySpeaking 7 setup runs Install Shield 6).
> + * If any don't have IMAG
On 05/31/2011 10:47 AM, Stefan Dösinger wrote:
> Does the enum_device_entry structure have to be in ddraw_private.h? I
> think you can just declare it in ddraw.c because it is used only there.
No, I simply defined the structure there to be consistent with the role
of the unused structure definitio
Does the enum_device_entry structure have to be in ddraw_private.h? I think you
can just declare it in ddraw.c because it is used only there.
At some point we'll want to get rid of the ddraw device type strings and call
wined3d_get_adapter_identifier - but that needs more work and some more test
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 31.05.2011 um 12:50 schrieb Alexandre Julliard:
> I mean using D3DPOOL in wined3d, not by including the d3d9 headers, but
> by defining it when necessary, i.e. if neither d3d8types.h nor
> d3d9types.h have been included already.
This would lead to
I'm looking forward to Andrew's test-only patch...
When I saw he had a test on testbot, I probably should
have dropped mine.
On 05/31/2011 08:17 AM, Hans Leidekker wrote:
> On Tue, 2011-05-31 at 06:32 -0500, Andrew Nguyen wrote:
>
>> -DWORD sizeW = *lpSize * 2;
>> +DWORD sizeW = 0;
>> +
>> +GetUserNameW( NULL, &sizeW );
>
> Can we avoid the extra call?
I was trying to avoid making the assumption that a Uni
On Tue, 2011-05-31 at 06:32 -0500, Andrew Nguyen wrote:
> -DWORD sizeW = *lpSize * 2;
> +DWORD sizeW = 0;
> +
> +GetUserNameW( NULL, &sizeW );
Can we avoid the extra call?
> I didn't intend to scoop Dan's work, but I have a version of his fix,
> which is attached, with deeper tests w
On Tue, May 31, 2011 at 12:51 PM, Michael Mc Donnell
wrote:
> On Mon, May 30, 2011 at 10:09 PM, Matteo Bruni
> wrote:
>> 2011/5/30 Michael Mc Donnell :
>>> Thanks for the comments Matteo! I have a few questions below.
>>>
>>> On Mon, May 30, 2011 at 2:45 PM, Matteo Bruni
>>> wrote:
2011/5
The Pathologic demo in bug 21552 expects that the reference count of a
IDirect3D9 instance is incremented after a successful call to
CreateDevice with the instance.
Does my proposed fix for d3d8 and d3d9 manage the reference count of the
device parent appropriately? In particular, I'm concerned ab
On 05/31/2011 02:17 AM, Hans Leidekker wrote:
> On Mon, 2011-05-30 at 21:13 -0700, Dan Kegel wrote:
>
>> @@ -91,7 +91,7 @@ GetUserNameW( LPWSTR lpszName, LPDWORD lpSize )
>>
>> if (len > *lpSize)
>> {
>> -SetLastError(ERROR_MORE_DATA);
>> +SetLastError(ERROR_INSUFFICIEN
On Mon, May 30, 2011 at 10:09 PM, Matteo Bruni wrote:
> 2011/5/30 Michael Mc Donnell :
>> Thanks for the comments Matteo! I have a few questions below.
>>
>> On Mon, May 30, 2011 at 2:45 PM, Matteo Bruni
>> wrote:
>>> 2011/5/29 Michael Mc Donnell :
On Sat, May 28, 2011 at 10:08 PM, Stefan D
Stefan Dösinger writes:
> Am 31.05.2011 um 12:12 schrieb Alexandre Julliard:
>> Most enums are identical, or just have an extra value or two. I don't
>> see why you can't pass either type to wined3d since they have the same
>> name.
> Do you mean the status quo? Or do you mean using the D3DPOOL t
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 31.05.2011 um 12:12 schrieb Alexandre Julliard:
> Most enums are identical, or just have an extra value or two. I don't
> see why you can't pass either type to wined3d since they have the same
> name.
Do you mean the status quo? Or do you mean usin
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11331
Your paranoid android
Stefan Dösinger writes:
> Am 31.05.2011 um 11:10 schrieb Alexandre Julliard:
>> I still don't see the point of that kind of switch statement. To be
>> honest I don't see either why we even need different enum types in the
>> first place.
> Because for most enums the d3d8 ones differ from the d3d9
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 31.05.2011 um 11:10 schrieb Alexandre Julliard:
> I still don't see the point of that kind of switch statement. To be
> honest I don't see either why we even need different enum types in the
> first place.
Because for most enums the d3d8 ones diffe
André Hentschel writes:
> +if (ret && callback) callback(NtCurrentTeb()->FlsSlots[index]);
> +/* FIXME: add equivalent of ThreadZeroTlsCell here */
> +if (NtCurrentTeb()->FlsSlots) NtCurrentTeb()->FlsSlots[index] = 0;
It's not that easy...
--
Alexandre Julliard
julli...@winehq.org
Frédéric Delanoy writes:
> +static inline D3DPOOL d3dpool_from_wined3dpool(WINED3DPOOL type)
> +{
> +switch (type)
> +{
> +case WINED3DPOOL_DEFAULT: return D3DPOOL_DEFAULT;
> +case WINED3DPOOL_MANAGED: return D3DPOOL_MANAGED;
> +case WINED3DPOOL_SYSTEMMEM: return D
On Mon, 2011-05-30 at 21:13 -0700, Dan Kegel wrote:
> @@ -91,7 +91,7 @@ GetUserNameW( LPWSTR lpszName, LPDWORD lpSize )
>
> if (len > *lpSize)
> {
> -SetLastError(ERROR_MORE_DATA);
> +SetLastError(ERROR_INSUFFICIENT_BUFFER);
GetUserNameA also needs to be fixed. It sets
26 matches
Mail list logo
