Re: winspool/tests: Don't crash when AddJob/GetJob fails (win8)

2012-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21799 Your paranoid android

Re: ImmIsUIMessageA/W

2012-09-25 Thread André Hentschel
Am 25.09.2012 21:54, schrieb Henri Verbeet: > On 25 September 2012 21:12, André Hentschel wrote: >> I don't remember the app, be free to patch it in again, at best with tests. >> > Wasn't that for World of Tanks? > Oh, true. thx. It's all about http://bugs.winehq.org/show_bug.cgi?id=27554 d08fa6

Re: Wine Mono 0.0.6 Release - Because hey, why not?

2012-09-25 Thread Vincent Povirk
So, it seems I've screwed up this release. Sorry about that. It won't be added to Wine, and I'll try again later. Specifically, I messed up the flags on the mono-registry64 msi component, and I forgot to commit the guids for the new System.Web.Http.SelfHost msi components (which means packages bui

Re: ImmIsUIMessageA/W

2012-09-25 Thread Henri Verbeet
On 25 September 2012 21:12, André Hentschel wrote: > I don't remember the app, be free to patch it in again, at best with tests. > Wasn't that for World of Tanks?

Re: ImmIsUIMessageA/W

2012-09-25 Thread André Hentschel
Am 25.09.2012 14:48, schrieb Aric Stewart: >> >>> also you eliminate the part where if the incoming hWndIME is NULL we send >>> the message to the thread's default IME window. >> >> my changes made an app happy IIRC, further i think i was skeptical about >> IMM_GetThreadData()->hwndDefault becaus

Re: imm32: there is only 1 default Hwnd per thread

2012-09-25 Thread Aric Stewart
On 9/25/12 1:38 PM, Alexandre Julliard wrote: > Aric Stewart writes: > >> @@ -2323,12 +2323,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) >> >> if (data->imeWnd == NULL) >> { >> -/* create the ime window */ >> -data->imeWnd = CreateWindowExW( WS_EX_TOOL

Re: imm32: there is only 1 default Hwnd per thread

2012-09-25 Thread Alexandre Julliard
Aric Stewart writes: > @@ -2323,12 +2323,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > > if (data->imeWnd == NULL) > { > -/* create the ime window */ > -data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > -data->immKbd->imeClassName, N

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.

2012-09-25 Thread André Hentschel
Am 25.09.2012 18:40, schrieb Qian Hong: > Hi Juan, > > On Tue, Sep 25, 2012 at 11:53 PM, Juan Lang wrote: >> >> I think this is fine, but you'd want to remove/fix some outdated >> comments I wrote at the same time: > > Thank you very much! > I'll send an improved version tomorrow since I just dr

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.

2012-09-25 Thread Qian Hong
Hi Juan, On Tue, Sep 25, 2012 at 11:53 PM, Juan Lang wrote: > > I think this is fine, but you'd want to remove/fix some outdated > comments I wrote at the same time: Thank you very much! I'll send an improved version tomorrow since I just drank some beer right now and I think it is not compatibl

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.

2012-09-25 Thread Juan Lang
Hi Qian, > There is a winpcap based network authentication client which check for the > DhcpEnabled value, this patch make the app happy and then the app works with > André's pcap wrapper [1]. > > Please let me know if this is acceptable, or we have to correctly implement > DhcpEnabled status?

Re: [PATCH 1/2] mshtml: Added DISPATCH_PROPERTYGET|DISPATCH_METHOD flags support for elements exposed as window properties

2012-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21785 Your paranoid android

Re: vbscript: Added Space() implementation

2012-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21787 Your paranoid android

Re: ImmIsUIMessageA/W

2012-09-25 Thread Aric Stewart
Hi Andre, On 9/24/12 3:00 PM, André Hentschel wrote: > Am 21.09.2012 18:46, schrieb Aric Stewart: >> Hi Andre, >> >> I have a quick question for you. I am looking into why IME unaware >> applications are no longer showing their composition window and found it was >> because of: >> >> commit 7673

Re: shlwapi: PathCreateFromUrlA() should not crash when given NULL buffers.

2012-09-25 Thread Alexandre Julliard
Francois Gouget writes: > Add NULL and insufficient buffer tests for PathCreateFromUrl(). > --- > dlls/shlwapi/path.c |3 +++ > dlls/shlwapi/tests/path.c | 49 > + > 2 files changed, 35 insertions(+), 17 deletions(-) It doesn't work here:

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize

2012-09-25 Thread Alistair Leslie-Hughes
On 25/09/2012 8:44 PM, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDeta

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize

2012-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21782 Your paranoid android

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

2012-09-25 Thread Per Johansson
On Tue, Sep 25, 2012 at 10:57 AM, Francois Gouget wrote: > On Tue, 25 Sep 2012, Per Johansson wrote: > > > Hi, > > > > I should probably add a note that when I wrote this I had some doubts it > it > > belongs in start.exe, and I still somewhat do. > > > > The alternative would be to write a new p

Re: [5/5] dxgi/tests: Test some reference counts.

2012-09-25 Thread Alexandre Julliard
Ričardas Barkauskas writes: > --- > dlls/dxgi/tests/device.c | 69 > ++ > 1 file changed, 51 insertions(+), 18 deletions(-) In general testing reference count values is not useful, unless you have an app that depends on it. -- Alexandre Julliard j

Re: Spam applications for testbot accounts

2012-09-25 Thread Francois Gouget
On Mon, 17 Sep 2012, Scott Ritchie wrote: > Never underestimate the overeagerness of bots, I suppose... > > We're getting a lot of spam applications for testbot accounts now, maybe 2-3 > per day. Some are easy to discard because they put stuff like penis pills > into the info field, but others l

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

2012-09-25 Thread Francois Gouget
On Tue, 25 Sep 2012, Per Johansson wrote: > Hi, > > I should probably add a note that when I wrote this I had some doubts it it > belongs in start.exe, and I still somewhat do. > > The alternative would be to write a new program. The advantage to that is: Start.exe already has a /unix option so