On Mon, Oct 8, 2012 at 5:17 PM, André Hentschel wrote:
> Am 08.10.2012 01:06, schrieb Kyle Auble:
>> Just wanted to let everyone know I've created a
>> git repo for the Wine Wiki from the CVS one at
>> SourceForge. You can find it at:
>> https://bitbucket.org/kauble/wine-wiki-migration
> Not sure
On Mon, Oct 8, 2012 at 9:18 AM, Jeremy Newman wrote:
> I'd like to port our theme over to this.
> Also, yes, I think we should look into WineHQ hosting the git for this.
I've played with the code just a little on my own
machine and MoinMoin 1.9.5. I haven't made much
progress yet; some of the old
Am 08.10.2012 01:06, schrieb Kyle Auble:
> Just wanted to let everyone know I've created a
> git repo for the Wine Wiki from the CVS one at
> SourceForge. You can find it at:
> https://bitbucket.org/kauble/wine-wiki-migration
Not sure if bitbucket is the right place, there are not much repos regar
writes:
> Alexandre wrote:
>
>>> if (wmm->dwStatus == MCI_MODE_PAUSE) continue;
>>> if (wmm->dwStatus != MCI_MODE_PLAY) break; but that's not the same.
>>> A concurrent thread might change dwStatus to PAUSE right between the 2
>>> lines.
>
>>If the code depends on that sort of thing then
Alexandre wrote:
>> if (wmm->dwStatus == MCI_MODE_PAUSE) continue;
>> if (wmm->dwStatus != MCI_MODE_PLAY) break; but that's not the same.
>> A concurrent thread might change dwStatus to PAUSE right between the 2
>> lines.
>If the code depends on that sort of thing then it's broken.
>If an
Am 08.10.2012 12:35, schrieb Alexandre Julliard:
> André Hentschel writes:
>
>> Sry, seen this too late.
>> I need it for user32/tests/edit.c: test_extra_values()
>> It expects the size of the edit class like this:
>>
>> #ifdef _WIN64
>> {"Edit",8,8},
>> #else
>> {"Edit",6,8},
>> #endif
>
writes:
> Hi,
>
>>+switch (wmm->dwStatus) {
>>+case MCI_MODE_PLAY:
>>+case MCI_MODE_PAUSE:
>>+ wmm->dwStatus = MCI_MODE_STOP;
>>+}
>
>>This is weird. You're "missing" a break,
> You're right, at least a /* fall through */ or break is custom.
>
>>and it seems like an if stateme
Hi,
>+switch (wmm->dwStatus) {
>+case MCI_MODE_PLAY:
>+case MCI_MODE_PAUSE:
>+ wmm->dwStatus = MCI_MODE_STOP;
>+}
>This is weird. You're "missing" a break,
You're right, at least a /* fall through */ or break is custom.
>and it seems like an if statement would be more approp
Hello Dmitry,
On Mon, Oct 8, 2012 at 1:59 PM, Dmitry Timoshkov wrote:
>> Any feedback for this patch? Thanks a lot for any comments!
>
> I'd try to avoid extra EnumFontFamiliesEx call, and probably do the checks
> you need in the previous one.
Thanks for advice! I'll send an improved version.
Alistair Leslie-Hughes writes:
> static HRESULT WINAPI dictionary_get_Count(IDictionary *iface, LONG *pCount)
> {
> dictionary *This = impl_from_IDictionary(iface);
>
> -FIXME("(%p)->(%p)\n", This, pCount);
> +TRACE("(%p)->(%p)\n", This, pCount);
>
> -*pCount = 0;
> +*p
Series looks good to me.
That's a lot of patches! In the future, please try to send no more
than about 5 at a time, until each batch is committed. That's much
easier to review.
I reviewed the first 12, and will do the rest after those are
committed. Just reading the patches, I didn't notice any
show-stoppers. Overall loo
I'd like to port our theme over to this.
Also, yes, I think we should look into WineHQ hosting the git for this.
-N
On 10/07/2012 06:06 PM, Kyle Auble wrote:
Just wanted to let everyone know I've created a
git repo for the Wine Wiki from the CVS one at
SourceForge. You can find it at:
https://
Vincent Povirk writes:
> From eb900b2807167f25ad8f4e97c558dec8b71b070c Mon Sep 17 00:00:00 2001
> From: Vincent Povirk
> Date: Thu, 4 Oct 2012 16:58:48 -0500
> Subject: [PATCH 3/4] ole32: Move the propvariant serialization into a helper
> function.
It doesn't work here:
../../../tools/runtest
André Hentschel writes:
> Sry, seen this too late.
> I need it for user32/tests/edit.c: test_extra_values()
> It expects the size of the edit class like this:
>
> #ifdef _WIN64
> {"Edit",8,8},
> #else
> {"Edit",6,8},
> #endif
>
> So this fails on e.g. ARM because code and test use differe
On 8 October 2012 03:52, Jimmy Hon wrote:
> +CARD_NVIDIA_GEFORCE_GTX650 = 0x0FC6,
> +CARD_NVIDIA_GEFORCE_GTX660 = 0x11C0,
> +CARD_NVIDIA_GEFORCE_GTX660TI= 0x1183,
Please use lower case constants like everywhere else.
16 matches
Mail list logo