Re: Updated Wine Wiki Repo

2012-10-08 Thread Kyle Auble
On Mon, Oct 8, 2012 at 5:17 PM, André Hentschel wrote: > Am 08.10.2012 01:06, schrieb Kyle Auble: >> Just wanted to let everyone know I've created a >> git repo for the Wine Wiki from the CVS one at >> SourceForge. You can find it at: >> https://bitbucket.org/kauble/wine-wiki-migration > Not sure

Re: Updated Wine Wiki Repo

2012-10-08 Thread Kyle Auble
On Mon, Oct 8, 2012 at 9:18 AM, Jeremy Newman wrote: > I'd like to port our theme over to this. > Also, yes, I think we should look into WineHQ hosting the git for this. I've played with the code just a little on my own machine and MoinMoin 1.9.5. I haven't made much progress yet; some of the old

Re: Updated Wine Wiki Repo

2012-10-08 Thread André Hentschel
Am 08.10.2012 01:06, schrieb Kyle Auble: > Just wanted to let everyone know I've created a > git repo for the Wine Wiki from the CVS one at > SourceForge. You can find it at: > https://bitbucket.org/kauble/wine-wiki-migration Not sure if bitbucket is the right place, there are not much repos regar

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-08 Thread Alexandre Julliard
writes: > Alexandre wrote: > >>> if (wmm->dwStatus == MCI_MODE_PAUSE) continue; >>> if (wmm->dwStatus != MCI_MODE_PLAY) break; but that's not the same. >>> A concurrent thread might change dwStatus to PAUSE right between the 2 >>> lines. > >>If the code depends on that sort of thing then

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-08 Thread Joerg-Cyril.Hoehle
Alexandre wrote: >> if (wmm->dwStatus == MCI_MODE_PAUSE) continue; >> if (wmm->dwStatus != MCI_MODE_PLAY) break; but that's not the same. >> A concurrent thread might change dwStatus to PAUSE right between the 2 >> lines. >If the code depends on that sort of thing then it's broken. >If an

Re: user32: Fix the edit class extra byte count on non-x86 platforms (try 2)

2012-10-08 Thread André Hentschel
Am 08.10.2012 12:35, schrieb Alexandre Julliard: > André Hentschel writes: > >> Sry, seen this too late. >> I need it for user32/tests/edit.c: test_extra_values() >> It expects the size of the edit class like this: >> >> #ifdef _WIN64 >> {"Edit",8,8}, >> #else >> {"Edit",6,8}, >> #endif >

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-08 Thread Alexandre Julliard
writes: > Hi, > >>+switch (wmm->dwStatus) { >>+case MCI_MODE_PLAY: >>+case MCI_MODE_PAUSE: >>+ wmm->dwStatus = MCI_MODE_STOP; >>+} > >>This is weird. You're "missing" a break, > You're right, at least a /* fall through */ or break is custom. > >>and it seems like an if stateme

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-08 Thread Joerg-Cyril.Hoehle
Hi, >+switch (wmm->dwStatus) { >+case MCI_MODE_PLAY: >+case MCI_MODE_PAUSE: >+ wmm->dwStatus = MCI_MODE_STOP; >+} >This is weird. You're "missing" a break, You're right, at least a /* fall through */ or break is custom. >and it seems like an if statement would be more approp

Re: [PATCH 2/2] gdi32/tests: Fixed broken tests on non English system Part 2.

2012-10-08 Thread Qian Hong
Hello Dmitry, On Mon, Oct 8, 2012 at 1:59 PM, Dmitry Timoshkov wrote: >> Any feedback for this patch? Thanks a lot for any comments! > > I'd try to avoid extra EnumFontFamiliesEx call, and probably do the checks > you need in the previous one. Thanks for advice! I'll send an improved version.

Re: [1/3] scrrun: Implement IDictionary_Add and Count

2012-10-08 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > static HRESULT WINAPI dictionary_get_Count(IDictionary *iface, LONG *pCount) > { > dictionary *This = impl_from_IDictionary(iface); > > -FIXME("(%p)->(%p)\n", This, pCount); > +TRACE("(%p)->(%p)\n", This, pCount); > > -*pCount = 0; > +*p

Re: [1/4] gdiplus: Add a font transformation test.

2012-10-08 Thread Vincent Povirk
Series looks good to me.

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-08 Thread Andrew Eikum
That's a lot of patches! In the future, please try to send no more than about 5 at a time, until each batch is committed. That's much easier to review. I reviewed the first 12, and will do the rest after those are committed. Just reading the patches, I didn't notice any show-stoppers. Overall loo

Re: Updated Wine Wiki Repo

2012-10-08 Thread Jeremy Newman
I'd like to port our theme over to this. Also, yes, I think we should look into WineHQ hosting the git for this. -N On 10/07/2012 06:06 PM, Kyle Auble wrote: Just wanted to let everyone know I've created a git repo for the Wine Wiki from the CVS one at SourceForge. You can find it at: https://

Re: [3/4] ole32: Move the propvariant serialization into a helper function.

2012-10-08 Thread Alexandre Julliard
Vincent Povirk writes: > From eb900b2807167f25ad8f4e97c558dec8b71b070c Mon Sep 17 00:00:00 2001 > From: Vincent Povirk > Date: Thu, 4 Oct 2012 16:58:48 -0500 > Subject: [PATCH 3/4] ole32: Move the propvariant serialization into a helper > function. It doesn't work here: ../../../tools/runtest

Re: user32: Fix the edit class extra byte count on non-x86 platforms (try 2)

2012-10-08 Thread Alexandre Julliard
André Hentschel writes: > Sry, seen this too late. > I need it for user32/tests/edit.c: test_extra_values() > It expects the size of the edit class like this: > > #ifdef _WIN64 > {"Edit",8,8}, > #else > {"Edit",6,8}, > #endif > > So this fails on e.g. ARM because code and test use differe

Re: wined3d: Add retail NVIDIA GeForce GTX 660Ti/660/650

2012-10-08 Thread Henri Verbeet
On 8 October 2012 03:52, Jimmy Hon wrote: > +CARD_NVIDIA_GEFORCE_GTX650 = 0x0FC6, > +CARD_NVIDIA_GEFORCE_GTX660 = 0x11C0, > +CARD_NVIDIA_GEFORCE_GTX660TI= 0x1183, Please use lower case constants like everywhere else.