Re: Wine Gecko versioning

2012-11-27 Thread Rosanne DiMesio
On Tue, 27 Nov 2012 18:33:20 +0300 Nikolay Sivov wrote: > It's described here http://wiki.winehq.org/Gecko. I guess failure > message loading gecko (in load_gecko()) could be improved adding > GECKO_VERSION to it so user clearly see what version he needs to have if > it's somehow not downloade

Re: Wine Gecko versioning

2012-11-27 Thread Jacek Caban
On 11/27/12 16:33, Nikolay Sivov wrote: > On 11/27/2012 17:26, Rosanne DiMesio wrote: >> On Tue, 27 Nov 2012 13:32:02 +0100 >> Jacek Caban wrote: >> >>> The idea is that Wine Gecko version could be just something based on >>> other versions, that are more informative. >>> >> Users don't care what

Re: [PATCH] d3dx9_36/tests: Fix broken line test

2012-11-27 Thread Matteo Bruni
2012/11/27 Detlef Riekenberg : > While inspecting a test failure, i found only > 3 possible results for the line test: > - d3dx9_36.dll not present > - all tests skipped > line.c:146: Tests skipped: Failed to create IDirect3DDevice9 object > 0x8876086c > - refcount test failed > line.c:113: Te

Re: Wine Gecko versioning

2012-11-27 Thread Jacek Caban
On 11/27/12 14:53, André Hentschel wrote: > Am 27.11.2012 13:32, schrieb Jacek Caban: >> The idea is that Wine Gecko version could be just something based on >> other versions, that are more informative. It's not really possible to >> use Wine version, because the first version of Wine that will us

Re: Wine Gecko versioning

2012-11-27 Thread Nikolay Sivov
On 11/27/2012 17:26, Rosanne DiMesio wrote: On Tue, 27 Nov 2012 13:32:02 +0100 Jacek Caban wrote: The idea is that Wine Gecko version could be just something based on other versions, that are more informative. Users don't care what version of Firefox the latest gecko is based on; most don't

Re: Wine Gecko versioning

2012-11-27 Thread Rosanne DiMesio
On Tue, 27 Nov 2012 13:32:02 +0100 Jacek Caban wrote: > The idea is that Wine Gecko version could be just something based on > other versions, that are more informative. > Users don't care what version of Firefox the latest gecko is based on; most don't even realize it is based on Firefox. Wh

Re: Wine Gecko versioning

2012-11-27 Thread André Hentschel
Am 27.11.2012 13:32, schrieb Jacek Caban: > The idea is that Wine Gecko version could be just something based on > other versions, that are more informative. It's not really possible to > use Wine version, because the first version of Wine that will use new > Gecko is not ultimately when Wine Gecko

Wine Gecko versioning

2012-11-27 Thread Jacek Caban
Hi all, Since Wine Gecko 1.9 branching, the tip should bump to 1.10, but I think it's time to clean up the situation a bit. Such things usually don't bring much attention, but it should be decided in public. Right now we have three versioning schemes involved in Wine Gecko: - Wine version that app

Re: [PATCH] cabinet: Turn some ERR into WARN and improved or fix messages.

2012-11-27 Thread Christian Costa
> -BOOL __cdecl FDIIsCabinet( >> - HFDIhfdi, >> - INT_PTR hf, >> - PFDICABINETINFO pfdici) >> +BOOL __cdecl FDIIsCabinet(HFDI hfdi, INT_PTR hf, PFDICABINETINFO pfdici) >> { >> BOOL rv; >> FDI_Int *fdi = get_fdi_ptr( hfdi ); >> @@ -749,13 +746,13 @@ BO

Re: msvcp60: Remove superfluous semicolons

2012-11-27 Thread Jacek Caban
On 11/26/12 22:35, Andrew Talbot wrote: > Jacek Caban wrote: > >> It's probably better to change the macro to require the semicolon. >> >> Jacek > The reason I did it that way was because there are two variants of the > DEFINE_CXX_DATA macro, surrounded by an #ifndef construct: one comprising > thr

Re: winex11: Add a few 'fall through' comments.

2012-11-27 Thread Huw Davies
On Tue, Nov 27, 2012 at 06:44:35PM +0800, Dmitry Timoshkov wrote: > case DirectColor: > X11DRV_PALETTE_PaletteFlags |= X11DRV_PALETTE_VIRTUAL; > /* fall through */ > case GrayScale: > > would be more clear IMHO. Right now it's not obvious to which case statement > 'fall throu

Re: winex11: Add a few 'fall through' comments.

2012-11-27 Thread Dmitry Timoshkov
Huw Davies wrote: > case DirectColor: > X11DRV_PALETTE_PaletteFlags |= X11DRV_PALETTE_VIRTUAL; > -case GrayScale: > +case GrayScale: /* fall through */ case DirectColor: X11DRV_PALETTE_PaletteFlags |= X11DRV_PALETTE_VIRTUAL; /* fall through */ case Gray

Re: [PATCH] cabinet: Turn some ERR into WARN and improved or fix messages.

2012-11-27 Thread Nikolay Sivov
On 11/27/2012 11:14, Christian Costa wrote: --- dlls/cabinet/fdi.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/dlls/cabinet/fdi.c b/dlls/cabinet/fdi.c index 0690b38..809a5c0 100644 --- a/dlls/cabinet/fdi.c +++ b/dlls/cabinet/fdi.c @@ -710,7 +710,7 @@ s