Re: comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.

2013-06-17 Thread Ken Thomases
On Jun 18, 2013, at 1:26 AM, Dmitry Timoshkov wrote: > Daniel Jeliński wrote: > >> I'm quite sure you didn't mean to ignore return value of GetStockObject and >> leave logfont uninitialized here. > > GetStockObject(DEFAULT_GUI_FONT) can't fail. I think the question is: what does line 1917 do?

Re: comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.

2013-06-17 Thread Dmitry Timoshkov
Daniel Jeliński wrote: > I'm quite sure you didn't mean to ignore return value of GetStockObject and > leave logfont uninitialized here. GetStockObject(DEFAULT_GUI_FONT) can't fail. -- Dmitry.

Re: comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.

2013-06-17 Thread Daniel Jeliński
Hi Dmitry, After this patch got applied, the code looks like this: ( http://source.winehq.org/git/wine.git/blob/cc086f09ae46c77e6eb4a817ae567294d3f795ec:/dlls/comctl32/tab.c#l1914 ) 1914 if (!GetObjectW((infoPtr->hFont) ? 1915 infoPtr->hFont : GetStockObject(DEFAULT_GUI_FONT), 1916 sizeof(LOGFONTW)

Re: po: Update Spanish translation

2013-06-17 Thread Bruno Jesus
On Mon, Jun 17, 2013 at 6:05 PM, André Hentschel wrote: > I recently started to learn spanish, so i did this easy fixes with best > knowledge, though without guaranty > --- > po/es.po | 60 ++-- > 1 file changed, 18 insertions(+), 42 deleti

Re: Web based translation tool

2013-06-17 Thread Aric Stewart
Hi, I just wanted to say that I have not totally abandoned this. A few months ago I again contacted my contacts at the various web translations sites and go no new good news. Still nothing gave us everything we needed. I have been super busy with other work (hence the smaller number of patches

Re: Web based translation tool

2013-06-17 Thread André Hentschel
On 04.04.2012 16:05, Michal Čihař wrote: > Hi > > Dne Thu, 15 Mar 2012 10:12:14 -0500 > Aric Stewart napsal(a): > >> I do not know if Weblate will work or not. >> >> Basically we have 3 big requirements that have been sticking points for >> various solutions. >> >> 1) Real Names and e-mails for

Re: po: Update Italian translation (try 2)

2013-06-17 Thread Fabian Ebner
Am 17.06.2013 18:56, schrieb Matteo Bruni: 2013/6/17 Fabian Ebner : Fixed a typo and a sentence, thanks to Matteo --- po/it.po | 40 ++-- 1 file changed, 14 insertions(+), 26 deletions(-) #: jscript.rc:39 msgid "'return' statement outside of function"

Re: ole32: Do not fail if partial blocks are read

2013-06-17 Thread Bruno Jesus
On Mon, Jun 17, 2013 at 1:28 PM, Aric Stewart wrote: > > fixes bug 25346 Actually this patch fixes bug 33821. Bug 25346 is older than the regression and was only affected by it. > --- > dlls/ole32/storage32.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Best wishes, Bruno

Re: po: Update Italian translation (try 2)

2013-06-17 Thread Matteo Bruni
2013/6/17 Fabian Ebner : > Fixed a typo and a sentence, thanks to Matteo > --- > po/it.po | 40 ++-- > 1 file changed, 14 insertions(+), 26 deletions(-) #: jscript.rc:39 msgid "'return' statement outside of function" -msgstr "" +msgstr "Istruzione 'return' fo

Re: Update Italian translation

2013-06-17 Thread Matteo Bruni
2013/6/16 Fabian Ebner : > --- > po/it.po | 40 ++-- > 1 file changed, 14 insertions(+), 26 deletions(-) #: joy.rc:42 msgid "" "After disabling or enabling a device, the connected joysticks won't be " "updated here until you restart this applet." msgstr

Re: [PATCH] gdi32: do not overwrite variables (Coverity) (resubmit)

2013-06-17 Thread Alexandre Julliard
Marcus Meissner writes: > Hi, > > CID 743138,743137,743136 > wrote a DWORD (32bit) into a SHORT (16bit) entity. > > Not sure what is wrong with this one... it is a pretty clear bug to me. It's a bug, but it can be fixed in a better way. That helper function is badly designed. -- Alexandre Jull